<div dir="ltr">Thanks very much for your help. :)</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jul 11, 2013 at 5:54 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Design aesthetic would usually dictate what method is used to handle long, non-breaking text. The critical concern is that long, non-breaking text doesn't *break* the layout.<div>
<br></div><div>"More" function does need to function properly.</div>
<div><br></div><div>Handling of a given menu size is also part of design aesthetic, though it is appropriate to require the developer to include any unusual limitations (such as "primary menu only supports 5 top-level menu items") in the Theme documentation (i.e. readme file) so that the end user is aware.</div>
<div><br></div><div>The number and severity of these issues is such that I would list them as *required*, but approve the ticket on the basis that they be addressed in the next Theme revision.</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote"><div><div class="h5">On Thu, Jul 11, 2013 at 12:49 PM, Siobhan Bamber <span dir="ltr"><<a href="mailto:siobhanbamber@gmail.com" target="_blank">siobhanbamber@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
<div dir="ltr"><span style="font-family:arial,sans-serif;font-size:13.333333969116211px">Hi everyone,</span><div style="font-family:arial,sans-serif;font-size:13.333333969116211px"><br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
I'm going through the individual post unit tests for a theme I've been assigned and have a few questions. </div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px"><br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
I've come across these issues in the individual posts unit test:</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px"><br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
- Long non-breaking text is cut off. Should make use of the “word-wrap” CSS property in order to prevent this.</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px"><br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
- “More” tag does not function in blog posts.</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px"><br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">- Dropdown menus with a high depth of submenus can go off-screen. </div>
<div style="font-family:arial,sans-serif;font-size:13.333333969116211px"><br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">These are the only errors I could find. The theme seems to pass in terms of code quality etc. In your opinion, are the errors I found big enough to constitute a "Not-Approved" status? </div>
<div style="font-family:arial,sans-serif;font-size:13.333333969116211px"><br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">Many thanks.</div><span><font color="#888888"><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
<br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">Siobhan</div></font></span></div>
<br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>