<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Is the more function required if the (index) is only showing excerpts?<br> <BR><div><hr id="stopSpelling">Date: Thu, 11 Jul 2013 12:54:19 -0400<br>From: chip@chipbennett.net<br>To: theme-reviewers@lists.wordpress.org<br>Subject: Re: [theme-reviewers] Theme Review Help<br><br><div dir="ltr">Design aesthetic would usually dictate what method is used to handle long, non-breaking text. The critical concern is that long, non-breaking text doesn't *break* the layout.<div><br></div><div>"More" function does need to function properly.</div>
<div><br></div><div>Handling of a given menu size is also part of design aesthetic, though it is appropriate to require the developer to include any unusual limitations (such as "primary menu only supports 5 top-level menu items") in the Theme documentation (i.e. readme file) so that the end user is aware.</div>
<div><br></div><div>The number and severity of these issues is such that I would list them as *required*, but approve the ticket on the basis that they be addressed in the next Theme revision.</div></div><div class="ecxgmail_extra">
<br><br><div class="ecxgmail_quote">On Thu, Jul 11, 2013 at 12:49 PM, Siobhan Bamber <span dir="ltr"><<a href="mailto:siobhanbamber@gmail.com" target="_blank">siobhanbamber@gmail.com</a>></span> wrote:<br><blockquote class="ecxgmail_quote" style="padding-left: 1ex; border-left-color: rgb(204, 204, 204); border-left-width: 1px; border-left-style: solid;">
<div dir="ltr"><span style="font-family: arial,sans-serif; font-size: 13.33px;">Hi everyone,</span><div style="font-family: arial,sans-serif; font-size: 13.33px;"><br></div><div style="font-family: arial,sans-serif; font-size: 13.33px;">
I'm going through the individual post unit tests for a theme I've been assigned and have a few questions. </div><div style="font-family: arial,sans-serif; font-size: 13.33px;"><br></div><div style="font-family: arial,sans-serif; font-size: 13.33px;">
I've come across these issues in the individual posts unit test:</div><div style="font-family: arial,sans-serif; font-size: 13.33px;"><br></div><div style="font-family: arial,sans-serif; font-size: 13.33px;">
- Long non-breaking text is cut off. Should make use of the “word-wrap” CSS property in order to prevent this.</div><div style="font-family: arial,sans-serif; font-size: 13.33px;"><br></div><div style="font-family: arial,sans-serif; font-size: 13.33px;">
- “More” tag does not function in blog posts.</div><div style="font-family: arial,sans-serif; font-size: 13.33px;"><br></div><div style="font-family: arial,sans-serif; font-size: 13.33px;">- Dropdown menus with a high depth of submenus can go off-screen. </div>
<div style="font-family: arial,sans-serif; font-size: 13.33px;"><br></div><div style="font-family: arial,sans-serif; font-size: 13.33px;">These are the only errors I could find. The theme seems to pass in terms of code quality etc. In your opinion, are the errors I found big enough to constitute a "Not-Approved" status? </div>
<div style="font-family: arial,sans-serif; font-size: 13.33px;"><br></div><div style="font-family: arial,sans-serif; font-size: 13.33px;">Many thanks.</div><span class="ecxHOEnZb"><font color="#888888"><div style="font-family: arial,sans-serif; font-size: 13.33px;">
<br></div><div style="font-family: arial,sans-serif; font-size: 13.33px;">Siobhan</div></font></span></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________
theme-reviewers mailing list
theme-reviewers@lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers</div> </div></body>
</html>