<div dir="ltr">I found some error handling code while browsing around in the plugin, so I assume this might actually be "expected", but I'm not sure if: 1) It's reproducable on other systems/platforms as well, and 2) It is just a bug that could be fixed or actually an intentional step.<div>
<br></div><div>I'm good with any comment, but I had to bring that up if it would affect all reviewers and their access to explicit errors on the frontend.</div></div><div class="gmail_extra"><br clear="all"><div><br>
Mario Peshev<br>
WordPress Engineer, Open Source Consultant<br><a href="http://www.linkedin.com/in/mpeshev" target="_blank">http://www.linkedin.com/in/mpeshev</a><br><div><a href="http://me.peshev.net/" target="_blank">http://me.peshev.net</a></div>
<div><br></div></div>
<br><br><div class="gmail_quote">On Sun, Jun 30, 2013 at 3:09 AM, Philip M. Hofer (Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div dir="ltr">
<div style="font-size:12pt;font-family:'Calibri'">
<div>Can we contact the developer of it and ask him to make a toggle to enable
the suppression on and off?</div>
<div> </div>
<div> </div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal">
<div style="FONT:10pt tahoma">
<div> </div>
<div style="BACKGROUND:#f5f5f5">
<div><b>From:</b> <a title="mario@peshev.net" href="mailto:mario@peshev.net" target="_blank">Mario Peshev</a> </div>
<div><b>Sent:</b> Saturday, June 29, 2013 4:59 PM</div>
<div><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
</div>
<div><b>Subject:</b> Re: [theme-reviewers] Remove Debug Bar from recommended
plugins</div></div></div>
<div> </div></div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"><div><div class="h5">
<div dir="ltr">So, hypothetically, conducting an incompetent theme review due to a
plugin that is supposed to help, but is hiding data that WordPress itself
provides, and potentially letting a theme go in public for all hundreds of
thousands of users who can see the error on their dev installs? <br>
<div class="gmail_extra"> </div>
<div class="gmail_extra">Really?<br clear="all">
<div><br>Mario Peshev</div><br><br>
<div class="gmail_quote">On Sun, Jun 30, 2013 at 2:54 AM, Josh Pollock <span dir="ltr"><<a href="mailto:jpollock412@gmail.com" target="_blank">jpollock412@gmail.com</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">
<div dir="ltr">But setting WP_DEBUG to true on a live server is a terrible idea.
In this scenario, I think you've just done this person a very useful favor by
providing them with an example of one of the many reasons it is such a
terrible idea.
<div> </div>
<div>Also, if you want to be warned about deprecated functions, why not use
the plugin that does that, or make a fork of Debug Bar that will show
those?<br></div></div>
<div>
<div>
<div class="gmail_extra"><br><br>
<div class="gmail_quote">On Sat, Jun 29, 2013 at 7:41 PM, Mario Peshev <span dir="ltr"><<a href="mailto:mario@peshev.net" target="_blank">mario@peshev.net</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">
<div dir="ltr">Imagine the following scenario:
<div><br>You review a theme, it looks okay. You send it to person X who
deploys it on a live server which happens to have WP_DEBUG as true (as all
of the site content is working fine so fine, plugins, content and previous
theme so no issues noticed until now).</div>
<div><br>It would spit all errors on the front screen as the plugin is
hiding them all.</div>
<div> </div>
<div>How would that be useful?</div></div>
<div class="gmail_extra"><span><font color="#888888"><br clear="all">
<div><br>Mario Peshev<br>WordPress Engineer, Open Source Consultant<br><a href="http://www.linkedin.com/in/mpeshev" target="_blank">http://www.linkedin.com/in/mpeshev</a><br>
<div><a href="http://me.peshev.net/" target="_blank">http://me.peshev.net</a></div>
<div> </div></div></font></span>
<div>
<div><br><br>
<div class="gmail_quote">On Sun, Jun 30, 2013 at 2:28 AM, Josh Pollock <span dir="ltr"><<a href="mailto:jpollock412@gmail.com" target="_blank">jpollock412@gmail.com</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">
<div dir="ltr">Isn't that what the log deprecated calls plugin is for?</div>
<div>
<div>
<div class="gmail_extra"><br><br>
<div class="gmail_quote">On Sat, Jun 29, 2013 at 7:24 PM, Mario Peshev <span dir="ltr"><<a href="mailto:mario@peshev.net" target="_blank">mario@peshev.net</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">
<div dir="ltr">Deprecated calls in particular - get_bloginfo with
arguments, or wp_list_cats() - the deprecation notices are not displayed
on my installs with Debug Bar (testing themes coded long ago).
<div class="gmail_extra"><span><font color="#888888"><br clear="all">
<div><br>Mario Peshev<br>
<div> </div></div></font></span>
<div>
<div><br><br>
<div class="gmail_quote">On Sun, Jun 30, 2013 at 2:21 AM, Josh Pollock
<span dir="ltr"><<a href="mailto:jpollock412@gmail.com" target="_blank">jpollock412@gmail.com</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">
<div dir="ltr">Can you elaborate about what notices you think it is
suppressing? I'd be willing to try and recreate this issue if you
could provide more details. Like a lot of people, I have debug bar
activated on all of my development and testing sites.</div>
<div class="gmail_extra"><br><br>
<div class="gmail_quote">
<div>
<div>On Sat, Jun 29, 2013 at 7:11 PM, Mario Peshev <span dir="ltr"><<a href="mailto:mario@peshev.net" target="_blank">mario@peshev.net</a>></span> wrote:<br></div></div>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">
<div>
<div>
<div dir="ltr">Everyone, I'd like to propose a removal of Debug Bar
from the recommended plugins for testing (on pages like <a href="http://make.wordpress.org/themes/about/how-to-join-wptrt/" target="_blank">http://make.wordpress.org/themes/about/how-to-join-wptrt/</a>
or any other pages in Codex related to Theme Review or Theme Unit
Test data).
<div> </div>
<div>I'm usually testing on several different installs and I finally
found out that Debug Bar is hiding some notices on a default install
with a default setup (say, blank WP, WP_DEBUG as true and imported
test data). It seems to have some custom error handling or
something, but I don't see the issues on the frontend when the
plugin is enabled.</div>
<div> </div>
<div>Apologies in advance if I'm missing anything, but from my
perspective it's suppressing actual notices/warnings which is not
healthy for the review process.<span><font color="#888888"><br clear="all">
<div><br>Mario Peshev<br>
<div> </div></div></font></span></div></div>
<div> </div></div></div>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div>
<div> </div></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div>
<div> </div></div></div></div></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div>
<div> </div></div></div></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div>
<div> </div></div></div></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div>
<div> </div></div></div></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div>
<div> </div></div></div>
</div></div><p>
</p><hr><div class="im">
_______________________________________________<br>theme-reviewers mailing
list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div><p></p></div></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>