<HTML><HEAD></HEAD>
<BODY dir=ltr>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: 12pt">
<DIV>Can we contact the developer of it and ask him to make a toggle to enable
the suppression on and off?</DIV>
<DIV> </DIV>
<DIV> </DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV style="FONT: 10pt tahoma">
<DIV> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV style="font-color: black"><B>From:</B> <A title=mario@peshev.net
href="mailto:mario@peshev.net">Mario Peshev</A> </DIV>
<DIV><B>Sent:</B> Saturday, June 29, 2013 4:59 PM</DIV>
<DIV><B>To:</B> <A title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A>
</DIV>
<DIV><B>Subject:</B> Re: [theme-reviewers] Remove Debug Bar from recommended
plugins</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV dir=ltr>So, hypothetically, conducting an incompetent theme review due to a
plugin that is supposed to help, but is hiding data that WordPress itself
provides, and potentially letting a theme go in public for all hundreds of
thousands of users who can see the error on their dev installs? <BR>
<DIV class=gmail_extra> </DIV>
<DIV class=gmail_extra>Really?<BR clear=all>
<DIV><BR>Mario Peshev</DIV><BR><BR>
<DIV class=gmail_quote>On Sun, Jun 30, 2013 at 2:54 AM, Josh Pollock <SPAN
dir=ltr><<A href="mailto:jpollock412@gmail.com"
target=_blank>jpollock412@gmail.com</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>But setting WP_DEBUG to true on a live server is a terrible idea.
In this scenario, I think you've just done this person a very useful favor by
providing them with an example of one of the many reasons it is such a
terrible idea.
<DIV> </DIV>
<DIV>Also, if you want to be warned about deprecated functions, why not use
the plugin that does that, or make a fork of Debug Bar that will show
those?<BR></DIV></DIV>
<DIV class=HOEnZb>
<DIV class=h5>
<DIV class=gmail_extra><BR><BR>
<DIV class=gmail_quote>On Sat, Jun 29, 2013 at 7:41 PM, Mario Peshev <SPAN
dir=ltr><<A href="mailto:mario@peshev.net"
target=_blank>mario@peshev.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>Imagine the following scenario:
<DIV><BR>You review a theme, it looks okay. You send it to person X who
deploys it on a live server which happens to have WP_DEBUG as true (as all
of the site content is working fine so fine, plugins, content and previous
theme so no issues noticed until now).</DIV>
<DIV><BR>It would spit all errors on the front screen as the plugin is
hiding them all.</DIV>
<DIV> </DIV>
<DIV>How would that be useful?</DIV></DIV>
<DIV class=gmail_extra><SPAN><FONT color=#888888><BR clear=all>
<DIV><BR>Mario Peshev<BR>WordPress Engineer, Open Source Consultant<BR><A
href="http://www.linkedin.com/in/mpeshev"
target=_blank>http://www.linkedin.com/in/mpeshev</A><BR>
<DIV><A href="http://me.peshev.net/"
target=_blank>http://me.peshev.net</A></DIV>
<DIV> </DIV></DIV></FONT></SPAN>
<DIV>
<DIV><BR><BR>
<DIV class=gmail_quote>On Sun, Jun 30, 2013 at 2:28 AM, Josh Pollock <SPAN
dir=ltr><<A href="mailto:jpollock412@gmail.com"
target=_blank>jpollock412@gmail.com</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>Isn't that what the log deprecated calls plugin is for?</DIV>
<DIV>
<DIV>
<DIV class=gmail_extra><BR><BR>
<DIV class=gmail_quote>On Sat, Jun 29, 2013 at 7:24 PM, Mario Peshev <SPAN
dir=ltr><<A href="mailto:mario@peshev.net"
target=_blank>mario@peshev.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>Deprecated calls in particular - get_bloginfo with
arguments, or wp_list_cats() - the deprecation notices are not displayed
on my installs with Debug Bar (testing themes coded long ago).
<DIV class=gmail_extra><SPAN><FONT color=#888888><BR clear=all>
<DIV><BR>Mario Peshev<BR>
<DIV> </DIV></DIV></FONT></SPAN>
<DIV>
<DIV><BR><BR>
<DIV class=gmail_quote>On Sun, Jun 30, 2013 at 2:21 AM, Josh Pollock
<SPAN dir=ltr><<A href="mailto:jpollock412@gmail.com"
target=_blank>jpollock412@gmail.com</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>Can you elaborate about what notices you think it is
suppressing? I'd be willing to try and recreate this issue if you
could provide more details. Like a lot of people, I have debug bar
activated on all of my development and testing sites.</DIV>
<DIV class=gmail_extra><BR><BR>
<DIV class=gmail_quote>
<DIV>
<DIV>On Sat, Jun 29, 2013 at 7:11 PM, Mario Peshev <SPAN
dir=ltr><<A href="mailto:mario@peshev.net"
target=_blank>mario@peshev.net</A>></SPAN> wrote:<BR></DIV></DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV>
<DIV>
<DIV dir=ltr>Everyone, I'd like to propose a removal of Debug Bar
from the recommended plugins for testing (on pages like <A
href="http://make.wordpress.org/themes/about/how-to-join-wptrt/"
target=_blank>http://make.wordpress.org/themes/about/how-to-join-wptrt/</A>
or any other pages in Codex related to Theme Review or Theme Unit
Test data).
<DIV> </DIV>
<DIV>I'm usually testing on several different installs and I finally
found out that Debug Bar is hiding some notices on a default install
with a default setup (say, blank WP, WP_DEBUG as true and imported
test data). It seems to have some custom error handling or
something, but I don't see the issues on the frontend when the
plugin is enabled.</DIV>
<DIV> </DIV>
<DIV>Apologies in advance if I'm missing anything, but from my
perspective it's suppressing actual notices/warnings which is not
healthy for the review process.<SPAN><FONT color=#888888><BR
clear=all>
<DIV><BR>Mario Peshev<BR>
<DIV> </DIV></DIV></FONT></SPAN></DIV></DIV>
<DIV> </DIV></DIV></DIV>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV></DIV></DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV></DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV></DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV></DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV></DIV>
<P>
<HR>
_______________________________________________<BR>theme-reviewers mailing
list<BR>theme-reviewers@lists.wordpress.org<BR>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR></DIV></DIV></DIV></BODY></HTML>