<div dir="ltr">I don't know if it's feasible, but the most ideal solution would be for Theme Check to output PHP warnings/errors as well as deprecated notices.</div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Sat, Jun 29, 2013 at 9:35 PM, Josh Pollock <span dir="ltr"><<a href="mailto:jpollock412@gmail.com" target="_blank">jpollock412@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">@Mario-<div><br></div><div>I don't see how this makes for incompetent reviews. Before I start a review I reset the deprecated calls log, when I'm done I check to see if anything showed up. I'm open to finding out what's wrong with that.</div>
<div><br></div><div>@Frumph-</div><div>An option to change this would be nice. I like not seeing the deprecated notices, since in a non-review scenario, I don't want to be constantly reminded that a plugin or some shitty "premium" theme I'm trying to fix for someone is full of deprecated functions.</div>
</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Jun 29, 2013 at 7:59 PM, Mario Peshev <span dir="ltr"><<a href="mailto:mario@peshev.net" target="_blank">mario@peshev.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">So, hypothetically, conducting an incompetent theme review due to a plugin that is supposed to help, but is hiding data that WordPress itself provides, and potentially letting a theme go in public for all hundreds of thousands of users who can see the error on their dev installs? <br>
<div class="gmail_extra"><br></div><div class="gmail_extra">Really?<span><font color="#888888"><br clear="all"><div><br>Mario Peshev</div></font></span><div><div>
<br><br><div class="gmail_quote">On Sun, Jun 30, 2013 at 2:54 AM, Josh Pollock <span dir="ltr"><<a href="mailto:jpollock412@gmail.com" target="_blank">jpollock412@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">But setting WP_DEBUG to true on a live server is a terrible idea. In this scenario, I think you've just done this person a very useful favor by providing them with an example of one of the many reasons it is such a terrible idea. <div>
<br></div><div>Also, if you want to be warned about deprecated functions, why not use the plugin that does that, or make a fork of Debug Bar that will show those?<br></div></div><div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">
On Sat, Jun 29, 2013 at 7:41 PM, Mario Peshev <span dir="ltr"><<a href="mailto:mario@peshev.net" target="_blank">mario@peshev.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Imagine the following scenario:<div><br>You review a theme, it looks okay. You send it to person X who deploys it on a live server which happens to have WP_DEBUG as true (as all of the site content is working fine so fine, plugins, content and previous theme so no issues noticed until now).</div>
<div><br>It would spit all errors on the front screen as the plugin is hiding them all.</div><div><br></div><div>How would that be useful?</div></div><div class="gmail_extra"><span><font color="#888888"><br clear="all">
<div><br>Mario Peshev<br>WordPress Engineer, Open Source Consultant<br>
<a href="http://www.linkedin.com/in/mpeshev" target="_blank">http://www.linkedin.com/in/mpeshev</a><br><div><a href="http://me.peshev.net/" target="_blank">http://me.peshev.net</a></div><div><br></div></div></font></span><div>
<div>
<br><br><div class="gmail_quote">On Sun, Jun 30, 2013 at 2:28 AM, Josh Pollock <span dir="ltr"><<a href="mailto:jpollock412@gmail.com" target="_blank">jpollock412@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Isn't that what the log deprecated calls plugin is for?</div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Jun 29, 2013 at 7:24 PM, Mario Peshev <span dir="ltr"><<a href="mailto:mario@peshev.net" target="_blank">mario@peshev.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Deprecated calls in particular - get_bloginfo with arguments, or wp_list_cats() - the deprecation notices are not displayed on my installs with Debug Bar (testing themes coded long ago). <div class="gmail_extra">
<span><font color="#888888">
<br clear="all"><div><br>Mario Peshev<br><div><br></div></div></font></span><div><div>
<br><br><div class="gmail_quote">On Sun, Jun 30, 2013 at 2:21 AM, Josh Pollock <span dir="ltr"><<a href="mailto:jpollock412@gmail.com" target="_blank">jpollock412@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Can you elaborate about what notices you think it is suppressing? I'd be willing to try and recreate this issue if you could provide more details. Like a lot of people, I have debug bar activated on all of my development and testing sites.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Sat, Jun 29, 2013 at 7:11 PM, Mario Peshev <span dir="ltr"><<a href="mailto:mario@peshev.net" target="_blank">mario@peshev.net</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
<div dir="ltr">Everyone, I'd like to propose a removal of Debug Bar from the recommended plugins for testing (on pages like <a href="http://make.wordpress.org/themes/about/how-to-join-wptrt/" target="_blank">http://make.wordpress.org/themes/about/how-to-join-wptrt/</a> or any other pages in Codex related to Theme Review or Theme Unit Test data).<div>
<br></div><div>I'm usually testing on several different installs and I finally found out that Debug Bar is hiding some notices on a default install with a default setup (say, blank WP, WP_DEBUG as true and imported test data). It seems to have some custom error handling or something, but I don't see the issues on the frontend when the plugin is enabled.</div>
<div><br></div><div>Apologies in advance if I'm missing anything, but from my perspective it's suppressing actual notices/warnings which is not healthy for the review process.<span><font color="#888888"><br clear="all">
<div><br>Mario Peshev<br>
<div><br></div></div>
</font></span></div></div>
<br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>