<div dir="ltr">Its not instructing the user to add analytics code, its making it obvious to them that they can use this option to insert analytics code. By allowing theme options for header and footer scripts that make it clear they can be used for Google Analytics code or other uses, we're giving the end user an option. When they switch themes they can make sure that their new theme has these options, or turn to a plugin. I don't think you can go out on a limb and say that plugin is going to be better coded. Most likely it is if it came from the WordPress.org plugin repo, but it might have come from anywhere. You can't guarantee the quality of every random plugin on the internet.<div>
<br></div><div>I agree a plugin is the better way to do it. But then again, I wouldn't use a plugin, I'd just modify the theme, which I'd obviously version controlled so I wouldn't loose that modification when I updated the theme, but weren't not talking about users like me here. We're making a valid option, less obvious to the end user, and I don't really see how we're protecting them by doing so.</div>
<div><div><div><br></div></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 17, 2013 at 6:27 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">No, I'm saying that a Theme option to allow the user to insert arbitrary scripts or custom CSS is perfectly fine, but that a Theme *instructing* the user to use that option to insert analytics code is not, because it is functionally equivalent to the Theme providing an option intentionally for inserting analytics code.<div>
<br></div><div>We're not making their lives *more* complicated; we've making their lives *less* complicated - because analytics and SEO become a matter of "set and forget", regardless of what Theme is being used. (For the typical user, the question isn't *if* that user will switch Themes in the future, but rather *when* that user will switch Themes.) Further, I'll go out on a limb and say that a Plugin intended specifically for analytics code and/or SEO is going to be *better* coded, and *more* likely to be kept up-to-date, than analogous options in a given Theme.</div>
</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 17, 2013 at 6:11 PM, Josh Pollock <span dir="ltr"><<a href="mailto:jpollock412@gmail.com" target="_blank">jpollock412@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Chip-<div><br></div><div>Am I understanding you correctly that if a theme has an option called "add header script", that is OK, but if it has an option called "add analytics code to header" that is not OK, even though they do the exact same thing? That doesn't make sense.</div>
<div><br></div><div>This requirement is making users add one more plugin to worry about updating, checking for incompatibilities with, etc. We're talking about a class of users that doesn't know to/ isin't comfortable doing something as simple as putting the tracking code in a function hooked to wp_header/footer or just cut and paste it into header.php. These aren't people who can evaluate a plugin to see if it is adding the analytics the right way or not... Why are we making their lives more complicated instead of judging the "add analytics" option the same way as the forbidden "add header script" option, which we allow as long as it is implemented properly?</div>
<span><font color="#888888">
<div><br></div><div>-Josh</div></font></span></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 17, 2013 at 2:09 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I would require the text to be changed, if it says "add your analytics code", since adding analytics code is Plugin territory.</div>
<div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 17, 2013 at 1:53 PM, Srikanth Koneru <span dir="ltr"><<a href="mailto:tskk79@gmail.com" target="_blank">tskk79@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>some are labelled "add your analytics code" and some just "add your header/footer scripts".<br>
</div><div>I approved them without pointing it out as i wasn't sure of the rule.<br>
</div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 17, 2013 at 11:18 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">How do you know that the end user will use them for that?</div><div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Mon, Jun 17, 2013 at 1:36 PM, Srikanth Koneru <span dir="ltr"><<a href="mailto:tskk79@gmail.com" target="_blank">tskk79@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">because they are used to add analytics scripts or similar to header/footer?<br><br></div><div>
<div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 17, 2013 at 11:04 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Why would they?<div><br></div><div>(Not being sarcastic; I'm honestly asking.)</div></div><div>
<div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 17, 2013 at 1:31 PM, Srikanth Koneru <span dir="ltr"><<a href="mailto:tskk79@gmail.com" target="_blank">tskk79@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">do textarea field's meant for header/footer scripts fall under plugin territory?<br></div><div>
<div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 17, 2013 at 10:57 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Themes are always required to conform to the guidelines as current when the Theme is submitted. Guidelines can and do change, and previous reviews can and do miss required criteria. I would note all of the required issues, and hold the ticket open to allow for developer response.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Mon, Jun 17, 2013 at 1:03 PM, devcorn <span dir="ltr"><<a href="mailto:wp@devcorn.com" target="_blank">wp@devcorn.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
<div dir="ltr">hi,<div><br><div class="gmail_quote"><div dir="ltr"><div>I was reviewing one theme and it has so many.. many things which comes under plugin territory shortcodes, SEO, download/upload... etc</div><div><br>
</div>
<div>But the theme was previously approved, actually always approved... so I don't know what should I do with it. I don't want to disappoint the author , I can approve it with note to fix all these stuff in next version, but to my surprise. I downloaded and test old version and they had all of it.. so I don't know if I missed something as I joined WTRT last week only.</div>
<div><br></div><div><br></div><div>Thanks</div><div>Ash</div></div>
<br></div><br></div></div>
<br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>