<HTML><HEAD>
<META content="text/html; charset=ISO-8859-1" http-equiv=Content-Type></HEAD>
<BODY dir=ltr bgColor=#ffffff text=#000000 wsmode="reply">
<DIV dir=ltr>
<DIV style="FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: 12pt">
<DIV>twentytwelve does it in the functions.php with wp_enqueue_script(
'comment-reply' );</DIV>
<DIV> </DIV>
<DIV>must be an earlier theme you’re thinking of, it’s all good, or earlier
version of twentytwelve maybe? they update it still when people put in
reports on it</DIV>
<DIV> </DIV>
<DIV>as otto wrote after my response he writes that if it’s a conditional
situation don’t worry about it, however this is how you do conditionals</DIV>
<DIV> </DIV><FONT face="Times New Roman">wp_enqueue_style(
'twentytwelve-ie', get_template_directory_uri() . '/css/ie.css', array(
'twentytwelve-style' ), '20121010' ); <BR>$wp_styles->add_data(
'twentytwelve-ie', 'conditional', 'lt IE 9' );</FONT><BR>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV style="FONT: 10pt tahoma">
<DIV><FONT size=3 face=Calibri></FONT> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV style="font-color: black"><B>From:</B> <A title=paul@spacecat.com
href="mailto:paul@spacecat.com">Paul Appleyard</A> </DIV>
<DIV><B>Sent:</B> Wednesday, June 12, 2013 10:44 PM</DIV>
<DIV><B>To:</B> <A title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A>
</DIV>
<DIV><B>Subject:</B> Re: [theme-reviewers] html5.js enqueuing</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">I've
run up against reviewers who insist that all scripts and stylesheets MUST be
enqueued with a callback - as indeed the guidelines state. However, the comment
reply JS is enqueued without callback in the header of TwentyTwelve and is
considered the de-facto way to enqueue that.<BR><BR>So, what is the exception?
Is there something in the way that WordPress loads templates and functionality
that obviates the use of one style over the other?<BR><BR>Paul Appleyard<BR><BR>
<DIV class=moz-cite-prefix>On 13/06/2013 1:33 AM, Philip M. Hofer (Frumph)
wrote:<BR></DIV>
<BLOCKQUOTE cite=mid:02370A50EAD044E1A3A9C87B1159E673@furious type="cite">
<DIV dir=ltr>
<DIV style="FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: 12pt"><PRE> echo '<!--[if lt IE 9]>';
echo '<![endif]—>';</PRE><PRE> </PRE>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV style="FONT: 10pt tahoma">
<DIV><FONT size=3 face=Calibri>The above code in your functions.php will not
work right.</FONT></DIV>
<DIV> </DIV>
<DIV><FONT size=3 face=Calibri>There’s no guarantee that the enqueing of this
script will appear in the position between the echo’s. </FONT></DIV>
<DIV> </DIV>
<DIV><FONT size=3 face=Calibri>However, you could do something
like:</FONT></DIV>
<DIV> </DIV><PRE class="default prettyprint prettyprinted"><CODE><SPAN class=kwd><FONT style="FONT-SIZE: 12pt">global</FONT></SPAN><FONT style="FONT-SIZE: 12pt"><SPAN class=pln> $is_IE</SPAN><SPAN class=pun>;</SPAN><SPAN class=pln>
</SPAN><SPAN class=kwd>if</SPAN><SPAN class=pln> </SPAN><SPAN class=pun>(</SPAN><SPAN class=pln> $is_IE </SPAN><SPAN class=pun>)</SPAN><SPAN class=pln> </SPAN><SPAN class=pun>{</SPAN><SPAN class=pln>
wp_enqueue_script('ie7style', get_template_directory_uri() . '/js/html5.js');</SPAN></FONT></CODE></PRE><PRE class="default prettyprint prettyprinted"><CODE><FONT style="FONT-SIZE: 12pt"><SPAN class=pln></SPAN><SPAN class=pln></SPAN></FONT><SPAN class=pun><FONT style="FONT-SIZE: 12pt">}</FONT></SPAN></CODE></PRE>
<DIV><FONT size=3 face=Calibri>which then you wouldn’t need directives, but it
would hit all IE browsers, if that’s fine with you – and this would be the
most appropriate way of handling this situation</FONT></DIV>
<DIV> </DIV>
<DIV> </DIV>
<DIV> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV style="font-color: black"><B>From:</B> <A title=support@d5creation.com
href="mailto:support@d5creation.com" moz-do-not-send="true">D5 Creation
Support</A> </DIV>
<DIV><B>Sent:</B> Wednesday, June 12, 2013 8:21 AM</DIV>
<DIV><B>To:</B> <A title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org"
moz-do-not-send="true">theme-reviewers@lists.wordpress.org</A> </DIV>
<DIV><B>Subject:</B> [theme-reviewers] html5.js enqueuing</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV>Dear Reviewers,</DIV>
<DIV> </DIV>
<DIV>Greetings from D5 Creation!</DIV>
<DIV> </DIV>Please find the following Tickets first:
<DIV><BR><A href="http://themes.trac.wordpress.org/ticket/12433"
moz-do-not-send="true">http://themes.trac.wordpress.org/ticket/12433</A></DIV>
<DIV> </DIV>
<DIV><A href="http://themes.trac.wordpress.org/ticket/10354"
moz-do-not-send="true">http://themes.trac.wordpress.org/ticket/10354</A></DIV>
<DIV> </DIV>
<DIV>One of our Themes named Easy was not approved today. One of the 2
required issues is enqueuing the html5.js from functions.php via callback
function. The reviewer advised to do hard coding the html5.js from header.php
as Twenty Twelve does.</DIV>
<DIV> </DIV>
<DIV>Our another Theme Design was not approved due to hard coding the html5.js
from header.php rather than enqueuing. </DIV>
<DIV> </DIV>
<DIV>Which reviewer is correct? JavaScripts are required to enqueu via
callback function as per the guideline. </DIV>
<DIV> </DIV>
<DIV> </DIV>
<DIV>Thanks</DIV>
<DIV> </DIV>
<DIV>D5 Creation Team </DIV>
<HR>
_______________________________________________<BR>theme-reviewers mailing
list<BR><A class=moz-txt-link-abbreviated
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A><BR><A
class=moz-txt-link-freetext
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR></DIV></DIV></DIV><BR>
<FIELDSET class=mimeAttachmentHeader></FIELDSET> <BR><PRE wrap="">_______________________________________________
theme-reviewers mailing list
<A class=moz-txt-link-abbreviated href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A>
<A class=moz-txt-link-freetext href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A>
</PRE></BLOCKQUOTE><BR>
<P>
<HR>
_______________________________________________<BR>theme-reviewers mailing
list<BR>theme-reviewers@lists.wordpress.org<BR>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR></DIV></DIV></DIV></BODY></HTML>