<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-IN link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'>Hello Chip,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'>There are many themes in the repo that have Google Analytics integration that could be activated from Theme Options. <o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'>Should a theme be rejected because it offers options for Google Analytics and Sharing or social buttons? <o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#404040'><o:p> </o:p></span></p><p class=MsoNormal style='line-height:150%'><span style='font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#404040'>Regards,<o:p></o:p></span></p><p class=MsoNormal style='line-height:150%'><span style='font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#404040'>Harish</span><span style='font-size:10.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#0D0D0D'> <b><o:p></o:p></b></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><b><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif"'>From:</span></b><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif"'> theme-reviewers [mailto:theme-reviewers-bounces@lists.wordpress.org] <b>On Behalf Of </b>Chip Bennett<br><b>Sent:</b> Wed 12 June 13 04:13 AM<br><b>To:</b> [theme-reviewers]<br><b>Subject:</b> Re: [theme-reviewers] Questions on my first review<o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Google Analytics and sharing buttons are Plugin territory.<o:p></o:p></p></div><div><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><div><p class=MsoNormal>On Tue, Jun 11, 2013 at 5:00 PM, Peter Kakoma <<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>> wrote:<o:p></o:p></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><div><p class=MsoNormal>Hi Abhik,<o:p></o:p></p><div><p class=MsoNormal>Thanks for the feedback; point 1 has been duly resolved...another implementation I picked from the framework author. We do agree on point 1. <o:p></o:p></p></div><div><p class=MsoNormal style='margin-bottom:12.0pt'>Point 2 though, as far as I know, isn't grounds to reject a theme. Plugin/non-plugin territory, to the best of my knowledge, has been debated ad nauseam and the jury is still out. <o:p></o:p></p></div></div><div><div><div><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><div><p class=MsoNormal>On Tue, Jun 11, 2013 at 7:31 PM, Abhik Biswas <<a href="mailto:abhik@itsabhik.com" target="_blank">abhik@itsabhik.com</a>> wrote:<o:p></o:p></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><div><div><p class=MsoNormal><span style='font-family:"Verdana","sans-serif"'>Pete,<o:p></o:p></span></p></div><div><p class=MsoNormal style='margin-bottom:12.0pt'><span style='font-family:"Verdana","sans-serif"'>If I were reviewing your theme, I'd have rejected it straight away due to two major issues.<o:p></o:p></span></p></div><div><p class=MsoNormal><span style='font-family:"Verdana","sans-serif"'>1. Images should be resized using 'add_image_size', no external resizer is allowed.<o:p></o:p></span></p></div><div><p class=MsoNormal style='margin-bottom:12.0pt'><span style='font-family:"Verdana","sans-serif"'>2. Those social sharing buttons and Google Analytics integration. In my opinion, they fall under plugin territory.<o:p></o:p></span></p></div><div><p class=MsoNormal><span style='font-family:"Verdana","sans-serif"'>But, it all depends on the reviewer.<o:p></o:p></span></p></div><div><p class=MsoNormal><span style='font-family:"Verdana","sans-serif"'><o:p> </o:p></span></p></div></div><div><div><div><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><div><p class=MsoNormal>On Tue, Jun 11, 2013 at 9:55 AM, Peter Kakoma <<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>> wrote:<o:p></o:p></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><div><p class=MsoNormal>Thanks Springer. I've added to the discussion<o:p></o:p></p></div><div><div><div><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><div><p class=MsoNormal>On Tue, Jun 11, 2013 at 7:11 AM, J.J. Springer <<a href="mailto:jjgspringer@gmail.com" target="_blank">jjgspringer@gmail.com</a>> wrote:<o:p></o:p></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><div><div><p class=MsoNormal style='margin-bottom:12.0pt'>Peter, <br>I have updated your ticket with some other things that I found while I was reviewing the theme. I hope that they are helpful. Your ReadMe does have the proper credits, so thank you for that. :) I just wasn't sure what licenses were allowed.<br><br><o:p></o:p></p></div><div><p class=MsoNormal style='margin-bottom:12.0pt'>Otto, <br>Thanks for the speedy response! No worries about closing the ticket. I'm new to the process so any help is appreciated. <br><br><o:p></o:p></p></div><div><p class=MsoNormal style='margin-bottom:12.0pt'>Amy,<br>Thanks for the detailed answers. I just want to make sure that I do everything right!<br><br><o:p></o:p></p></div><div><p class=MsoNormal style='margin-bottom:12.0pt'>Thanks again everyone for the help! Can't wait for the next one!<o:p></o:p></p></div><div><p class=MsoNormal><span style='color:#888888'>J.J.<o:p></o:p></span></p></div></div><div><div><div><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><div><p class=MsoNormal>On Mon, Jun 10, 2013 at 8:42 PM, Peter Kakoma <<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>> wrote:<o:p></o:p></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><div><p class=MsoNormal>Hi Otto,<o:p></o:p></p><div><p class=MsoNormal>The theme in question is mine; only issue it turns out after re-reading all the tips here is the base_64 encoding. I customized a very popular and very user-friendly framework -the Slightly Modified Options Framework. Very big themes use it.<br>That l<span style='font-size:10.5pt;font-family:"Arial","sans-serif";color:#444444'>ine, "100% safe - ignore theme check nag", which I know got you :-) was added by the Framework author. I took his word for it...seeing as the framework is used everywhere. I figured several themes in the repository already use it. I'm very aware of the base64 encoding rule; <br><br>I've removed the option altogether; the encoding was being used to allow users import/export/transfer their settings. Will find another way of doing it...and will make changes to the framework repository so hopefully, the author can clean that up.</span><o:p></o:p></p></div><div><p class=MsoNormal><span style='font-size:10.5pt;font-family:"Arial","sans-serif";color:#444444'>I've re-uploaded the theme: </span><a href="http://themes.trac.wordpress.org/ticket/12964" target="_blank">http://themes.trac.wordpress.org/ticket/12964</a>. <o:p></o:p></p></div><div><p class=MsoNormal>Springer, if you can, please take a look at it again. (Seeing as you've already downloaded it and started the review :-) )<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>The credit link leads to my page: http:<a href="http://kakoma.ug" target="_blank">kakoma.ug</a>, which I'm upgrading right now. I can put something else if the current 'under construction' page is an issue<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Oh, and the 'read me', as Springer can attest, contains proper credits<o:p></o:p></p></div></div><div><div><div><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><div><p class=MsoNormal>On Tue, Jun 11, 2013 at 5:27 AM, Otto <<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>> wrote:<o:p></o:p></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><div><p class=MsoNormal>On Mon, Jun 10, 2013 at 8:54 PM, J.J. Springer <<a href="mailto:jjgspringer@gmail.com" target="_blank">jjgspringer@gmail.com</a>> wrote:<o:p></o:p></p></div><div><p class=MsoNormal style='margin-bottom:12.0pt'>> 2. If I get any error of any sort, I assume that means that the theme is<br>> automatically rejected. As soon as I run into an error, do I stop and mark<br>> it rejected or keep going and try to find as many errors as possible? Is<br>> there a point at which I should just stop and send it back?<o:p></o:p></p></div><p class=MsoNormal>This is up to you. Additionally, I apologize for usurping your review<br>and failing the theme, but that kind of ticked me off a bit.<br><br>If you wish to do a full review and give the theme author more tips<br>and things that he needs to check on, that's perfectly acceptable.<o:p></o:p></p><div><p class=MsoNormal style='margin-bottom:12.0pt'><br>> 3. The theme that I'm reviewing is a child theme of twentytwelve and<br>> therefore doesn't have the "required" theme template files (missing<br>> comments.php). Are child themes allowed? Is there some special way that I'm<br>> supposed to be reviewing them?<o:p></o:p></p></div><p class=MsoNormal>Child themes won't pass theme check, obviously, because of missing<br>files and such. The review guidelines still stand though, and the<br>child+parent must pass, as a whole, sort of thing. The parent is<br>presumed to already have passed, since it's in the directory anyway.<o:p></o:p></p><div><p class=MsoNormal style='margin-bottom:12.0pt'><br><br>> 4. The person that I'm reviewing used a lot framework stuff that's MIT or<br>> WTFPL licensed. Is that ok?<o:p></o:p></p></div><p class=MsoNormal>Both of those are GPL-Compat, so they're fine.<br><span style='color:#888888'><br><br>-Otto</span><o:p></o:p></p><div><div><p class=MsoNormal>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><o:p></o:p></p></div></div></blockquote></div><p class=MsoNormal><br><br clear=all><o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div></div></div><p class=MsoNormal><span style='color:#888888'>-- <br><a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a></span><o:p></o:p></p></div><p class=MsoNormal style='margin-bottom:12.0pt'><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><o:p></o:p></p></blockquote></div><p class=MsoNormal><o:p> </o:p></p></div></div></div><p class=MsoNormal style='margin-bottom:12.0pt'><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><o:p></o:p></p></blockquote></div><p class=MsoNormal><br><br clear=all><o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><p class=MsoNormal>-- <br><a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a><o:p></o:p></p></div></div></div><p class=MsoNormal style='margin-bottom:12.0pt'><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><o:p></o:p></p></blockquote></div><p class=MsoNormal><o:p> </o:p></p></div></div></div><p class=MsoNormal style='margin-bottom:12.0pt'><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><o:p></o:p></p></blockquote></div><p class=MsoNormal><br><br clear=all><o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><p class=MsoNormal>-- <br><a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a><o:p></o:p></p></div></div></div><p class=MsoNormal style='margin-bottom:12.0pt'><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><o:p></o:p></p></blockquote></div><p class=MsoNormal><o:p> </o:p></p></div></div></body></html>