<div dir="ltr">Agree with Emil, social share data is stored by social networks and can be accessed by any theme or plugin(i.e. no vendor lock), so if social share buttons are turned off by default then they should not be a problem( even if they are turned on by default, a switch to turn them off should be enough).<br>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 9:48 AM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Personally I don't have problems with or without GA being turned off or on<div>by default. Meaning that user would need to add UA, or the entire</div><div>JS in the Theme Options.</div><div>
<br></div><div>However for the user's sake I believe that we the authors should turn this off</div><div>by default and let user's make the choice whether they're going to utilize</div><div>the feature or forget it and go with the plugin instead.</div>
<div><br></div><div>Same goes for Webmaster's, Social Media etc.</div><div><br></div><div>All three <i>should</i> be treated as the <a href="http://codex.wordpress.org/Theme_Review#Presentation_vs_Functionality" target="_blank">Favicon</a> from the guidelines:</div>
<div><br></div><div><b>Favicons </b></div><div><ul><li>Themes are recommended not to implement custom favicon functionality. <br></li><li>If implemented, favicon functionality is required to be opt-in, and disabled by default. <br>
</li><li>If implemented, favicon functionality is required to support user-defined favicon images<br></li></ul></div><div>N.B.<i> I am just discussing, this is not the final decision, or something we the admins</i></div>
<div><i> should decide alone. As Otto says "consensus"</i></div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 11, 2013 at 11:05 PM, Abhik Biswas <span dir="ltr"><<a href="mailto:abhik@itsabhik.com" target="_blank">abhik@itsabhik.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif"><div class="gmail_quote"><div>
On Wed, Jun 12, 2013 at 5:37 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I agree with Otto's longer-winded answer, with the caveat: <b>"sharing" buttons are not equivalent to social network profile links.</b></div>
</blockquote><div><br></div></div><div>That's exactly my point.<br></div><div>I guess we need a clear mention of what's accepted and what's not with examples in Theme Review Guidelines.<br><br></div><div>@Emil,<br>
</div><div>I once told that "Every thing that shouldn't get removed on changing a theme is plugin territory". Of course social sharing buttons and analytics integration falls under that. Why? for example, we may loose all the sharing count on changing the theme as not all the themes handles the code same way and what if the user forget to implement analytics code in the new theme (or even worse, the new theme doesn't support automatic integration of analytics code) after changing the *analytic supported* theme?<br>
<br></div><div>For the existing theme in repo with this options enabled, we can tell the authors to remove them once they submit an update.<br><br></div><div>Just my 2 cents.<br></div></div></div></div><div>
<div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 9:08 AM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Sayontan,<br><div><br></div><div>I really don't know why this was not approved and if this was me</div><div>personally, Theme would not fail because of that.</div><div><br></div><div>
And to be honest (well why shouldn't I be) I asked pretty much the</div><div>same question just before my Ex-Theme was submitted to the repository</div><div>where this was clarified as OK. What changed in the mean time? Don't</div>
<div>really know.</div><div><br></div><div>We should indeed "judge" all Theme the same way :)</div><span><font color="#888888"><div><br>
</div><div>Emil</div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div></font></span></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 11, 2013 at 10:25 PM, Sayontan Sinha <span dir="ltr"><<a href="mailto:sayontan@gmail.com" target="_blank">sayontan@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Emil,<div>Have you looked at the theme in question? Judging from your example I guess you haven't, so please take a look: <a href="http://themes.svn.wordpress.org/jaguza/1.0.2/functions.php" target="_blank">http://themes.svn.wordpress.org/jaguza/1.0.2/functions.php</a>. How is this materially different from what Responsive does? The way I (and any sensible person) would see the analytics feature here is that it is, to quote you, "empty, turned off by default". So why would this be "not-approved"? Bear in mind that this discussion is about the provision to insert analytics through a theme - not about someone's dodgy insertion of a tracking script. If all provisions to insert analytics fall under plugin territory, then every theme that has such a feature should be forced to remove it during the next update. That includes your (ex-)theme Responsive, it includes my theme, and I am pretty sure it includes at least 100 other themes in the repository. I don't see any wiggle room for an exception here.</div>
<div><br></div><div>My main intent was to drive towards some clarity around feeble guidelines such as "plugin territory" that are applied inconsistently across themes. I see no reason why one theme should be allowed to keep a feature just because people have been using it and/or it is turned off by default, while another theme doesn't get to keep it though it too has a similar feature turned off by default. Maybe the review team should stop pushing too hard on such cases. Or maybe it should judge all themes with the same yardstick.<span><font color="#888888"><br>
</font></span></div><span><font color="#888888"><div><br></div><div>Sayontan.</div><div><br></div><div><br></div><div><br></div></font></span></div><div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Tue, Jun 11, 2013 at 7:28 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Having something like this in footer.php or header.php is not right</div><div><br></div><div><pre style="margin-top:0px;margin-bottom:0px;padding:0px;border:0px;font-size:12px;font-family:Consolas,'Liberation Mono',Courier,monospace;color:rgb(51,51,51);line-height:18px">
<div style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span style="margin:0px;padding:0px;border:0px;color:rgb(0,0,128)"><script></span></div><div style="margin:0px;padding:0px 0px 0px 10px;border:0px">
<span style="margin:0px;padding:0px;border:0px">(</span><span style="margin:0px;padding:0px;border:0px;font-weight:bold">function</span><span style="margin:0px;padding:0px;border:0px">(</span><span style="margin:0px;padding:0px;border:0px">b</span><span style="margin:0px;padding:0px;border:0px">,</span><span style="margin:0px;padding:0px;border:0px">o</span><span style="margin:0px;padding:0px;border:0px">,</span><span style="margin:0px;padding:0px;border:0px">i</span><span style="margin:0px;padding:0px;border:0px">,</span><span style="margin:0px;padding:0px;border:0px">l</span><span style="margin:0px;padding:0px;border:0px">,</span><span style="margin:0px;padding:0px;border:0px">e</span><span style="margin:0px;padding:0px;border:0px">,</span><span style="margin:0px;padding:0px;border:0px">r</span><span style="margin:0px;padding:0px;border:0px">){</span><span style="margin:0px;padding:0px;border:0px">b</span><span style="margin:0px;padding:0px;border:0px">.</span><span style="margin:0px;padding:0px;border:0px">GoogleAnalyticsObject</span><span style="margin:0px;padding:0px;border:0px;font-weight:bold">=</span><span style="margin:0px;padding:0px;border:0px">l</span><span style="margin:0px;padding:0px;border:0px">;</span><span style="margin:0px;padding:0px;border:0px">b</span><span style="margin:0px;padding:0px;border:0px">[</span><span style="margin:0px;padding:0px;border:0px">l</span><span style="margin:0px;padding:0px;border:0px">]</span><span style="margin:0px;padding:0px;border:0px;font-weight:bold">||</span><span style="margin:0px;padding:0px;border:0px">(</span><span style="margin:0px;padding:0px;border:0px">b</span><span style="margin:0px;padding:0px;border:0px">[</span><span style="margin:0px;padding:0px;border:0px">l</span><span style="margin:0px;padding:0px;border:0px">]</span><span style="margin:0px;padding:0px;border:0px;font-weight:bold">=</span></div>
<div style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span style="margin:0px;padding:0px;border:0px;font-weight:bold">function</span><span style="margin:0px;padding:0px;border:0px">(){(</span><span style="margin:0px;padding:0px;border:0px">b</span><span style="margin:0px;padding:0px;border:0px">[</span><span style="margin:0px;padding:0px;border:0px">l</span><span style="margin:0px;padding:0px;border:0px">].</span><span style="margin:0px;padding:0px;border:0px">q</span><span style="margin:0px;padding:0px;border:0px;font-weight:bold">=</span><span style="margin:0px;padding:0px;border:0px">b</span><span style="margin:0px;padding:0px;border:0px">[</span><span style="margin:0px;padding:0px;border:0px">l</span><span style="margin:0px;padding:0px;border:0px">].</span><span style="margin:0px;padding:0px;border:0px">q</span><span style="margin:0px;padding:0px;border:0px;font-weight:bold">||</span><span style="margin:0px;padding:0px;border:0px">[]).</span><span style="margin:0px;padding:0px;border:0px">push</span><span style="margin:0px;padding:0px;border:0px">(</span><span style="margin:0px;padding:0px;border:0px">arguments</span><span style="margin:0px;padding:0px;border:0px">)});</span><span style="margin:0px;padding:0px;border:0px">b</span><span style="margin:0px;padding:0px;border:0px">[</span><span style="margin:0px;padding:0px;border:0px">l</span><span style="margin:0px;padding:0px;border:0px">].</span><span style="margin:0px;padding:0px;border:0px">l</span><span style="margin:0px;padding:0px;border:0px;font-weight:bold">=+</span><span style="margin:0px;padding:0px;border:0px;font-weight:bold">new</span> <span style="margin:0px;padding:0px;border:0px;color:rgb(0,134,179)">Date</span><span style="margin:0px;padding:0px;border:0px">;</span></div>
<div style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span style="margin:0px;padding:0px;border:0px">e</span><span style="margin:0px;padding:0px;border:0px;font-weight:bold">=</span><span style="margin:0px;padding:0px;border:0px">o</span><span style="margin:0px;padding:0px;border:0px">.</span><span style="margin:0px;padding:0px;border:0px">createElement</span><span style="margin:0px;padding:0px;border:0px">(</span><span style="margin:0px;padding:0px;border:0px">i</span><span style="margin:0px;padding:0px;border:0px">);</span><span style="margin:0px;padding:0px;border:0px">r</span><span style="margin:0px;padding:0px;border:0px;font-weight:bold">=</span><span style="margin:0px;padding:0px;border:0px">o</span><span style="margin:0px;padding:0px;border:0px">.</span><span style="margin:0px;padding:0px;border:0px">getElementsByTagName</span><span style="margin:0px;padding:0px;border:0px">(</span><span style="margin:0px;padding:0px;border:0px">i</span><span style="margin:0px;padding:0px;border:0px">)[</span><span style="margin:0px;padding:0px;border:0px;color:rgb(0,153,153)">0</span><span style="margin:0px;padding:0px;border:0px">];</span></div>
<div style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span style="margin:0px;padding:0px;border:0px">e</span><span style="margin:0px;padding:0px;border:0px">.</span><span style="margin:0px;padding:0px;border:0px">src</span><span style="margin:0px;padding:0px;border:0px;font-weight:bold">=</span><span style="margin:0px;padding:0px;border:0px;color:rgb(221,17,68)">'//<a href="http://www.google-analytics.com/analytics.js" target="_blank">www.google-analytics.com/analytics.js</a>'</span><span style="margin:0px;padding:0px;border:0px">;</span></div>
<div style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span style="margin:0px;padding:0px;border:0px">r</span><span style="margin:0px;padding:0px;border:0px">.</span><span style="margin:0px;padding:0px;border:0px">parentNode</span><span style="margin:0px;padding:0px;border:0px">.</span><span style="margin:0px;padding:0px;border:0px">insertBefore</span><span style="margin:0px;padding:0px;border:0px">(</span><span style="margin:0px;padding:0px;border:0px">e</span><span style="margin:0px;padding:0px;border:0px">,</span><span style="margin:0px;padding:0px;border:0px">r</span><span style="margin:0px;padding:0px;border:0px">)}(</span><span style="margin:0px;padding:0px;border:0px;color:rgb(0,134,179)">window</span><span style="margin:0px;padding:0px;border:0px">,</span><span style="margin:0px;padding:0px;border:0px;color:rgb(0,134,179)">document</span><span style="margin:0px;padding:0px;border:0px">,</span><span style="margin:0px;padding:0px;border:0px;color:rgb(221,17,68)">'script'</span><span style="margin:0px;padding:0px;border:0px">,</span><span style="margin:0px;padding:0px;border:0px;color:rgb(221,17,68)">'ga'</span><span style="margin:0px;padding:0px;border:0px">));</span></div>
<div style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span style="margin:0px;padding:0px;border:0px">ga</span><span style="margin:0px;padding:0px;border:0px">(</span><span style="margin:0px;padding:0px;border:0px;color:rgb(221,17,68)">'create'</span><span style="margin:0px;padding:0px;border:0px">,</span><span style="margin:0px;padding:0px;border:0px;color:rgb(221,17,68)">'UA-XXXXX-X'</span><span style="margin:0px;padding:0px;border:0px">);</span><span style="margin:0px;padding:0px;border:0px">ga</span><span style="margin:0px;padding:0px;border:0px">(</span><span style="margin:0px;padding:0px;border:0px;color:rgb(221,17,68)">'send'</span><span style="margin:0px;padding:0px;border:0px">,</span><span style="margin:0px;padding:0px;border:0px;color:rgb(221,17,68)">'pageview'</span><span style="margin:0px;padding:0px;border:0px">);</span></div>
<div style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span style="margin:0px;padding:0px;border:0px;color:rgb(0,0,128)"></script></span></div></pre></div><div><br></div>Having this:<div>
<br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div>Wait! There's nothing above? Precisely!</div></div><div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">
On Tue, Jun 11, 2013 at 7:21 PM, Daniel <span dir="ltr"><<a href="mailto:danielx386@gmail.com" target="_blank">danielx386@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Not to be rude about it, but I would like to quote Otto again:<div><br><br><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">But Google Analytics, not so much. Realistically, the only thing you<br>
need to do for GA is to put some code in the footer, and there's<br>dozens of plugins to do that right. I can't think of any realistic<br>integration for a theme that would make sense. GA doesn't display<br>anything at all, it records visits, basically. Not relevant to the<br>
theme.<br><br>The way I see it, anything that is in the theme should somehow relate<br>to the *display* of the webpage. That's sort of the whole point of the<br>theme. If the code doesn't affect the *look* of the page in some way,<br>
then it shouldn't be in the theme<br></blockquote><br></div>Or he wrong?<div><div><br> <br><br><br><br>On Wed, Jun 12, 2013 at 10:18 AM, Emil Uzelac <<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>> wrote:<br>
> @Sayontan what makes you say that? <br>
><br>> Google verification, GA, Social Icons are empty fields, turned off<br>> by default, why would this be not-approved?<br>><br>><br>> On Tue, Jun 11, 2013 at 6:55 PM, Sayontan Sinha <<a href="mailto:sayontan@gmail.com" target="_blank">sayontan@gmail.com</a>> wrote:<br>
>>><br>>>> Plugin territory is a not-approve condition.<br>>><br>>><br>>> So "Responsive" should get its Google verification, Google Analytics etc.<br>>> removed, then, when there is an update? See<br>
>> <a href="http://themes.svn.wordpress.org/responsive/1.9.3.1/includes/theme-options.php" target="_blank">http://themes.svn.wordpress.org/responsive/1.9.3.1/includes/theme-options.php</a>. <br>>><br>>><br>
>> On Tue, Jun 11, 2013 at 6:22 PM, Chip Bennett <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>><br>
>> wrote:<br>>>><br>>>> Plugin territory is a not-approve condition.<br>>>><br>>>><br>>>> On Tue, Jun 11, 2013 at 6:45 PM, Harish <<a href="mailto:me@harishchouhan.com" target="_blank">me@harishchouhan.com</a>> wrote:<br>
>>>><br>>>>> Hello Chip,<br>>>>><br>>>>> <br>>>>><br>>>>> There are many themes in the repo that have Google Analytics integration<br>>>>> that could be activated from Theme Options.<br>
>>>><br>>>>> <br>>>>><br>>>>> Should a theme be rejected because it offers options for Google<br>>>>> Analytics and Sharing or social buttons?<br>>>>><br>
>>>> <br>>>>><br>>>>> <br>>>>><br>>>>> Regards,<br>>>>><br>>>>> Harish<br>>>>><br>>>>> <br>>>>><br>
>>>> From: theme-reviewers<br>>>>> [mailto:<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>] On Behalf Of Chip<br>>>>> Bennett<br>
>>>> Sent: Wed 12 June 13 04:13 AM<br>>>>> To: [theme-reviewers]<br>>>>> Subject: Re: [theme-reviewers] Questions on my first review<br>>>>><br>>>>> <br>>>>><br>
>>>> Google Analytics and sharing buttons are Plugin territory.<br>>>>><br>>>>> <br>>>>><br>>>>> On Tue, Jun 11, 2013 at 5:00 PM, Peter Kakoma <<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>> wrote:<br>
>>>><br>>>>> Hi Abhik,<br>>>>><br>>>>> Thanks for the feedback; point 1 has been duly resolved...another<br>>>>> implementation I picked from the framework author. We do agree on point 1. <br>
>>>><br>>>>> Point 2 though, as far as I know, isn't grounds to reject a theme.<br>>>>> Plugin/non-plugin territory, to the best of my knowledge, has been debated<br>>>>> ad nauseam and the jury is still out. <br>
>>>><br>>>>> <br>>>>><br>>>>> On Tue, Jun 11, 2013 at 7:31 PM, Abhik Biswas <<a href="mailto:abhik@itsabhik.com" target="_blank">abhik@itsabhik.com</a>><br>>>>> wrote:<br>
>>>><br>>>>> Pete,<br>>>>><br>>>>> If I were reviewing your theme, I'd have rejected it straight away due<br>>>>> to two major issues.<br>>>>><br>
>>>> 1. Images should be resized using 'add_image_size', no external resizer<br>>>>> is allowed.<br>>>>><br>>>>> 2. Those social sharing buttons and Google Analytics integration. In my<br>
>>>> opinion, they fall under plugin territory.<br>>>>><br>>>>> But, it all depends on the reviewer.<br>>>>><br>>>>> <br>>>>><br>>>>> <br>
>>>><br>>>>> On Tue, Jun 11, 2013 at 9:55 AM, Peter Kakoma <<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>> wrote:<br>>>>><br>>>>> Thanks Springer. I've added to the discussion<br>
>>>><br>>>>> <br>>>>><br>>>>> On Tue, Jun 11, 2013 at 7:11 AM, J.J. Springer <<a href="mailto:jjgspringer@gmail.com" target="_blank">jjgspringer@gmail.com</a>><br>>>>> wrote:<br>
>>>><br>>>>> Peter,<br>>>>> I have updated your ticket with some other things that I found while I<br>>>>> was reviewing the theme. I hope that they are helpful. Your ReadMe does have<br>
>>>> the proper credits, so thank you for that. :) I just wasn't sure what<br>>>>> licenses were allowed.<br>>>>><br>>>>> Otto,<br>>>>> Thanks for the speedy response! No worries about closing the ticket. I'm<br>
>>>> new to the process so any help is appreciated.<br>>>>><br>>>>> Amy,<br>>>>> Thanks for the detailed answers. I just want to make sure that I do<br>>>>> everything right!<br>
>>>><br>>>>> Thanks again everyone for the help! Can't wait for the next one!<br>>>>><br>>>>> J.J.<br>>>>><br>>>>> <br>>>>><br>>>>> On Mon, Jun 10, 2013 at 8:42 PM, Peter Kakoma <<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>> wrote:<br>
>>>><br>>>>> Hi Otto,<br>>>>><br>>>>> The theme in question is mine; only issue it turns out after re-reading<br>>>>> all the tips here is the base_64 encoding. I customized a very popular and<br>
>>>> very user-friendly framework -the Slightly Modified Options Framework. Very<br>>>>> big themes use it.<br>>>>> That line, "100% safe - ignore theme check nag", which I know got you<br>
>>>> :-) was added by the Framework author. I took his word for it...seeing as<br>>>>> the framework is used everywhere. I figured several themes in the repository<br>>>>> already use it. I'm very aware of the base64 encoding rule; <br>
>>>><br>>>>> I've removed the option altogether; the encoding was being used to allow<br>>>>> users import/export/transfer their settings. Will find another way of doing<br>>>>> it...and will make changes to the framework repository so hopefully, the<br>
>>>> author can clean that up.<br>>>>><br>>>>> I've re-uploaded the theme:<br>>>>> <a href="http://themes.trac.wordpress.org/ticket/12964" target="_blank">http://themes.trac.wordpress.org/ticket/12964</a>. <br>
>>>><br>>>>> Springer, if you can, please take a look at it again. (Seeing as you've<br>>>>> already downloaded it and started the review :-) )<br>>>>><br>>>>> <br>
>>>><br>>>>> The credit link leads to my page: http:<a href="http://kakoma.ug" target="_blank">kakoma.ug</a>, which I'm upgrading<br>>>>> right now. I can put something else if the current 'under construction' page<br>
>>>> is an issue<br>>>>><br>>>>> <br>>>>><br>>>>> Oh, and the 'read me', as Springer can attest, contains proper credits<br>>>>><br>>>>> <br>
>>>><br>>>>> On Tue, Jun 11, 2013 at 5:27 AM, Otto <<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>> wrote:<br>>>>><br>>>>> On Mon, Jun 10, 2013 at 8:54 PM, J.J. Springer <<a href="mailto:jjgspringer@gmail.com" target="_blank">jjgspringer@gmail.com</a>><br>
>>>> wrote:<br>>>>><br>>>>> > 2. If I get any error of any sort, I assume that means that the theme<br>>>>> > is<br>>>>> > automatically rejected. As soon as I run into an error, do I stop and<br>
>>>> > mark<br>>>>> > it rejected or keep going and try to find as many errors as possible?<br>>>>> > Is<br>>>>> > there a point at which I should just stop and send it back?<br>
>>>><br>>>>> This is up to you. Additionally, I apologize for usurping your review<br>>>>> and failing the theme, but that kind of ticked me off a bit.<br>>>>><br>>>>> If you wish to do a full review and give the theme author more tips<br>
>>>> and things that he needs to check on, that's perfectly acceptable.<br>>>>><br>>>>><br>>>>> > 3. The theme that I'm reviewing is a child theme of twentytwelve and<br>
>>>> > therefore doesn't have the "required" theme template files (missing<br>>>>> > comments.php). Are child themes allowed? Is there some special way<br>>>>> > that I'm<br>
>>>> > supposed to be reviewing them?<br>>>>><br>>>>> Child themes won't pass theme check, obviously, because of missing<br>>>>> files and such. The review guidelines still stand though, and the<br>
>>>> child+parent must pass, as a whole, sort of thing. The parent is<br>>>>> presumed to already have passed, since it's in the directory anyway.<br>>>>><br>>>>><br>>>>><br>
>>>> > 4. The person that I'm reviewing used a lot framework stuff that's MIT<br>>>>> > or<br>>>>> > WTFPL licensed. Is that ok?<br>>>>><br>>>>> Both of those are GPL-Compat, so they're fine.<br>
>>>><br>>>>><br>>>>> -Otto<br>>>>><br>>>>> _______________________________________________<br>>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>><br>>>>><br>>>>><br>
>>>> <br>
>>>><br>>>>> --<br>>>>> <a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a><br>>>>><br>>>>><br>>>>> _______________________________________________<br>
>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>><br>>>>> <br>>>>><br>>>>><br>>>>> _______________________________________________<br>>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>><br>>>>><br>>>>><br>
>>>> <br>
>>>><br>>>>> --<br>>>>> <a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a><br>>>>><br>>>>><br>>>>> _______________________________________________<br>
>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>><br>>>>> <br>>>>><br>>>>><br>>>>> _______________________________________________<br>>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>><br>>>>><br>>>>><br>
>>>> <br>
>>>><br>>>>> --<br>>>>> <a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a><br>>>>><br>>>>><br>>>>> _______________________________________________<br>
>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>><br>>>>> <br>>>>><br>>>>><br>>>>> _______________________________________________<br>>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>><br>>>><br>>>><br>
>>> _______________________________________________<br>
>>> theme-reviewers mailing list<br>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>><br>>><br>>><br>>><br>>> --<br>>> Sayontan Sinha<br>>> <a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
>> --<br>>><br>>><br>>> _______________________________________________<br>>> theme-reviewers mailing list<br>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>><br>><br>><br>> _______________________________________________<br>
> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
--<br><br>
</div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>