<div dir="ltr">For future reference: please post ticket-specific questions and discussion *in-ticket* first. You only need to raise ticket-specific issues to the mail-list if you are unable to resolve those issues in-ticket.<div>
<br></div><div style>Also: reviewers, please show a willingness to discuss (and clarify/explain) any review comments in-ticket. If a developer asks for clarification, or how to conform to a given Guideline, please provide assistance (at least to the best of your ability) in-ticket. </div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 11:43 AM, D5 Creation Support <span dir="ltr"><<a href="mailto:support@d5creation.com" target="_blank">support@d5creation.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thank you very much for this correction. <div class="HOEnZb"><div class="h5"><br><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 9:33 PM, Philip M. Hofer (Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div dir="ltr">
<div style="font-size:12pt;font-family:'Calibri'"><pre> echo '<!--[if lt IE 9]>';
echo '<![endif]—>';</pre><pre> </pre>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal">
<div style="FONT:10pt tahoma">
<div><font size="3" face="Calibri">The above code in your functions.php will not
work right.</font></div>
<div><font size="3" face="Calibri"></font> </div>
<div><font size="3" face="Calibri">There’s no guarantee that the enqueing of this
script will appear in the position between the echo’s. </font></div>
<div><font size="3" face="Calibri"></font> </div>
<div><font size="3" face="Calibri">However, you could do something
like:</font></div>
<div><font size="3" face="Calibri"></font> </div><pre><code><span><font style="FONT-SIZE:12pt">global</font></span><font style="FONT-SIZE:12pt"><span> $is_IE</span><span>;</span><span>
</span><span>if</span><span> </span><span>(</span><span> $is_IE </span><span>)</span><span> </span><span>{</span><span>
wp_enqueue_script('ie7style', get_template_directory_uri() . '/js/html5.js');</span></font></code></pre><pre><code><font style="FONT-SIZE:12pt"><span></span><span></span></font><span><font style="FONT-SIZE:12pt">}</font></span></code></pre>
<div><font size="3" face="Calibri">which then you wouldn’t need directives, but it
would hit all IE browsers, if that’s fine with you – and this would be the most
appropriate way of handling this situation</font></div>
<div><font size="3" face="Calibri"></font> </div>
<div><font size="3" face="Calibri"></font> </div>
<div><font size="3" face="Calibri"></font> </div>
<div style="BACKGROUND:#f5f5f5">
<div><b>From:</b> <a title="support@d5creation.com" href="mailto:support@d5creation.com" target="_blank">D5 Creation Support</a> </div>
<div><b>Sent:</b> Wednesday, June 12, 2013 8:21 AM</div>
<div><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
</div>
<div><b>Subject:</b> [theme-reviewers] html5.js enqueuing</div></div></div>
<div> </div></div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"><div><div>
<div>Dear Reviewers,</div>
<div> </div>
<div>Greetings from D5 Creation!</div>
<div> </div>Please find the following Tickets first:
<div><br><a href="http://themes.trac.wordpress.org/ticket/12433" target="_blank">http://themes.trac.wordpress.org/ticket/12433</a></div>
<div> </div>
<div><a href="http://themes.trac.wordpress.org/ticket/10354" target="_blank">http://themes.trac.wordpress.org/ticket/10354</a></div>
<div> </div>
<div>One of our Themes named Easy was not approved today. One of the 2 required
issues is enqueuing the html5.js from functions.php via callback function. The
reviewer advised to do hard coding the html5.js from header.php as Twenty Twelve
does.</div>
<div> </div>
<div>Our another Theme Design was not approved due to hard coding the html5.js
from header.php rather than enqueuing. </div>
<div> </div>
<div>Which reviewer is correct? JavaScripts are required to enqueu via callback
function as per the guideline. </div>
<div> </div>
<div> </div>
<div>Thanks</div>
<div> </div>
<div>D5 Creation Team </div>
</div></div><p>
</p><hr>
_______________________________________________<br>theme-reviewers mailing
list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<p></p></div></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><img height="50" width="200"><div><b><font color="#ff6600" size="4"><br>
</font></b></div><div><b><font color="#ff6600" face="verdana, sans-serif" size="4">D5 Creation Support Team</font></b><br><div><br></div><div><b style="font-family:verdana,sans-serif">D5 Creation is a ICT Consulting Network which is operated, managed and served by some change seeking young people of the disadvantaged part of the society to make the ICT accessible to all and remove the digital divide with their best possible efforts.</b><br>
<br><div><span style="line-height:20px;text-align:justify;color:rgb(51,51,51);font-family:Verdana,Arial,Helvetica,sans-serif">You can contact with the D5 Creation Team for any kind of information of D5 Creation. Only the Paid Members can get technical support using our Support Ticket System. Others may use our <a href="http://d5creation.com/contact/contactus/" target="_blank">Dynamic Contact System</a>.</span></div>
</div></div>
</font></span><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>