<div dir="ltr">"Presentational" means "presentation of user-generated content".<div><br></div><div style>The best approach is to integrate *support* for Plugins that would provide content-sharing buttons, facebook like buttons, twitter intent links, etc.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 2:54 PM, Srikanth Koneru <span dir="ltr"><<a href="mailto:tskk79@gmail.com" target="_blank">tskk79@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><br>Social buttons as in the buttons provided by twitter/facebook/SU etc...<br><a href="https://twitter.com/about/resources/buttons" target="_blank">https://twitter.com/about/resources/buttons</a><br>
<a href="http://developers.facebook.com/docs/reference/plugins/like-box/" target="_blank">http://developers.facebook.com/docs/reference/plugins/like-box/</a><br>
<br></div>My point is these sharing buttons are presentational, how will a plugin know my theme's design aesthetic? The data collected by these buttons can be used by any theme or plugin with out any vendor lock in...<br>
</div><div>Theme author can place these buttons precisely according to the design aesthetic, plugins will depend on some hook and quite often the result murders the design aesthetic. <br><br></div><div>Please reconsider....<br>
</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jun 13, 2013 at 12:18 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Please clarify what you mean by "social buttons".<div><br></div><div>Content-sharing buttons (i.e. like the "Share This" Plugin) aren't presentational.</div>
<div><br></div>
<div>Icon links to social network profiles are marginally presentational, and are analogous to favicons.</div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 2:42 PM, Srikanth Koneru <span dir="ltr"><<a href="mailto:tskk79@gmail.com" target="_blank">tskk79@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">but i thought you said social buttons are fine :<div><br>"Things that are marginally presentational (e.g. sharing links)? Using the Favicon guidelines as a model is reasonable."</div>
</div><div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Thu, Jun 13, 2013 at 12:08 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">I've added some clarification to the Guidelines:<div><a href="http://codex.wordpress.org/Theme_Review#Presentation_vs_Functionality" target="_blank">http://codex.wordpress.org/Theme_Review#Presentation_vs_Functionality</a><br>
</div><div><br></div><div>I also removed the "draft" designation from the hook callback guidelines.</div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 9:31 AM, Peter Kakoma <span dir="ltr"><<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>It reads like it was written by a lawyer :-)<br><br></div>Thanks Chip. That puts it to rest for me. The bit about guidelines being a moving target is also on point.<br>
<br></div>Cheers<br></div><div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 4:26 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">This is the defining principle in the Guidelines:<div><br></div><div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><div><ul style="line-height:22px;font-size:13px;font-family:sans-serif;list-style:square;margin:0px 0px 22px 16px;padding:0px">
<li style="margin:0px;padding:0px;text-align:left!important"><a href="http://codex.wordpress.org/Theme_Review#Presentation_vs_Functionality" title="Theme Review" style="text-decoration:none;color:rgb(76,166,207)" target="_blank">Presentation Vs. Functionality</a>:<ul style="margin:0px 0px 22px 16px;padding:0px;list-style:square">
<li style="margin:0px;padding:0px;text-align:left!important">Since the purpose of Themes is to define the presentation of user content, Themes must not be used to define the generation of user content, or to define Theme-independent site options or functionality.</li>
</ul></li></ul></div></blockquote></div><div>It's somewhat difficult to try to list every possible issue in the Guidelines, nor do we want to.<br></div><div><br></div><div>I would also like to reiterate: the intention has always been for continual improvement of the Guidelines, and continually raising the quality standard. Thus, there may be Themes in the directory that passed previous iterations of the Guidelines, but that would not pass the current iteration. Also, because reviews are performed by actual humans, who can interpret Guidelines differently, the review standard probably will never be 100% consistent. So, the "but there are other Themes in the directory that do X" is never a valid argument. The Guidelines may have changed; we reviewers may simply have screwed up and allowed something that was against the guidelines. Whatever the case: current Themes under review are expected to conform to the current Guidelines.</div>
</div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 9:16 AM, Peter Kakoma <span dir="ltr"><<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>The issue is that there is no definitive guideline about {plugin-territory-stuff}. I believe the end-goal of this discussion is to draft one and share it with the rest of the world (otherwise we'll be discussing this again two months from now when a first-time reviewer asks the same question)<br>
<br></div>And in as much as my theme is guilty of adding Analytics, I agree with you-the line should be drawn at non-presentational stuff (*cough* SEO, *cough*). Removing Analytics now, updating the theme.<br></div><div class="gmail_extra">
<div><div>
<br><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 4:06 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">I don't agree that the Favicon guidelines are appropriate for extending to all {plugin territory} functionality.<div><div><br></div><div>Things that are marginally presentational (e.g. sharing links)? Using the Favicon guidelines as a model is reasonable. But Google Analytics: no reason to facilitate Themes adding this functionality. It's not in any way whatsoever presentational. As far as I'm concerned, that's an absolute line of demarcation. If it's not in any way presentational, it doesn't belong in a Theme, opt-in/disabled-by-default or otherwise.</div>
</div></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Wed, Jun 12, 2013 at 8:37 AM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 2:46 AM, Peter Kakoma <span dir="ltr"><<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><li>Themes are recommended not to implement custom {plugin-territory-stuff} functionality. <br>
</li><li>If implemented, {plugin-territory-stuff} functionality is required to be opt-in, and disabled by default. <br>
</li><li>If implemented, {plugin-territory-stuff} functionality is required to support user-defined {plugin-territory-stuff} images</li></blockquote></div><br></div></div><div class="gmail_extra">Those points are fairly well sorted except for the third which is really more relevant to the original ideas behind the use of favicons, but if you use the first two points as your benchmark then you should be (for the most part but not 100% guaranteed) fine with going forward.<span><font color="#888888"><br>
<br></font></span></div><span><font color="#888888"><div class="gmail_extra"><br clear="all"><div>Edward Caissie<br>aka Cais.</div>
</div></font></span></div>
<br></div></div><div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></div></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br></div></div><span><font color="#888888">-- <br><a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a><br>
</font></span></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a><br>
</div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>