<div dir="ltr">Hi Abhik,<div style>Thanks for the feedback; point 1 has been duly resolved...another implementation I picked from the framework author. We do agree on point 1. </div><div style>Point 2 though, as far as I know, isn't grounds to reject a theme. Plugin/non-plugin territory, to the best of my knowledge, has been debated ad nauseam and the jury is still out. <br>
<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 11, 2013 at 7:31 PM, Abhik Biswas <span dir="ltr"><<a href="mailto:abhik@itsabhik.com" target="_blank">abhik@itsabhik.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif">Pete,<br></div><div class="gmail_default" style="font-family:verdana,sans-serif">
If I were reviewing your theme, I'd have rejected it straight away due to two major issues.<br>
<br></div><div class="gmail_default" style="font-family:verdana,sans-serif">1. Images should be resized using 'add_image_size', no external resizer is allowed.<br></div><div class="gmail_default" style="font-family:verdana,sans-serif">
2. Those social sharing buttons and Google Analytics integration. In my opinion, they fall under plugin territory.<br><br></div><div class="gmail_default" style="font-family:verdana,sans-serif">But, it all depends on the reviewer.<br>
</div><div class="gmail_default" style="font-family:verdana,sans-serif"><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 11, 2013 at 9:55 AM, Peter Kakoma <span dir="ltr"><<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks Springer. I've added to the discussion</div><div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Tue, Jun 11, 2013 at 7:11 AM, J.J. Springer <span dir="ltr"><<a href="mailto:jjgspringer@gmail.com" target="_blank">jjgspringer@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Peter, <br>I have updated your ticket with some other things that I found while I was reviewing the theme. I hope that they are helpful. Your ReadMe does have the proper credits, so thank you for that. :) I just wasn't sure what licenses were allowed.<br>
<br><br></div><div>Otto, <br>Thanks for the speedy response! No worries about closing the ticket. I'm new to the process so any help is appreciated. <br><br><br></div><div>Amy,<br>Thanks for the detailed answers. I just want to make sure that I do everything right!<br>
<br><br></div><div>Thanks again everyone for the help! Can't wait for the next one!<span><font color="#888888"><br><br></font></span></div><span><font color="#888888"><div>J.J.<br></div>
</font></span></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 10, 2013 at 8:42 PM, Peter Kakoma <span dir="ltr"><<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Otto,<div>The theme in question is mine; only issue it turns out after re-reading all the tips here is the base_64 encoding. I customized a very popular and very user-friendly framework -the Slightly Modified Options Framework. Very big themes use it.<br>
That l<font color="#444444" face="sans-serif"><span style="font-size:14px;line-height:19px">ine, </span></font><span style="color:rgb(68,68,68);font-family:sans-serif;font-size:14px;line-height:19px">"100% safe - ignore theme check nag", which I know got you :-) was added by the Framework author. I took his word for it...seeing as the framework is used everywhere. I figured several themes in the repository already use it. I'm very aware of the base64 encoding rule; <br>
<br>I've removed the option altogether; the encoding was being used to allow users import/export/transfer their settings. Will find another way of doing it...and will make changes to the framework repository so hopefully, the author can clean that up.</span></div>
<div><span style="color:rgb(68,68,68);font-family:sans-serif;font-size:14px;line-height:19px">I've re-uploaded the theme: </span><a href="http://themes.trac.wordpress.org/ticket/12964" target="_blank">http://themes.trac.wordpress.org/ticket/12964</a>. </div>
<div>Springer, if you can, please take a look at it again. (Seeing as you've already downloaded it and started the review :-) )</div><div><br></div><div>The credit link leads to my page: http:<a href="http://kakoma.ug" target="_blank">kakoma.ug</a>, which I'm upgrading right now. I can put something else if the current 'under construction' page is an issue</div>
<div><br></div><div>Oh, and the 'read me', as Springer can attest, contains proper credits</div></div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Tue, Jun 11, 2013 at 5:27 AM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Mon, Jun 10, 2013 at 8:54 PM, J.J. Springer <<a href="mailto:jjgspringer@gmail.com" target="_blank">jjgspringer@gmail.com</a>> wrote:<br>
</div><div>> 2. If I get any error of any sort, I assume that means that the theme is<br>
> automatically rejected. As soon as I run into an error, do I stop and mark<br>
> it rejected or keep going and try to find as many errors as possible? Is<br>
> there a point at which I should just stop and send it back?<br>
<br>
</div>This is up to you. Additionally, I apologize for usurping your review<br>
and failing the theme, but that kind of ticked me off a bit.<br>
<br>
If you wish to do a full review and give the theme author more tips<br>
and things that he needs to check on, that's perfectly acceptable.<br>
<div><br>
> 3. The theme that I'm reviewing is a child theme of twentytwelve and<br>
> therefore doesn't have the "required" theme template files (missing<br>
> comments.php). Are child themes allowed? Is there some special way that I'm<br>
> supposed to be reviewing them?<br>
<br>
</div>Child themes won't pass theme check, obviously, because of missing<br>
files and such. The review guidelines still stand though, and the<br>
child+parent must pass, as a whole, sort of thing. The parent is<br>
presumed to already have passed, since it's in the directory anyway.<br>
<div><br>
<br>
> 4. The person that I'm reviewing used a lot framework stuff that's MIT or<br>
> WTFPL licensed. Is that ok?<br>
<br>
</div>Both of those are GPL-Compat, so they're fine.<br>
<span><font color="#888888"><br>
<br>
-Otto<br>
</font></span><div><div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a><br>
</font></span></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a><br>
</div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a><br>
</div>