Not to be rude about it, but I would like to quote Otto again:<br><br><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">But Google Analytics, not so much. Realistically, the only thing you<br>
need to do for GA is to put some code in the footer, and there's<br>dozens of plugins to do that right. I can't think of any realistic<br>integration for a theme that would make sense. GA doesn't display<br>anything at all, it records visits, basically. Not relevant to the<br>
theme.<br><br>The way I see it, anything that is in the theme should somehow relate<br>to the *display* of the webpage. That's sort of the whole point of the<br>theme. If the code doesn't affect the *look* of the page in some way,<br>
then it shouldn't be in the theme<br></blockquote><br>Or he wrong?<br> <br><br><br><br>On Wed, Jun 12, 2013 at 10:18 AM, Emil Uzelac <<a href="mailto:emil@uzelac.me">emil@uzelac.me</a>> wrote:<br>> @Sayontan what makes you say that? <br>
><br>> Google verification, GA, Social Icons are empty fields, turned off<br>> by default, why would this be not-approved?<br>><br>><br>> On Tue, Jun 11, 2013 at 6:55 PM, Sayontan Sinha <<a href="mailto:sayontan@gmail.com">sayontan@gmail.com</a>> wrote:<br>
>>><br>>>> Plugin territory is a not-approve condition.<br>>><br>>><br>>> So "Responsive" should get its Google verification, Google Analytics etc.<br>>> removed, then, when there is an update? See<br>
>> <a href="http://themes.svn.wordpress.org/responsive/1.9.3.1/includes/theme-options.php">http://themes.svn.wordpress.org/responsive/1.9.3.1/includes/theme-options.php</a>. <br>>><br>>><br>>> On Tue, Jun 11, 2013 at 6:22 PM, Chip Bennett <<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>><br>
>> wrote:<br>>>><br>>>> Plugin territory is a not-approve condition.<br>>>><br>>>><br>>>> On Tue, Jun 11, 2013 at 6:45 PM, Harish <<a href="mailto:me@harishchouhan.com">me@harishchouhan.com</a>> wrote:<br>
>>>><br>>>>> Hello Chip,<br>>>>><br>>>>> <br>>>>><br>>>>> There are many themes in the repo that have Google Analytics integration<br>>>>> that could be activated from Theme Options.<br>
>>>><br>>>>> <br>>>>><br>>>>> Should a theme be rejected because it offers options for Google<br>>>>> Analytics and Sharing or social buttons?<br>>>>><br>
>>>> <br>>>>><br>>>>> <br>>>>><br>>>>> Regards,<br>>>>><br>>>>> Harish<br>>>>><br>>>>> <br>>>>><br>
>>>> From: theme-reviewers<br>>>>> [mailto:<a href="mailto:theme-reviewers-bounces@lists.wordpress.org">theme-reviewers-bounces@lists.wordpress.org</a>] On Behalf Of Chip<br>>>>> Bennett<br>
>>>> Sent: Wed 12 June 13 04:13 AM<br>>>>> To: [theme-reviewers]<br>>>>> Subject: Re: [theme-reviewers] Questions on my first review<br>>>>><br>>>>> <br>>>>><br>
>>>> Google Analytics and sharing buttons are Plugin territory.<br>>>>><br>>>>> <br>>>>><br>>>>> On Tue, Jun 11, 2013 at 5:00 PM, Peter Kakoma <<a href="mailto:kakomap@gmail.com">kakomap@gmail.com</a>> wrote:<br>
>>>><br>>>>> Hi Abhik,<br>>>>><br>>>>> Thanks for the feedback; point 1 has been duly resolved...another<br>>>>> implementation I picked from the framework author. We do agree on point 1. <br>
>>>><br>>>>> Point 2 though, as far as I know, isn't grounds to reject a theme.<br>>>>> Plugin/non-plugin territory, to the best of my knowledge, has been debated<br>>>>> ad nauseam and the jury is still out. <br>
>>>><br>>>>> <br>>>>><br>>>>> On Tue, Jun 11, 2013 at 7:31 PM, Abhik Biswas <<a href="mailto:abhik@itsabhik.com">abhik@itsabhik.com</a>><br>>>>> wrote:<br>
>>>><br>>>>> Pete,<br>>>>><br>>>>> If I were reviewing your theme, I'd have rejected it straight away due<br>>>>> to two major issues.<br>>>>><br>
>>>> 1. Images should be resized using 'add_image_size', no external resizer<br>>>>> is allowed.<br>>>>><br>>>>> 2. Those social sharing buttons and Google Analytics integration. In my<br>
>>>> opinion, they fall under plugin territory.<br>>>>><br>>>>> But, it all depends on the reviewer.<br>>>>><br>>>>> <br>>>>><br>>>>> <br>
>>>><br>>>>> On Tue, Jun 11, 2013 at 9:55 AM, Peter Kakoma <<a href="mailto:kakomap@gmail.com">kakomap@gmail.com</a>> wrote:<br>>>>><br>>>>> Thanks Springer. I've added to the discussion<br>
>>>><br>>>>> <br>>>>><br>>>>> On Tue, Jun 11, 2013 at 7:11 AM, J.J. Springer <<a href="mailto:jjgspringer@gmail.com">jjgspringer@gmail.com</a>><br>>>>> wrote:<br>
>>>><br>>>>> Peter,<br>>>>> I have updated your ticket with some other things that I found while I<br>>>>> was reviewing the theme. I hope that they are helpful. Your ReadMe does have<br>
>>>> the proper credits, so thank you for that. :) I just wasn't sure what<br>>>>> licenses were allowed.<br>>>>><br>>>>> Otto,<br>>>>> Thanks for the speedy response! No worries about closing the ticket. I'm<br>
>>>> new to the process so any help is appreciated.<br>>>>><br>>>>> Amy,<br>>>>> Thanks for the detailed answers. I just want to make sure that I do<br>>>>> everything right!<br>
>>>><br>>>>> Thanks again everyone for the help! Can't wait for the next one!<br>>>>><br>>>>> J.J.<br>>>>><br>>>>> <br>>>>><br>>>>> On Mon, Jun 10, 2013 at 8:42 PM, Peter Kakoma <<a href="mailto:kakomap@gmail.com">kakomap@gmail.com</a>> wrote:<br>
>>>><br>>>>> Hi Otto,<br>>>>><br>>>>> The theme in question is mine; only issue it turns out after re-reading<br>>>>> all the tips here is the base_64 encoding. I customized a very popular and<br>
>>>> very user-friendly framework -the Slightly Modified Options Framework. Very<br>>>>> big themes use it.<br>>>>> That line, "100% safe - ignore theme check nag", which I know got you<br>
>>>> :-) was added by the Framework author. I took his word for it...seeing as<br>>>>> the framework is used everywhere. I figured several themes in the repository<br>>>>> already use it. I'm very aware of the base64 encoding rule; <br>
>>>><br>>>>> I've removed the option altogether; the encoding was being used to allow<br>>>>> users import/export/transfer their settings. Will find another way of doing<br>>>>> it...and will make changes to the framework repository so hopefully, the<br>
>>>> author can clean that up.<br>>>>><br>>>>> I've re-uploaded the theme:<br>>>>> <a href="http://themes.trac.wordpress.org/ticket/12964">http://themes.trac.wordpress.org/ticket/12964</a>. <br>
>>>><br>>>>> Springer, if you can, please take a look at it again. (Seeing as you've<br>>>>> already downloaded it and started the review :-) )<br>>>>><br>>>>> <br>
>>>><br>>>>> The credit link leads to my page: http:<a href="http://kakoma.ug">kakoma.ug</a>, which I'm upgrading<br>>>>> right now. I can put something else if the current 'under construction' page<br>
>>>> is an issue<br>>>>><br>>>>> <br>>>>><br>>>>> Oh, and the 'read me', as Springer can attest, contains proper credits<br>>>>><br>>>>> <br>
>>>><br>>>>> On Tue, Jun 11, 2013 at 5:27 AM, Otto <<a href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</a>> wrote:<br>>>>><br>>>>> On Mon, Jun 10, 2013 at 8:54 PM, J.J. Springer <<a href="mailto:jjgspringer@gmail.com">jjgspringer@gmail.com</a>><br>
>>>> wrote:<br>>>>><br>>>>> > 2. If I get any error of any sort, I assume that means that the theme<br>>>>> > is<br>>>>> > automatically rejected. As soon as I run into an error, do I stop and<br>
>>>> > mark<br>>>>> > it rejected or keep going and try to find as many errors as possible?<br>>>>> > Is<br>>>>> > there a point at which I should just stop and send it back?<br>
>>>><br>>>>> This is up to you. Additionally, I apologize for usurping your review<br>>>>> and failing the theme, but that kind of ticked me off a bit.<br>>>>><br>>>>> If you wish to do a full review and give the theme author more tips<br>
>>>> and things that he needs to check on, that's perfectly acceptable.<br>>>>><br>>>>><br>>>>> > 3. The theme that I'm reviewing is a child theme of twentytwelve and<br>
>>>> > therefore doesn't have the "required" theme template files (missing<br>>>>> > comments.php). Are child themes allowed? Is there some special way<br>>>>> > that I'm<br>
>>>> > supposed to be reviewing them?<br>>>>><br>>>>> Child themes won't pass theme check, obviously, because of missing<br>>>>> files and such. The review guidelines still stand though, and the<br>
>>>> child+parent must pass, as a whole, sort of thing. The parent is<br>>>>> presumed to already have passed, since it's in the directory anyway.<br>>>>><br>>>>><br>>>>><br>
>>>> > 4. The person that I'm reviewing used a lot framework stuff that's MIT<br>>>>> > or<br>>>>> > WTFPL licensed. Is that ok?<br>>>>><br>>>>> Both of those are GPL-Compat, so they're fine.<br>
>>>><br>>>>><br>>>>> -Otto<br>>>>><br>>>>> _______________________________________________<br>>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>><br>>>>><br>>>>><br>>>>> <br>
>>>><br>>>>> --<br>>>>> <a href="http://www.urbanlegendkampala.com">www.urbanlegendkampala.com</a><br>>>>><br>>>>><br>>>>> _______________________________________________<br>
>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>><br>>>>> <br>>>>><br>>>>><br>>>>> _______________________________________________<br>>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>><br>>>>><br>>>>><br>>>>> <br>
>>>><br>>>>> --<br>>>>> <a href="http://www.urbanlegendkampala.com">www.urbanlegendkampala.com</a><br>>>>><br>>>>><br>>>>> _______________________________________________<br>
>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>><br>>>>> <br>>>>><br>>>>><br>>>>> _______________________________________________<br>>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>><br>>>>><br>>>>><br>>>>> <br>
>>>><br>>>>> --<br>>>>> <a href="http://www.urbanlegendkampala.com">www.urbanlegendkampala.com</a><br>>>>><br>>>>><br>>>>> _______________________________________________<br>
>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>><br>>>>> <br>>>>><br>>>>><br>>>>> _______________________________________________<br>>>>> theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>><br>>>><br>>>><br>>>> _______________________________________________<br>
>>> theme-reviewers mailing list<br>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>><br>>><br>>><br>>><br>>> --<br>>> Sayontan Sinha<br>>> <a href="http://mynethome.net">http://mynethome.net</a> | <a href="http://mynethome.net/blog">http://mynethome.net/blog</a><br>
>> --<br>>><br>>><br>>> _______________________________________________<br>>> theme-reviewers mailing list<br>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>><br>><br>><br>> _______________________________________________<br>
> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br><br>