<div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Plugin territory is a not-approve condition.</blockquote>
<div><br></div><div class="gmail_extra">So "Responsive" should get its Google verification, Google Analytics etc. removed, then, when there is an update? See <a href="http://themes.svn.wordpress.org/responsive/1.9.3.1/includes/theme-options.php">http://themes.svn.wordpress.org/responsive/1.9.3.1/includes/theme-options.php</a>. <br>
<br><div class="gmail_quote">On Tue, Jun 11, 2013 at 6:22 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">Plugin territory is a not-approve condition.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 11, 2013 at 6:45 PM, Harish <span dir="ltr"><<a href="mailto:me@harishchouhan.com" target="_blank">me@harishchouhan.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div lang="EN-IN" link="blue" vlink="purple"><div><p class="">
<span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Hello Chip,<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p><p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">There are many themes in the repo that have Google Analytics integration that could be activated from Theme Options. <u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p><p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Should a theme be rejected because it offers options for Google Analytics and Sharing or social buttons? <u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p><p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(64,64,64)"><u></u> <u></u></span></p>
<p class="" style="line-height:150%"><span style="font-size:11pt;line-height:150%;font-family:Calibri,sans-serif;color:rgb(64,64,64)">Regards,<u></u><u></u></span></p><p class="" style="line-height:150%">
<span style="font-size:11pt;line-height:150%;font-family:Calibri,sans-serif;color:rgb(64,64,64)">Harish</span><span style="font-size:10pt;line-height:150%;font-family:Calibri,sans-serif;color:rgb(13,13,13)"> <b><u></u><u></u></b></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p><p class=""><b><span lang="EN-US" style="font-size:11pt;font-family:Calibri,sans-serif">From:</span></b><span lang="EN-US" style="font-size:11pt;font-family:Calibri,sans-serif"> theme-reviewers [mailto:<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>] <b>On Behalf Of </b>Chip Bennett<br>
<b>Sent:</b> Wed 12 June 13 04:13 AM<br><b>To:</b> [theme-reviewers]<br><b>Subject:</b> Re: [theme-reviewers] Questions on my first review<u></u><u></u></span></p><div><div><p class=""><u></u> <u></u></p>
<div><p class="">Google Analytics and sharing buttons are Plugin territory.<u></u><u></u></p></div><div><p class="" style="margin-bottom:12pt"><u></u> <u></u></p><div><p class="">On Tue, Jun 11, 2013 at 5:00 PM, Peter Kakoma <<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border-style:none none none solid;border-left-color:rgb(204,204,204);border-left-width:1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm"><div><p class="">Hi Abhik,<u></u><u></u></p><div><p class="">
Thanks for the feedback; point 1 has been duly resolved...another implementation I picked from the framework author. We do agree on point 1. <u></u><u></u></p>
</div><div><p class="" style="margin-bottom:12pt">Point 2 though, as far as I know, isn't grounds to reject a theme. Plugin/non-plugin territory, to the best of my knowledge, has been debated ad nauseam and the jury is still out. <u></u><u></u></p>
</div></div><div><div><div><p class="" style="margin-bottom:12pt"><u></u> <u></u></p><div><p class="">On Tue, Jun 11, 2013 at 7:31 PM, Abhik Biswas <<a href="mailto:abhik@itsabhik.com" target="_blank">abhik@itsabhik.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border-style:none none none solid;border-left-color:rgb(204,204,204);border-left-width:1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm"><div><div><p class=""><span style="font-family:Verdana,sans-serif">Pete,<u></u><u></u></span></p>
</div><div><p class="" style="margin-bottom:12pt"><span style="font-family:Verdana,sans-serif">If I were reviewing your theme, I'd have rejected it straight away due to two major issues.<u></u><u></u></span></p>
</div><div><p class=""><span style="font-family:Verdana,sans-serif">1. Images should be resized using 'add_image_size', no external resizer is allowed.<u></u><u></u></span></p></div>
<div><p class="" style="margin-bottom:12pt"><span style="font-family:Verdana,sans-serif">2. Those social sharing buttons and Google Analytics integration. In my opinion, they fall under plugin territory.<u></u><u></u></span></p>
</div><div><p class=""><span style="font-family:Verdana,sans-serif">But, it all depends on the reviewer.<u></u><u></u></span></p></div><div><p class=""><span style="font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div></div><div><div><div><p class="" style="margin-bottom:12pt"><u></u> <u></u></p><div><p class="">On Tue, Jun 11, 2013 at 9:55 AM, Peter Kakoma <<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border-style:none none none solid;border-left-color:rgb(204,204,204);border-left-width:1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm"><div><p class="">Thanks Springer. I've added to the discussion<u></u><u></u></p>
</div>
<div><div><div><p class="" style="margin-bottom:12pt"><u></u> <u></u></p><div><p class="">On Tue, Jun 11, 2013 at 7:11 AM, J.J. Springer <<a href="mailto:jjgspringer@gmail.com" target="_blank">jjgspringer@gmail.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border-style:none none none solid;border-left-color:rgb(204,204,204);border-left-width:1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm"><div><div><p class="" style="margin-bottom:12pt">Peter, <br>
I have updated your ticket with some other things that I found while I was reviewing the theme. I hope that they are helpful. Your ReadMe does have the proper credits, so thank you for that. :) I just wasn't sure what licenses were allowed.<br>
<br><u></u><u></u></p></div><div><p class="" style="margin-bottom:12pt">Otto, <br>Thanks for the speedy response! No worries about closing the ticket. I'm new to the process so any help is appreciated. <br>
<br><u></u><u></u></p></div><div><p class="" style="margin-bottom:12pt">Amy,<br>Thanks for the detailed answers. I just want to make sure that I do everything right!<br><br><u></u><u></u></p></div><div><p class="" style="margin-bottom:12pt">
Thanks again everyone for the help! Can't wait for the next one!<u></u><u></u></p></div><div><p class=""><span style="color:rgb(136,136,136)">J.J.<u></u><u></u></span></p></div></div><div><div><div><p class="" style="margin-bottom:12pt">
<u></u> <u></u></p><div><p class="">On Mon, Jun 10, 2013 at 8:42 PM, Peter Kakoma <<a href="mailto:kakomap@gmail.com" target="_blank">kakomap@gmail.com</a>> wrote:<u></u><u></u></p><blockquote style="border-style:none none none solid;border-left-color:rgb(204,204,204);border-left-width:1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<div><p class="">Hi Otto,<u></u><u></u></p><div><p class="">The theme in question is mine; only issue it turns out after re-reading all the tips here is the base_64 encoding. I customized a very popular and very user-friendly framework -the Slightly Modified Options Framework. Very big themes use it.<br>
That l<span style="font-size:10.5pt;font-family:Arial,sans-serif;color:rgb(68,68,68)">ine, "100% safe - ignore theme check nag", which I know got you :-) was added by the Framework author. I took his word for it...seeing as the framework is used everywhere. I figured several themes in the repository already use it. I'm very aware of the base64 encoding rule; <br>
<br>I've removed the option altogether; the encoding was being used to allow users import/export/transfer their settings. Will find another way of doing it...and will make changes to the framework repository so hopefully, the author can clean that up.</span><u></u><u></u></p>
</div><div><p class=""><span style="font-size:10.5pt;font-family:Arial,sans-serif;color:rgb(68,68,68)">I've re-uploaded the theme: </span><a href="http://themes.trac.wordpress.org/ticket/12964" target="_blank">http://themes.trac.wordpress.org/ticket/12964</a>. <u></u><u></u></p>
</div><div><p class="">Springer, if you can, please take a look at it again. (Seeing as you've already downloaded it and started the review :-) )<u></u><u></u></p></div><div><p class=""><u></u> <u></u></p>
</div><div><p class="">The credit link leads to my page: http:<a href="http://kakoma.ug" target="_blank">kakoma.ug</a>, which I'm upgrading right now. I can put something else if the current 'under construction' page is an issue<u></u><u></u></p>
</div><div><p class=""><u></u> <u></u></p></div><div><p class="">Oh, and the 'read me', as Springer can attest, contains proper credits<u></u><u></u></p></div></div><div><div><div><p class="" style="margin-bottom:12pt">
<u></u> <u></u></p><div><p class="">On Tue, Jun 11, 2013 at 5:27 AM, Otto <<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>> wrote:<u></u><u></u></p><blockquote style="border-style:none none none solid;border-left-color:rgb(204,204,204);border-left-width:1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<div><p class="">On Mon, Jun 10, 2013 at 8:54 PM, J.J. Springer <<a href="mailto:jjgspringer@gmail.com" target="_blank">jjgspringer@gmail.com</a>> wrote:<u></u><u></u></p></div><div><p class="" style="margin-bottom:12pt">
> 2. If I get any error of any sort, I assume that means that the theme is<br>> automatically rejected. As soon as I run into an error, do I stop and mark<br>> it rejected or keep going and try to find as many errors as possible? Is<br>
> there a point at which I should just stop and send it back?<u></u><u></u></p></div><p class="">This is up to you. Additionally, I apologize for usurping your review<br>and failing the theme, but that kind of ticked me off a bit.<br>
<br>If you wish to do a full review and give the theme author more tips<br>and things that he needs to check on, that's perfectly acceptable.<u></u><u></u></p><div><p class="" style="margin-bottom:12pt"><br>
> 3. The theme that I'm reviewing is a child theme of twentytwelve and<br>> therefore doesn't have the "required" theme template files (missing<br>> comments.php). Are child themes allowed? Is there some special way that I'm<br>
> supposed to be reviewing them?<u></u><u></u></p></div><p class="">Child themes won't pass theme check, obviously, because of missing<br>files and such. The review guidelines still stand though, and the<br>
child+parent must pass, as a whole, sort of thing. The parent is<br>presumed to already have passed, since it's in the directory anyway.<u></u><u></u></p><div><p class="" style="margin-bottom:12pt"><br><br>
> 4. The person that I'm reviewing used a lot framework stuff that's MIT or<br>> WTFPL licensed. Is that ok?<u></u><u></u></p></div><p class="">Both of those are GPL-Compat, so they're fine.<br>
<span style="color:rgb(136,136,136)"><br><br>-Otto</span><u></u><u></u></p><div><div><p class="">_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><u></u><u></u></p></div></div></blockquote></div><p class=""><br>
<br clear="all"><u></u><u></u></p><div><p class=""><u></u> <u></u></p></div></div></div><p class=""><span style="color:rgb(136,136,136)">-- <br><a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a></span><u></u><u></u></p>
</div><p class="" style="margin-bottom:12pt"><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><u></u><u></u></p></blockquote></div><p class=""><u></u> <u></u></p>
</div></div></div><p class="" style="margin-bottom:12pt"><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><u></u><u></u></p></blockquote></div><p class=""><br><br clear="all">
<u></u><u></u></p><div><p class=""><u></u> <u></u></p></div><p class="">-- <br><a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a><u></u><u></u></p></div></div></div>
<p class="" style="margin-bottom:12pt"><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><u></u><u></u></p></blockquote></div><p class=""><u></u> <u></u></p>
</div></div></div><p class="" style="margin-bottom:12pt"><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><u></u><u></u></p></blockquote></div><p class=""><br><br clear="all">
<u></u><u></u></p><div><p class=""><u></u> <u></u></p></div><p class="">-- <br><a href="http://www.urbanlegendkampala.com" target="_blank">www.urbanlegendkampala.com</a><u></u><u></u></p></div></div></div>
<p class="" style="margin-bottom:12pt"><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><u></u><u></u></p></blockquote></div><p class=""><u></u> <u></u></p>
</div></div></div></div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
--<br><br>
</div></div>