<div dir="ltr">namespace is a php thing, its separate from gettext textdomain isn't it? </div><div class="gmail_extra"><br><br><div class="gmail_quote">On 22 May 2013 20:46, esmi at quirm dot net <span dir="ltr"><<a href="mailto:esmi@quirm.net" target="_blank">esmi@quirm.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><<a href="https://themes.trac.wordpress.org/ticket/12206" target="_blank">https://themes.trac.<u></u>wordpress.org/ticket/12206</a>><br>
<br>
Is using <?php namespace theme; ?> a reasonable excuse for then using 'theme' as a textdomain? My gut instinct says "no".<br>
<br>
That said, this theme is totally unlike any standard WPORG theme. The whole thing is pure actions hooks & filters (which is cool) but...<br>
<br>
1. functions are not being named. - they're being added (wholesale) as the second argument to add_action and add_filter.<br>
2. locate_template() is being used instead of get_template().<br>
<br>
In general, trying to apply the guidelines to this theme is like trying to plait fog. It looks more like it's intended as a framework than a theme. Anyone care to weigh in?<br>
<br>
Mel<span class="HOEnZb"><font color="#888888"><br>
-- <br>
<a href="http://quirm.net" target="_blank">http://quirm.net</a><br>
<a href="http://blackwidows.co.uk" target="_blank">http://blackwidows.co.uk</a><br>
______________________________<u></u>_________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/<u></u>mailman/listinfo/theme-<u></u>reviewers</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>My Blog: <a href="http://pross.org.uk/" target="_blank">http://pross.org.uk/</a><br>Plugins : <a href="http://pross.org.uk/plugins/" target="_blank">http://pross.org.uk/plugins/</a><br>
Themes: <a href="http://wordpress.org/extend/themes/profile/pross" target="_blank">http://wordpress.org/extend/themes/profile/pross</a>
</div>