So why is the Theme including core-defined shortcodes?<div><br></div><div>Uh.. </div><div><a href="http://codex.wordpress.org/Theme_Unit_Test">http://codex.wordpress.org/Theme_Unit_Test</a></div><div>I just supported default wordpress shortcodes.. video,audio and gallery.. Is it not allowed too? god.. what is wrong with community..</div>
<div><br></div><div><h3 style="padding:0px 0px 4px;font-weight:normal;font-size:20px;color:rgb(51,51,51);font-family:Georgia,'Times New Roman',Times,serif;border-bottom-width:1px;border-bottom-style:solid;border-color:rgb(238,238,238);line-height:22px;background-color:rgb(255,255,255)">
<span class="mw-headline">Post Format Test: Video</span></h3><ul style="margin:0px 0px 22px 16px;padding:0px;list-style:square;font-family:sans-serif;font-size:13px;line-height:22px;background-color:rgb(255,255,255)"><li style="margin:0px;padding:0px;text-align:left!important">
Video displays as intended in the index view</li><li style="margin:0px;padding:0px;text-align:left!important">Video does not overflow the content area</li></ul><div><h3 style="padding:0px 0px 4px;font-weight:normal;font-size:20px;color:rgb(51,51,51);font-family:Georgia,'Times New Roman',Times,serif;border-bottom-width:1px;border-bottom-style:solid;border-color:rgb(238,238,238);line-height:22px;background-color:rgb(255,255,255)">
<span class="mw-headline">Post Format Test: Audio</span></h3><ul style="margin:0px 0px 22px 16px;padding:0px;list-style:square;font-family:sans-serif;font-size:13px;line-height:22px;background-color:rgb(255,255,255)"><li style="margin:0px;padding:0px;text-align:left!important">
Enclosure links work properly.</li></ul></div></div><div><br><div class="gmail_quote">On Sun, Mar 3, 2013 at 4:17 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">So why is the Theme including core-defined shortcodes?<div><br></div><div>As for the TinyMCE buttons: I explained that. To repeat:</div>
<div class="im"><div><br></div><div><span style="font-family:arial,sans-serif;font-size:13px">But, for the TinyMCE buttons: my initial reaction would be to say that they also are probably Plugin territory. What do the buttons do? What do they add to the post content? Wrap selected content in <span class="foo bar"></span> tags? Sure, that degrades more gracefully than un-parsed shortcodes, but it would still result in a bunch of unused markup scattered throughout the user's posts after switching Themes. </span><b style="font-family:arial,sans-serif;font-size:13px">Thus, I would say that the TinyMCE buttons are also Plugin territory</b><span style="font-family:arial,sans-serif;font-size:13px">. I would recommend defining the *styles* for the CSS classes added via the TinyMCE buttons, but make the underlying TinyMCE button functionality itself a Plugin.</span><br>
</div></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Mar 3, 2013 at 9:15 AM, Ünsal Korkmaz <span dir="ltr"><<a href="mailto:unsalkorkmaz@gmail.com" target="_blank">unsalkorkmaz@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">There is no <span style="color:rgb(34,34,34);font-size:13px;font-family:arial,sans-serif">[audio], [gallery], and [video] buttons in the TinyMCE editor.. as i said clearly tinymce button is only adding css code.</span><div>
<div><div>
<font color="#222222" face="arial, sans-serif"><br></font><br><div class="gmail_quote">On Sun, Mar 3, 2013 at 4:14 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'd still say that's Plugin territory. Rule-of-thumb question: would the end user want, and reasonably expect, for that functionality to remain, regardless of what Theme is active? Having [audio], [gallery], and [video] buttons in the TinyMCE editor would certainly be a "yes" to that question. That's why it's Plugin territory.</div>
<div><div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Mar 3, 2013 at 9:10 AM, Ünsal Korkmaz <span dir="ltr"><<a href="mailto:unsalkorkmaz@gmail.com" target="_blank">unsalkorkmaz@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thank you for review but i mean tinymce does not adding shortcode, it adds css code.<div><a href="http://themes.svn.wordpress.org/firmasite/1.1.0/functions/shortcodes.php" target="_blank">http://themes.svn.wordpress.org/firmasite/1.1.0/functions/shortcodes.php</a></div>
<div>Those shortcodes are wordpress's default shortcodes. audio, gallery, video.<div><div><br><br><div class="gmail_quote">On Sun, Mar 3, 2013 at 4:07 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hmm, actually, there *are* shortcodes:<div><a href="http://themes.svn.wordpress.org/firmasite/1.1.0/functions/shortcodes.php" target="_blank">http://themes.svn.wordpress.org/firmasite/1.1.0/functions/shortcodes.php</a><br>
</div>
<div><br></div><div>And this is definitely Plugin territory:</div><div><a href="http://themes.svn.wordpress.org/firmasite/1.1.0/functions/remove-comments-absolute.php" target="_blank">http://themes.svn.wordpress.org/firmasite/1.1.0/functions/remove-comments-absolute.php</a><br>
</div><div><br></div><div>And a good deal of this is Plugin territory:</div><div><a href="http://themes.svn.wordpress.org/firmasite/1.1.0/functions/fix.php" target="_blank">http://themes.svn.wordpress.org/firmasite/1.1.0/functions/fix.php</a><br>
</div><div><br></div><div>And this is also probably Plugin territory (though a bit of a gray area):</div><div><a href="http://themes.svn.wordpress.org/firmasite/1.1.0/functions/custom-sharing-buttons.php" target="_blank">http://themes.svn.wordpress.org/firmasite/1.1.0/functions/custom-sharing-buttons.php</a><br>
</div><div><a href="http://themes.svn.wordpress.org/firmasite/1.1.0/functions/custom-facebook-comments.php" target="_blank">http://themes.svn.wordpress.org/firmasite/1.1.0/functions/custom-facebook-comments.php</a><br></div>
<div><br>
</div><div>But, for the TinyMCE buttons: my initial reaction would be to say that they also are probably Plugin territory. What do the buttons do? What do they add to the post content? Wrap selected content in <span class="foo bar"></span> tags? Sure, that degrades more gracefully than un-parsed shortcodes, but it would still result in a bunch of unused markup scattered throughout the user's posts after switching Themes. <b>Thus, I would say that the TinyMCE buttons are also Plugin territory</b>. I would recommend defining the *styles* for the CSS classes added via the TinyMCE buttons, but make the underlying TinyMCE button functionality itself a Plugin.</div>
<div><br></div><div>Regards,</div><div><br></div><div>Chip</div></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Sun, Mar 3, 2013 at 8:00 AM, Ünsal Korkmaz <span dir="ltr"><<a href="mailto:unsalkorkmaz@gmail.com" target="_blank">unsalkorkmaz@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>Hi,<div>My theme:</div><div><a href="http://themes.trac.wordpress.org/ticket/11437" target="_blank">http://themes.trac.wordpress.org/ticket/11437</a></div>
<div>Theme is adding custom tinymce button that adds css code for design elements. There is no shortcode or something.. just css code. </div>
<div>Its allowed in themes right?</div>
<br></div></div><div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></div></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>