<div dir="ltr"><div>I have reviewed the theme and according to my view (already explained in the ticket),</div><div><br></div><div>- If the front end of theme does not support the flexible height of header than what is its advantage ? Suppose a user uploads header of 940x350 dimension as the theme claims flexible header but it is useless as front end does not support it.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Mar 1, 2013 at 11:27 PM, Srini <span dir="ltr"><<a href="mailto:srinig112@gmail.com" target="_blank">srinig112@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Here is a case:<div><br></div><div>Recently I submitted a theme with header size 940x140 pixels, and accordingly pass the values 940 and 140 for 'width' and 'height' arguments into the add_theme_support('custom_header') call. I also set 'flex-width' and 'flex-height' to true, just to give the user more flexibility to crop the image to a different size if they want. That's because the header size isn't really fixed, it varies according to the viewport widths, length of site title/description, etc., so just wanted to give the user some room to play around with a header image size of their choice and get it just the way they want. </div>
<div><br></div><div>Now, the reviewer contends that the size of the header element in the front end *must* grow/shrink if the user uploads a header image with a different height than suggested. The only way for me to achieve that is to increase/decrease the padding above and/or below the site title/description. I don't want to do that as that as modifying the padding would interfere with the proportions of design (at least in my eyes). The other option is to set 'flex-height' to false, and I don't want to do this too for reasons I mentioned above.</div>
<div><br></div><div>The reviewer has cited this issue as one one of the reasons for not-approving the theme. Even if the argument is valid, I'm not sure how this can be a reason to turn down a theme. I'd appreciate opinions on this issue.</div>
<div><br></div><div>Here is the ticket: <a href="http://themes.trac.wordpress.org/ticket/11346" target="_blank">http://themes.trac.wordpress.org/ticket/11346</a></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><font color="#666666">Regards</font><div><font color="#666666">Qamar Ashraf</font></div><div><font color="#666666">Project Manager</font></div><div><font color="#666666"><a href="http://www.tutorialchip.com" target="_blank">www.tutorialchip.com</a></font></div>
<div><font color="#666666"><a href="http://www.freestockphotosclub.com" target="_blank">www.freestockphotosclub.com</a></font></div><div><a href="http://www.twunfollowapp.com" target="_blank">www.twunfollowapp.com</a></div>
<div><font color="#666666">@lifeobject1</font></div>
</div>