<div dir="ltr">If the theme author says he is fixing a major bug, should we approve the theme disregarding other required issues?<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Feb 24, 2013 at 7:18 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">I you find issues, however you find them - diff-review, code review, unit tests, etc. - you should note them. If the issues are at your discretion minor enough, you can require them to be addressed in the next Theme revision. But if they resulted from an insufficient/incomplete prior review, you're probably better off marking them as required and resolving as "not-approved". </p>
<p dir="ltr">(Again at your discretion you nay hold the ticket open to allow the developer to upload a revision, then continue the review in the bew ticket.)</p><div class="HOEnZb"><div class="h5">
<div class="gmail_quote">On Feb 24, 2013 4:23 AM, "Greg Priday" <<a href="mailto:greg@siteorigin.com" target="_blank">greg@siteorigin.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I just picked up this ticket <a href="http://themes.trac.wordpress.org/ticket/10913" target="_blank">http://themes.trac.wordpress.org/ticket/10913</a><br>
<br>
After giving it a full review I noticed that it's already live in the<br>
directory. For some reason it landed up in the "Previously Reviewed,<br>
Not Approved" queue.<br>
<br>
Should I approve the theme based on a diff review or require that the<br>
author fix the required issues I found?<br>
<br>
--<br>
I make free WordPress themes<br>
<a href="http://siteorigin.com" target="_blank">http://siteorigin.com</a><br>
<a href="http://facebook.com/SiteOrigin" target="_blank">http://facebook.com/SiteOrigin</a><br>
<a href="http://twitter.com/SiteOrigin" target="_blank">http://twitter.com/SiteOrigin</a><br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</blockquote></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>