<div dir="ltr">By the same token: by Themes always hooking into after_setup_theme to define $content_width, a Plugin would always know that it is defined at that hook, and would not have to rely on the somewhat-more-arbitrary plugins_loaded (IIRC?) when functions.php executes.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 21, 2013 at 4:35 PM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
After reviewing the code for a bit and looking at the possible<br>
problems, I think that doing it the way the Twenty themes do it is<br>
correct. That is to say, leave it outside a function scope and use<br>
code like this:<br>
<div class="im"><br>
if ( ! isset( $content_width ) )<br>
</div> $content_width = 640;<br>
<br>
Alternatively, this method is more clear about what is going on, by<br>
explicitly stating that the value is global (even though a theme's<br>
functions.php already runs in the global context, for now). Note that<br>
theme-check probably doesn't recognize this as valid, yet.<br>
<br>
if ( ! isset( $GLOBALS['content_width'] ) )<br>
$GLOBALS['content_width'] = 640;<br>
<br>
Reasons:<br>
<br>
- It is possible that a plugin which needs to know this information<br>
will hook to after_setup_theme in order to find it out, because<br>
after_setup_theme runs immediately after the theme's functions.php<br>
file is executed. If the theme puts it in a function hooked to that<br>
same action as well, then the theme's setup function may be called<br>
after the plugin is called upon and looks for it. Relying on usual<br>
hook priorities to get this order correct is uncertain, and best<br>
avoided.<br>
<br>
- A child can override a parent just fine if both child and parent<br>
implement this in this way. The child runs first, sets the<br>
content_width, then the parent runs, sees it's already set, and<br>
doesn't change it.<br>
<br>
I would treat this as a suggestion or best practice, it shouldn't fail<br>
a theme for doing it differently.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Otto<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On Mon, Jan 21, 2013 at 3:14 PM, Chip Bennett <<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>> wrote:<br>
> That is absolutely not something that a Theme should be "not-approved" for,<br>
> though.<br>
><br>
><br>
> On Mon, Jan 21, 2013 at 4:10 PM, Philip M. Hofer (Frumph)<br>
> <<a href="mailto:philip@frumph.net">philip@frumph.net</a>> wrote:<br>
>><br>
>> By that ticket, the $content_width in twentytwelve would fail<br>
>><br>
>><br>
>><br>
>> From: Caroline Moore<br>
>> Sent: Monday, January 21, 2013 5:39 AM<br>
>> To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> Subject: Re: [theme-reviewers] Need A Final Call<br>
>><br>
>> The ticket, for reference:<br>
>> <a href="http://themes.trac.wordpress.org/ticket/10498" target="_blank">http://themes.trac.wordpress.org/ticket/10498</a><br>
>><br>
>><br>
>> On Monday, January 21, 2013 at 8:34 AM, Qamar Ashraf wrote:<br>
>><br>
>> 1. About $content_width<br>
>><br>
>> What is the best place for the $content_width<br>
>><br>
>> A. Wrap $content_width definition in a callback, hooked into<br>
>> after_setup_theme - ( I am reviewing on this point )<br>
>> B. Placing $content_width outside a function<br>
>><br>
>> 2. About IE Conditional Tags / Scripts like HTML 5 Shiv<br>
>><br>
>> A. - Additional scripts should not be hard-coded in the header template.<br>
>> The most appropriate way to handle them to place it in a function that hooks<br>
>> into wp_head. ( I am reviewing on this point )<br>
>> B. Can be placed directly in header.php<br>
>><br>
>><br>
>><br>
>> ________________________________<br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>><br>
>><br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> theme-reviewers mailing list<br>
> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br></div>