<div dir="ltr"><div><div>As I see it, the Theme Review Team was never meant to be and should not be opening the door to become "the" Quality Control mechanism for Theme Authors; that responsibility still falls squarely on their shoulders.<br>
<br></div>I can see merit to continuing with a reviewer-prerogative method of keeping tickets open but as others have noted in the past and once again in this conversation, this could lead to the WPTRT becoming even more of a QC system than it already is. Themes should be approved within two iterations of the initial submission as far as I am concerned, beyond that let them go to the back of the line. Themes previously approved should continue to be approved (with the exception of minor over-sights directly related to "REQUIRED" items as this "open-ticket" idea allows for), or they should simply go back into the pool like new themes as well. <br>
<br></div>Perhaps I am being a bit on the harsh side (and I do not want to sidetrack this topic), but I still see themes submitted that simply should be resolved as "not-approved" as soon as they pass the upload check (especially with one of the most obvious items: inappropriate screenshots).<br>
</div><div class="gmail_extra"><br clear="all"><div>Edward Caissie<br>aka Cais.</div>
<br><br><div class="gmail_quote">On Mon, Jan 7, 2013 at 10:45 AM, yulian yordanov <span dir="ltr"><<a href="mailto:yul.yordanov@gmail.com" target="_blank">yul.yordanov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>When I was more active reviewer, it
such cases I discussed in the ticket if the author is able to make
fixes quickly. And of course we talk about some minor issue or an
oversight which can be fixed easily.š <br>
<br>
Fingli<div><div class="h5"><br>
<br>
On 7.1.2013 Ç. 17:27 Þ., Mario Peshev wrote:<br>
</div></div></div><div><div class="h5">
<blockquote type="cite">It's a very gray territory there, probably, I would
just be happy to hear other opinions as well (both admins and
reviewers). There's the compromise between the reviewers
(volunteers) time and the very long cycle for a theme to get in
due to the hundreds of requirements whilst a number of them are
subjective.š
<div>
<br>
</div>
<div>Unless other group participants take a position here, I'll
postpone the idea for now since it could get messy and involve
specific theme review rules, their significance, reviewer's
time, type of authors (regular contributors vs. new ones, and
large companies vs. solo devs).š</div>
<div><br>
</div>
<div>Thanks,<br clear="all">
<div><br>
Mario Peshev<br>
WordPress Engineer, Open Source Consultant<br>
<a href="http://www.linkedin.com/in/mpeshev" target="_blank">http://www.linkedin.com/in/mpeshev</a><br>
<div><a href="http://me.peshev.net/" target="_blank">http://me.peshev.net</a></div>
<div><br>
</div>
</div>
<br>
<br>
<div class="gmail_quote">On Mon, Jan 7, 2013 at 5:17 PM, Chip
Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">At the moment, we leave that determination
entirely up to the Reviewer: any ticket, at the sole
discretion of the Reviewer, may be held open to allow for
a revision to be submitted, in order to continue the
review on a subsequent ticket.
<div>
<br>
</div>
<div>Personally, I would like to see this stay at the
informal, discretion-of-the-Reviewer level, rather than
try to formalize the criteria for review continuation.
But, if you think it merits further consideration, we
can certainly discuss!</div>
<div><br>
</div>
<div>Thanks,</div>
<div><br>
</div>
<div>Chip</div>
</div>
<div>
<div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Mon, Jan 7, 2013 at 10:11
AM, Mario Peshev <span dir="ltr"><<a href="mailto:mario@peshev.net" target="_blank">mario@peshev.net</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yes,
I know we partially do it already (given the two
examples of yours) but I think that it might be a
good practice to set a rule and extend this, let's
say (just as a sample) - up to 5 required and 10
recommended issues that apparently might be fixed
in a few hours, we give 48 hours (or 2 business
days) for the author to fix them, if not, the
ticket is closed and not approved.
<div>
<br>
I know that agencies, companies and teams with
resources spending their time completely in the
WordPress ecosystem could react and we could
speed up the process instead of getting the new
version on the next day and waiting for another
month and another close.</div>
<div><br>
Best,
<div><br clear="all">
<div><br>
Mario Peshev<br>
WordPress Engineer, Open Source Consultant<br>
<a href="http://www.linkedin.com/in/mpeshev" target="_blank">http://www.linkedin.com/in/mpeshev</a><br>
<div>
<a href="http://me.peshev.net/" target="_blank">http://me.peshev.net</a></div>
<div><br>
</div>
</div>
<br>
<br>
</div>
<div>
<div>
<div class="gmail_quote">On Mon, Jan 7, 2013
at 5:04 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Mario,
<div><br>
</div>
<div>I'm not sure I'm completely
following your question.</div>
<div><br>
</div>
<div>I'm talking specifically about
two cases:</div>
<div><br>
</div>
<div>
1. Where in the current ticket, the
reviewer says, "hey, I found these
one or two, really minor, but
required issues; I'm approving the
Theme, but please fix them in the
next revision"</div>
<div>2. Where in the current ticket,
the reviewer says, "hey, you missed
this required thing; please fix it
and re-submit. I'll hold your ticket
open so you don't have to wait in
line again"</div>
<div><br>
</div>
<div>Both of these things do help
expedite the process, and make it
less frustrating for the developer.
But, we have to make sure that we
verify that the *required* issues
identified in each case are resolved
in the subsequent ticket.</div>
<div><br>
</div>
<div>I *think* you're talking about
"holding open" tickets in general?
If so, that's not something that
we've really addressed. Might be
worth a discussion, perhaps?</div>
<div>
<br>
</div>
<div>Thanks,</div>
<div><br>
</div>
<div>Chip</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">
<div>
<div>On Mon, Jan 7, 2013 at 9:59
AM, Mario Peshev <span dir="ltr"><<a href="mailto:mario@peshev.net" target="_blank">mario@peshev.net</a>></span>
wrote:<br>
</div>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>Chip, isn't it 'good to
have' to keep tickets open? In
my opinion most themes need
approx. 3-4 iterations to get
in and given the stats, that
might take few months even
though fixes might take a few
hours.
<div>
<br>
</div>
<div>IMO theme authors that
prioritize theme submissions
should have a fast lane open
when the feedback could
apparently be resolved in a
few hours. This is in case
reviewers conduct a complete
review and not a quick look
only.<span><font color="#888888"><br clear="all">
<div><br>
Mario Peshev<br>
WordPress Engineer,
Open Source Consultant<br>
<a href="http://www.linkedin.com/in/mpeshev" target="_blank">http://www.linkedin.com/in/mpeshev</a><br>
<div><a href="http://me.peshev.net/" target="_blank">http://me.peshev.net</a></div>
<div><br>
</div>
</div>
</font></span>
<div>
<br>
<br>
<div class="gmail_quote">On
Mon, Jan 7, 2013 at 4:11
PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>This is
especially important
for previously
approved (Priority
#1) tickets, since
such tickets already
receive an
expedited, diff-only
review.</div>
<div><br>
</div>
<div>Two, we have a
great system in
place, that allows a
reviewer to hold a
ticket open if only
minor issues need to
be addressed, such
that once a revision
is submitted, the
reviewer can
continue the current
review in the new
ticket. If the
previous ticket is
still open, the new
ticket should be
left for the
reviewer of the
previous ticket, so
that the previous
review may be
continued.</div>
<div><br>
</div>
<div>I had two such
tickets over the
weekend: both had
previous-ticket
"required" issues
that were not
addressed. I left
the tickets open to
allow for a review
continuation. Both
developers uploaded
revisions, but when
I went in this
morning to take the
tickets, both had
been assigned,
reviewed, and
closed.šUnfortunately,
in both cases, the
review failed to
indicate whether
previous-ticket
"required" issues
had been addressed.</div>
</blockquote>
</div>
<br>
</div>
</div>
<br>
</div>
</div>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>