<HTML><HEAD></HEAD>
<BODY dir=ltr>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: 12pt">
<DIV>/agree</DIV>
<DIV> </DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV style="FONT: 10pt tahoma">
<DIV> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV style="font-color: black"><B>From:</B> <A title=chip@chipbennett.net
href="mailto:chip@chipbennett.net">Chip Bennett</A> </DIV>
<DIV><B>Sent:</B> Saturday, October 27, 2012 12:51 PM</DIV>
<DIV><B>To:</B> <A title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A>
</DIV>
<DIV><B>Subject:</B> Re: [theme-reviewers] pluggable functions</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">And
by contrast, making custom function return/output values filterable is as good
or better, depending on the circumstances. Depending on the amount/complexity of
that output/returned content, I would consider using custom filters to be better
practice than using pluggable functions.
<DIV> </DIV>
<DIV>Of course, that's why it is good to make *reocmmendations* in Theme reviews
at this point, rather than making *requirements* or "not-approving" Themes,
based on pluggable-vs-filterable functions.</DIV>
<DIV> </DIV>
<DIV>Chip<BR><BR>
<DIV class=gmail_quote>On Sat, Oct 27, 2012 at 2:46 PM, Philip M. Hofer (Frumph)
<SPAN dir=ltr><<A href="mailto:philip@frumph.net"
target=_blank>philip@frumph.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: 'Calibri'; FONT-SIZE: 12pt">
<DIV>Most functions being pluggable, i.e. function_exists (if that’s what
you’re referring to) is actually a good idea.</DIV>
<DIV> </DIV>
<DIV>This allows those functions to be re-written if necessary in the
functions.php of the child theme.</DIV>
<DIV> </DIV>
<DIV>I would consider this best practice.</DIV>
<DIV> </DIV>
<DIV> </DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV style="FONT: 10pt tahoma">
<DIV> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV><B>From:</B> <A title=chip@chipbennett.net
href="mailto:chip@chipbennett.net" target=_blank>Chip Bennett</A> </DIV>
<DIV><B>Sent:</B> Saturday, October 27, 2012 12:22 PM</DIV>
<DIV><B>To:</B> <A title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A> </DIV>
<DIV><B>Subject:</B> Re: [theme-reviewers] pluggable
functions</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV>
<DIV class=h5>Absent pre-existing guidelines, I would list your findings as
*recommended* only. It is always good to promote and to educate regarding best
practices, but we should only ever *not-approve* (even if "required fix in
next revision") those criteria that are stated in the guidelines.
<DIV> </DIV>
<DIV>(That said: feel free to propose guidelines revisions wrt pluggable vs.
filterable functions!)</DIV>
<DIV> </DIV>
<DIV>Thanks,</DIV>
<DIV> </DIV>
<DIV>Chip<BR><BR>
<DIV class=gmail_quote>On Sat, Oct 27, 2012 at 2:17 PM, Kirk Wight <SPAN
dir=ltr><<A href="mailto:kwight@kwight.ca"
target=_blank>kwight@kwight.ca</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>Howdy,
<DIV> </DIV>
<DIV>I'm reviewing a theme that has made all functions in functions.php
pluggable, including those on hooks. From what I understand, this won't
break anything, but doesn't feel very "best practice"-y (anything on a hook
can just be removed from the hook, making the pluggable code
un-necessary).</DIV>
<DIV> </DIV>
<DIV>The theme was already approved, but I prefer to encourage the best
practice; perhaps a "fix in next release" note is appropriate, rather than
blocking
approval?..</DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV></DIV></DIV>
<HR>
<DIV
class=im>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR></DIV></DIV></DIV></DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV>
<P>
<HR>
_______________________________________________<BR>theme-reviewers mailing
list<BR>theme-reviewers@lists.wordpress.org<BR>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR></DIV></DIV></DIV></BODY></HTML>