<HTML><HEAD><META content="text/html; charset=UTF-8" http-equiv="Content-Type"></HEAD><BODY>Yes, Philip is correct.<BR>
<BR>
This is how TwentyTwelve does it - http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentytwelve/functions.php#L168<BR>
<BR>
Philip M. Hofer (Frumph) wrote:<BR>
<blockquote type="cite"><BR>
That is precisely how to do it. But you should also return the <BR>
original $title being passed through the filter<BR>
<BR>
This is how I do it (not totally pretty), notice the check for the <BR>
feed if it is the feed it returns the original $title .. I probably <BR>
could have gotten away with just doing = .= with $title in the <BR>
!is_feed() section ;/<BR>
<BR>
function easel_filter_wp_title( $title ) {<BR>
global $wp_query, $s, $paged, $page;<BR>
if (!is_feed()) {<BR>
$sep = __('&raquo;','easel');<BR>
$new_title = get_bloginfo('name').' ';<BR>
$bloginfo_description = get_bloginfo('description');<BR>
if ((is_home () || is_front_page()) && !empty($bloginfo_description) <BR>
&& !$paged && !$page) {<BR>
$new_title .= $sep.' '.$bloginfo_description;<BR>
} elseif (is_single() || is_page()) {<BR>
$new_title .= $sep.' '.single_post_title('', false);<BR>
} elseif (is_search() ) {<BR>
$new_title .= $sep.' '.sprintf(__('Search Results: %s','easel'), <BR>
esc_html($s));<BR>
} else<BR>
$new_title .= $title;<BR>
if ( $paged || $page ) {<BR>
$new_title .= ' '.$sep.' '.sprintf(__('Page: %s','easel'),max( $paged, <BR>
$page ));<BR>
}<BR>
$title = $new_title;<BR>
}<BR>
return $title;<BR>
}<BR>
<BR>
add_filter( 'wp_title', 'easel_filter_wp_title' );<BR>
<BR>
-----Original Message----- From: esmi at quirm dot net<BR>
Sent: Wednesday, October 17, 2012 7:16 AM<BR>
To: theme-reviewers@lists.wordpress.org<BR>
Subject: [theme-reviewers] Usage of wp_title filter.<BR>
<BR>
I've just been reviewing the Codex page on the wp_title() filter:<BR>
<BR>
<http://codex.wordpress.org/Plugin_API/Filter_Reference/wp_title><BR>
<BR>
Specifically the example quoted as best practice. When I've tried to<BR>
implement that function, it generates a duplicated title in the RSS<BR>
feed. This can be circumvented by changing:<BR>
<BR>
return get_bloginfo( 'name' ) . $page_type . $title . $page_num;<BR>
<BR>
to:<BR>
<BR>
if( !is_feed() ) return get_bloginfo( 'name' ) . $page_type . $title .<BR>
$page_num;<BR>
<BR>
but I'm not 100% convinced that this is the proper usage of is_feed().<BR>
<BR>
Anyone care to comment before I amend the Codex page?<BR>
<BR>
Mel</BODY></HTML>