Ok so let me know what to do and I will do it. I would prefer keeping in mind the old wp versions but if you say you want only the last one this is what I will do.<br><br>Thanks :-)<br><br>Petar<br><br><div class="gmail_quote">
On Thu, Aug 23, 2012 at 11:49 AM, Bryan Hadaway <span dir="ltr"><<a href="mailto:bhadaway@gmail.com" target="_blank">bhadaway@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I remember now reading about it, here it is:<br><br><a href="http://codex.wordpress.org/Theme_Review#Code_Quality" target="_blank">http://codex.wordpress.org/Theme_Review#Code_Quality</a><br><br>So it's sort of a yes and no situation.<div class="im HOEnZb">
<br clear="all">
<br><br>Bryan Phillip Hadaway<br>
<div><span style="font-size:13.3px;font-family:Verdana,Arial,Helvetica,sans-serif"><div style="margin:0pt 0pt 8px"><p style="margin:0pt"><span style="color:rgb(46,45,46)"> <br> Web & Graphic Designer<br>
<a href="http://calmestghost.com/" target="_blank">calmestghost.com</a><br> <a href="mailto:bhadaway@gmail.com" target="_blank">bhadaway@gmail.com</a></span></p><p style="margin:0pt"><span style="color:rgb(46,45,46)"><br>
<b>Socialize:</b></span> <span style="font-size:13.3px;font-family:Verdana,Arial,Helvetica,sans-serif"><a href="http://www.facebook.com/calmestghost" target="_blank">Facebook</a> |</span><span style="font-size:13.3px;font-family:Verdana,Arial,Helvetica,sans-serif"> <a href="http://twitter.com/calmestghost" target="_blank">Twitter</a> </span><span style="font-size:13.3px;font-family:Verdana,Arial,Helvetica,sans-serif">| </span><a href="http://www.linkedin.com/in/calmestghost" target="_blank">LinkedIn</a> | <a href="https://plus.google.com/104582075016689917593" target="_blank">Google+</a></p>
</div></span></div>
<br>
<br><br></div><div class="HOEnZb"><div class="h5"><div class="gmail_quote">On Thu, Aug 23, 2012 at 1:14 AM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<font color="#333333"><font><font face="arial,helvetica,sans-serif">Many Themes, including Twenty Eleven use backward compatibility, this isn't anything out of the ordinary :) Not sure what the codes are and this is also something Otto would need to see as well.</font></font></font><div>
<font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">It's entirely up to you, to wait awhile or re-submit without them.<span><font color="#888888"><br>
</font></span></font><span><font color="#888888"><div>
<font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div></font></span><div><span><font color="#888888"><font color="#333333"><font><font face="arial,helvetica,sans-serif">Emil<br>
</font></font></font></font></span><div><div><br><div class="gmail_quote">
On Thu, Aug 23, 2012 at 3:02 AM, Petar Genev <span dir="ltr"><<a href="mailto:petar.genev@gmail.com" target="_blank">petar.genev@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br><br>Yes. If possible I'd like to support the 3.3. and 3.4 versions as well. If not I will move to the new functions and support the latest version of WP only.<br><br>Let me know how to proceed.<br><br>Thanks! :-)<br>
<br>Peter<div><div><br><br><div class="gmail_quote">On Thu, Aug 23, 2012 at 10:57 AM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<font color="#333333"><font><font face="arial,helvetica,sans-serif">Hi Petar,</font></font></font><div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">So this is for backward compatibility only, I would leave this for Otto (when time permits).</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Thanks,</font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Emil<br>
</font></font></font><br><div class="gmail_quote"><div><div>On Wed, Aug 22, 2012 at 11:26 PM, Petar Genev <span dir="ltr"><<a href="mailto:petar.genev@gmail.com" target="_blank">petar.genev@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
<div class="gmail_quote">Hi there,<br><br>I am trying to upload a theme via <a href="http://wordpress.org/extend/themes/upload/" target="_blank">http://wordpress.org/extend/themes/upload/</a><br>I get the following two errors:<br>
<ul><li><span>REQUIRED</span>: <b>add_contextual_help</b> found in the file <b>theme-options.php</b>. Deprecated since version <b>3.3</b>. Use <b>get_current_screen()->add_help_tab()</b> instead.</li>
<li><span>RECOMMENDED</span>: <b>get_current_theme</b> found in the file <b>theme-options.php</b>. Deprecated since version <b>3.4</b>. Use <b>wp_get_theme()</b> instead.</li>
</ul>I do not consider those two as errors because in the code I make an IF statement that checks if the new function exists and if it does not it would call the old one. This is how I make sure I use the new function if the wordpress installation is new version and use the old function on old wp installations. <br>
I can easily use only the new functions but then my theme will not work fine on old versions of WP which I'd like my theme to support. By old versions I mean 3.3 and 3.4.<br><br>For example:<br><?php $theme_name = function_exists( 'wp_get_theme' ) ? wp_get_theme() : get_current_theme(); ?><br>
<br>I think the theme checker finds the old function as a text in the codes and rises the errors without following the logic in the IF statements.<br><br><br><br>Please tell me what can I do so I can upload my theme?<span><font color="#888888"><span><font color="#888888"><br>
<br>
Petar<br>
</font></span></font></span></div><br>
<br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>