<HTML><HEAD></HEAD>
<BODY dir=ltr>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: 12pt">
<DIV>The tag is utilized on the wordpress repo. It is already a
known and used marker to denote a buddypress theme. </DIV>
<DIV> </DIV>
<DIV> </DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV style="FONT: 10pt tahoma">
<DIV> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV style="font-color: black"><B>From:</B> <A title=chip@chipbennett.net
href="mailto:chip@chipbennett.net">Chip Bennett</A> </DIV>
<DIV><B>Sent:</B> Friday, August 10, 2012 3:13 PM</DIV>
<DIV><B>To:</B> <A title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A>
</DIV>
<DIV><B>Subject:</B> Re: [theme-reviewers] BuddyPress
add_theme_support</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">I'm
I'm understanding Paul correctly, I would support the add_theme_support()
method. That seems to be the current "WordPress" way to register support for
various features.
<DIV> </DIV>
<DIV>I would be less confident in relying on the style.css Tags: header
tag.<BR><BR>
<DIV class=gmail_quote>On Fri, Aug 10, 2012 at 4:32 PM, Philip M. Hofer (Frumph)
<SPAN dir=ltr><<A href="mailto:philip@frumph.net"
target=_blank>philip@frumph.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV dir=ltr>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: 'Calibri'; FONT-SIZE: 12pt">
<DIV>You already have a buddypress tag, why not check if the tag exists and
use that instead of creating yet another entity ?</DIV>
<DIV> </DIV>
<DIV> </DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV style="FONT: 10pt tahoma">
<DIV> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV><B>From:</B> <A title=paul@byotos.com href="mailto:paul@byotos.com"
target=_blank>Paul Gibbs</A> </DIV>
<DIV><B>Sent:</B> Friday, August 10, 2012 2:29 PM</DIV>
<DIV><B>To:</B> <A title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A> </DIV>
<DIV><B>Subject:</B> Re: [theme-reviewers] BuddyPress
add_theme_support</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV>
<DIV class=h5>
<DIV>Let me explain a bit more, I think your advice would be appreciated.
</DIV>
<DIV> </DIV>
<DIV>Right now, BP's default theme does add_theme_support('buddypress'), but
we don't use it for anything. At a point in the future -- most probably 1.7,
our next major release -- we'll be implementing called a "theme compatibility
layer". If anyone knows how the templating in bbPress 2 works, it'll be almost
identical. For those who don't, in a nutshell, BP will ship with a very
lightweight very minimal set of templates. This is NOT a real theme. With some
voodoo magic, those template parts will allow BP to work on any WordPress
theme out of the box (just like bbPress).</DIV>
<DIV>
<DIV> </DIV>
<DIV>This is a pretty drastic change, so we will need to maintain backwards
compatibility with existing themes. There are nuances and edge-cases about how
we think we will do this, but excluding those for the sake of brevity, the
logic will work like this:</DIV>
<DIV> </DIV>
<DIV>
<UL>
<LI>If the theme or its parent does current_theme_supports('buddypress'), BP
will assume the theme has ALL of the templates -- and so won't load the
theme compatibility. <I>The theme is saying to BP, "don't worry, I've got
this covered".</I>
<LI>Otherwise, if certain BP-specific template files exist in the theme, we
will not load the theme compatibility. (for old/existing BP themes that
don't do add_theme_support).
<LI>Otherwise, the theme compatibility layer will be loaded.</LI></UL></DIV>
<DIV>Checking current_theme_supports is a nicer approach rather than checking
for the presences of template files in a theme, even if we cache the result of
the file_exists() call. This is my motivation for reaching out and seeing if
this could be added as a recommendation for BP theme reviews.</DIV>
<DIV> </DIV>-- <BR>Paul Gibbs
<DIV> </DIV></DIV>
<P style="COLOR: #a0a0a8">On Monday, 6 August 2012 at 16:57, George
Mamadashvili wrote:</P>
<BLOCKQUOTE
style="BORDER-LEFT: 1px solid; BORDER-RIGHT-WIDTH: 1px; PADDING-LEFT: 10px; BORDER-TOP-WIDTH: 1px; BORDER-BOTTOM-WIDTH: 1px; MARGIN-LEFT: 0px"
type="cite"><SPAN>
<DIV>
<DIV>I think BuddyPress theme changes are going to be implemented in 1.7,
here's more infor from Paul - <A
href="http://bpdevel.wordpress.com/2012/08/03/group-templates-in-buddypress-1-7/"
target=_blank>http://bpdevel.wordpress.com/2012/08/03/group-templates-in-buddypress-1-7/</A><BR><BR>
<DIV>On Mon, Aug 6, 2012 at 8:08 AM, Chip Bennett <SPAN dir=ltr><<A
href="mailto:chip@chipbennett.net"
target=_blank>chip@chipbennett.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE type="cite">
<DIV>Absolutely.
<DIV> </DIV>
<DIV>When do you anticipate this change? Is this something that can be
added to the WordPress 3.5-related guidelines revisions, or will we need
to implement sooner than that?</DIV>
<DIV> </DIV>
<DIV>Thanks,</DIV>
<DIV> </DIV>
<DIV>Chip<BR><BR>
<DIV>
<DIV>
<DIV>On Sun, Aug 5, 2012 at 11:00 PM, Paul Gibbs <SPAN dir=ltr><<A
href="mailto:paul@byotos.com" target=_blank>paul@byotos.com</A>></SPAN>
wrote:<BR></DIV></DIV>
<BLOCKQUOTE type="cite">
<DIV>
<DIV>
<DIV>
<DIV>Hi all, </DIV>
<DIV> </DIV>
<DIV>I'm one of the core developers on the BuddyPress plugin. Some
changes we have planned in the pipeline for BuddyPress will affect the
way BuddyPress interacts with themes. To help this, it would be ideal if
all BuddyPress themes on <A href="http://WordPress.org"
target=_blank>WordPress.org</A> had to have add_theme_support(
'buddypress' ) in its functions.php. Please could this be added as a
theme review mandatory requirement for BuddyPress themes?
</DIV><SPAN><FONT color=#888888>
<DIV> </DIV>
<DIV>-- <BR>Paul Gibbs
<DIV> </DIV></DIV></FONT></SPAN><BR></DIV></DIV>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></DIV></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></DIV></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV>
<DIV>
<DIV>_______________________________________________</DIV>
<DIV>theme-reviewers mailing list</DIV>
<DIV><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A></DIV>
<DIV><A href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A></DIV></DIV></DIV></SPAN></BLOCKQUOTE>
<DIV> </DIV></DIV></DIV>
<HR>
<DIV
class=im>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR></DIV></DIV></DIV></DIV></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV>
<DIV> </DIV></DIV>
<P>
<HR>
_______________________________________________<BR>theme-reviewers mailing
list<BR>theme-reviewers@lists.wordpress.org<BR>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR></DIV></DIV></DIV></BODY></HTML>