Most likely the new patch is correct, I'm not familiar off-hand with how TC is checking the template version.<br>The patch just expands on the existing core code using its structures and formats.<br><br><br clear="all">
Cais.<br>
<br><br><div class="gmail_quote">On Mon, Jul 9, 2012 at 3:22 PM, Simon Prosser <span dir="ltr"><<a href="mailto:pross@pross.org.uk" target="_blank">pross@pross.org.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Cais, your patch looks for TemplateVersion, but TC looks for Template<br>
Version is this intended? Which is the right one lol?<br>
<div class="HOEnZb"><div class="h5"><br>
On 9 July 2012 16:56, Edward Caissie <<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>> wrote:<br>
> PS: That really doesn't read right; I think I need more coffee.<br>
><br>
><br>
> Cais.<br>
><br>
><br>
><br>
> On Mon, Jul 9, 2012 at 11:55 AM, Edward Caissie <<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>><br>
> wrote:<br>
>><br>
>> I just read your comment. Thanks for the support ... and testing!<br>
>> Writing the code was easy enough but testing it out where I am right ...<br>
>> now not so much.<br>
>><br>
>><br>
>> Cais.<br>
>><br>
>><br>
>><br>
>> On Mon, Jul 9, 2012 at 11:47 AM, Amy Hendrix <<a href="mailto:sabreuse@gmail.com">sabreuse@gmail.com</a>> wrote:<br>
>>><br>
>>> Commented on the ticket. Thanks for updating!<br>
>>><br>
>>> On Mon, Jul 9, 2012 at 10:56 AM, Edward Caissie<br>
>>> <<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>> wrote:<br>
>>> > Alright ... updated patch added to ticket. Support (and testing) from<br>
>>> > the<br>
>>> > WPTRT would probably help to get this further along than what it has.<br>
>>> ><br>
>>> ><br>
>>> > Cais.<br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> > On Mon, Jul 9, 2012 at 10:45 AM, Edward Caissie<br>
>>> > <<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>><br>
>>> > wrote:<br>
>>> >><br>
>>> >> I think I have the new/updated patch ready ... I'll get it updated<br>
>>> >> shortly.<br>
>>> >><br>
>>> >><br>
>>> >> Cais.<br>
>>> >><br>
>>> >><br>
>>> >><br>
>>> >> On Mon, Jul 9, 2012 at 10:02 AM, Amy <<a href="mailto:sabreuse@gmail.com">sabreuse@gmail.com</a>> wrote:<br>
>>> >>><br>
>>> >>> Yeah, I hear you there!<br>
>>> >>><br>
>>> >>><br>
>>> >>> On Jul 9, 2012, at 9:37 AM, Edward Caissie <<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>><br>
>>> >>> wrote:<br>
>>> >>><br>
>>> >>> @Amy - I would have really liked to see version checking get in when<br>
>>> >>> I<br>
>>> >>> proposed it back at 3.1!?!<br>
>>> >>><br>
>>> >>> I'll try to get a look at this week though ...<br>
>>> >>><br>
>>> >>><br>
>>> >>> Cais.<br>
>>> >>><br>
>>> >>><br>
>>> >>> On Sun, Jul 8, 2012 at 2:49 PM, Amy Hendrix <<a href="mailto:sabreuse@gmail.com">sabreuse@gmail.com</a>><br>
>>> >>> wrote:<br>
>>> >>>><br>
>>> >>>> @Cais, I'd really (REALLY) like to see version-check get in to 3.5,<br>
>>> >>>> if<br>
>>> >>>> you're interested in updating the patch to work with WP_Theme. It<br>
>>> >>>> might be easier to get it in now while they're still closing random<br>
>>> >>>> small bugs, rather than waiting until after the scope has been set.<br>
>>> >>>><br>
>>> >>>> On Sun, Jul 8, 2012 at 10:36 AM, Edward Caissie<br>
>>> >>>> <<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>> wrote:<br>
>>> >>>> > @Emil - As Otto pointed out he was the first one to place a<br>
>>> >>>> > Child-Theme in<br>
>>> >>>> > the repository ... and the reason I was able to add the two I<br>
>>> >>>> > currently have<br>
>>> >>>> > there. Thanks.<br>
>>> >>>> ><br>
>>> >>>> > Also, I still need to get back to reviewing those patches. I<br>
>>> >>>> > believe<br>
>>> >>>> > the new<br>
>>> >>>> > WP_Theme class will affect how they might be implemented now.<br>
>>> >>>> > Otherwise,<br>
>>> >>>> > we're going to need more than "that's neat" to get the buy-in we<br>
>>> >>>> > need<br>
>>> >>>> > from<br>
>>> >>>> > the devs to have them committed.<br>
>>> >>>> ><br>
>>> >>>> ><br>
>>> >>>> > Cais.<br>
>>> >>>> ><br>
>>> >>>> ><br>
>>> >>>> ><br>
>>> >>>> > On Sun, Jul 8, 2012 at 2:07 AM, Emil Uzelac <<a href="mailto:emil@themeid.com">emil@themeid.com</a>><br>
>>> >>>> > wrote:<br>
>>> >>>> >><br>
>>> >>>> >> Color is fantastic, great choice for sure. Oh sorry I didn't know<br>
>>> >>>> >> about<br>
>>> >>>> >> that. Cool now we know.<br>
>>> >>>> >><br>
>>> >>>> >> I wasn't aware of the button at all and it's very useful.<br>
>>> >>>> >><br>
>>> >>>> >> Emil<br>
>>> >>>> >><br>
>>> >>>> >> On Sun, Jul 8, 2012 at 12:52 AM, Otto <<a href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</a>><br>
>>> >>>> >> wrote:<br>
>>> >>>> >>><br>
>>> >>>> >>> On Sun, Jul 8, 2012 at 12:45 AM, Emil Uzelac <<a href="mailto:emil@themeid.com">emil@themeid.com</a>><br>
>>> >>>> >>> wrote:<br>
>>> >>>> >>> > P.S. Cais is the very first author with the Child Theme in<br>
>>> >>>> >>> > repository<br>
>>> >>>> >>> > as<br>
>>> >>>> >>> > well.<br>
>>> >>>> >>><br>
>>> >>>> >>> Actually, that would be me, via Matt's account. :)<br>
>>> >>>> >>><br>
>>> >>>> >>> The first child theme in was<br>
>>> >>>> >>> <a href="http://wordpress.org/extend/themes/mazeld" target="_blank">http://wordpress.org/extend/themes/mazeld</a>, because I was testing<br>
>>> >>>> >>> things. It is.. not a good example to learn from. I was new to<br>
>>> >>>> >>> .org.<br>
>>> >>>> >>> Sorry. :(<br>
>>> >>>> >>><br>
>>> >>>> >>> I'll fix it up and make it not so horrible, one of these days.<br>
>>> >>>> >>> The<br>
>>> >>>> >>> random image thing in the header is kinda neat though. So, you<br>
>>> >>>> >>> know,<br>
>>> >>>> >>> there is that. ;)<br>
>>> >>>> >>><br>
>>> >>>> >>> -Otto<br>
>>> >>>> >>> _______________________________________________<br>
>>> >>>> >>> theme-reviewers mailing list<br>
>>> >>>> >>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> >>>> >>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>> >>>> >><br>
>>> >>>> >><br>
>>> >>>> >><br>
>>> >>>> >> _______________________________________________<br>
>>> >>>> >> theme-reviewers mailing list<br>
>>> >>>> >> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> >>>> >> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>> >>>> >><br>
>>> >>>> ><br>
>>> >>>> ><br>
>>> >>>> > _______________________________________________<br>
>>> >>>> > theme-reviewers mailing list<br>
>>> >>>> > <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> >>>> > <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>> >>>> ><br>
>>> >>>> _______________________________________________<br>
>>> >>>> theme-reviewers mailing list<br>
>>> >>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> >>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>> >>><br>
>>> >>><br>
>>> >>> _______________________________________________<br>
>>> >>> theme-reviewers mailing list<br>
>>> >>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> >>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>> >>><br>
>>> >>><br>
>>> >>> _______________________________________________<br>
>>> >>> theme-reviewers mailing list<br>
>>> >>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> >>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>> >>><br>
>>> >><br>
>>> ><br>
>>> ><br>
>>> > _______________________________________________<br>
>>> > theme-reviewers mailing list<br>
>>> > <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> > <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>> ><br>
>>> _______________________________________________<br>
>>> theme-reviewers mailing list<br>
>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> theme-reviewers mailing list<br>
> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
My Blog: <a href="http://pross.org.uk/" target="_blank">http://pross.org.uk/</a><br>
Plugins : <a href="http://pross.org.uk/plugins/" target="_blank">http://pross.org.uk/plugins/</a><br>
Themes: <a href="http://wordpress.org/extend/themes/profile/pross" target="_blank">http://wordpress.org/extend/themes/profile/pross</a><br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br>