Here's the rub ...<br><br>While its all well and good if the Parent-Theme implements the add_theme_support( 'custom-background' ) with default parameters set to some value but this then requires the Child-Theme must implement the same functionality if the background is to be anything other than the Parent-Theme's default (as noted by Philip).<br>
<br>Again this is not really an issue for *new* Child-Themes but it will be an issue for existing Child-Themes ... how many installations will this affect? Unknown, but it also the reason why I advocated existing themes that implement the add_theme_support( 'custom-background' ) do so with no default $args being set so as not to "break" existing (and quite likely unknown) Child-Themes.<br>
<br>Perhaps this falls into more of a PSA when using this feature, as it's not really a bug ... or is it?!<br><br><br clear="all">Cais.<br>
<br><br><div class="gmail_quote">On Mon, Jun 11, 2012 at 3:20 PM, Philip M. Hofer (Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
While I see what you're saying, and it's very valid. It is not the behavior that would be the most beneficial to creators.<br>
<br>
Keeping that in mind. What do we do about child themes and defaults. Something should be written up explaining the "if defaults set in parent then all child themes must use defaults" or it won't work.<br>
<br>
<br>
<br>
-----Original Message----- From: Otto<br>
Sent: Monday, June 11, 2012 12:10 PM<div class="im HOEnZb"><br>
To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br>
Subject: Re: [theme-reviewers] Something we need to check for 3.4 appearance -> background<br>
<br></div><div class="HOEnZb"><div class="h5">
On Mon, Jun 11, 2012 at 2:05 PM, Philip M. Hofer (Frumph)<br>
<<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The simple thing about it is, if a custom background image and color is not<br>
used, then the CSS for it for custom-background and the class should not<br>
exist.<br>
</blockquote>
<br>
False, entirely. If the custom background is defined in the them, then<br>
it's *always* used. A "no-background" selection is a perfectly valid<br>
selection by the *user* of the theme.<br>
<br>
If your method was used, then the user of the theme would have no way<br>
to use the custom background functionality to select "no background".<br>
Removing the class would allow the theme's CSS to come through<br>
instead. That is not the desired outcome.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Whatever default in the style.css of either the parent or child is<br>
inconsequential and up to the designer. Not the core.<br>
</blockquote>
<br>
If the theme defines custom-backgrounds to be used (remember, this is<br>
off by default, a theme must support custom backgrounds), then the<br>
theme should not be defining any "defaults" in the style.css at all.<br>
It's supporting custom backgrounds, it should have the defaults in<br>
that custom background support call.<br>
<br>
-Otto<br>
______________________________<u></u>_________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/<u></u>mailman/listinfo/theme-<u></u>reviewers</a> <br>
______________________________<u></u>_________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/<u></u>mailman/listinfo/theme-<u></u>reviewers</a><br>
</div></div></blockquote></div><br>