<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Hm. I thought:</div><div><br></div><div>Themes are <b>required</b> to enqueue all stylesheets and scripts, using <tt><a href="http://codex.wordpress.org/Function_Reference/wp_enqueue_style" title="Function Reference/wp enqueue style">wp_enqueue_style()</a></tt>/<tt><a href="http://codex.wordpress.org/Function_Reference/wp_enqueue_script" title="Function Reference/wp enqueue script">wp_enqueue_script()</a></tt>,
and hooked into an appropriate hook via callback function, rather than
hard-coding stylesheet/script links or tags in the template.</div><div>Themes may <b>optionally</b> link the default stylesheet (<tt>style.css</tt>) directly in the document head, or via <tt>wp_enqueue_style()</tt> </div><div><br></div><div>Konstantin</div><br><div><div>On 08.06.2012, at 16:18, Philip M. Hofer (Frumph) wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<div style="WORD-WRAP: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space" dir="ltr">
<div dir="ltr">
<div style="FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: 12pt">
<div>“is what is wrong” .. heh not what is required</div>
<div> </div>
<div style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<div style="FONT: 10pt tahoma">
<div> </div>
<div style="BACKGROUND: #f5f5f5">
<div style="font-color: black"><b>From:</b> <a title="philip@frumph.net" href="mailto:philip@frumph.net">Philip M. Hofer (Frumph)</a> </div>
<div><b>Sent:</b> Friday, June 08, 2012 7:16 AM</div>
<div><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a>
</div>
<div><b>Subject:</b> Re: [theme-reviewers] (no subject)</div></div></div>
<div> </div></div>
<div style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<div dir="ltr">
<div style="FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: 12pt">
<div>I’m not going to argue with “good practices”, not even sure why this
gentlemen’s theme even enqueue’s the style.css to begin with and doesn’t just
add it to the header.php like everyone else ;/</div>
<div> </div>
<div>Enqueue’ing that style.css makes things sort of run ‘out of execution’
order. </div>
<div> </div>
<div>Anyways, what was written is not what is the actual root of what is
wrong.</div>
<div> </div>
<div>“If incorporated into the Theme, site information is <b>required</b> to be
called using the correct template tag:”</div>
<div> </div>
<div>This is actually referring to the fact that enqueue’ing the stylesheet_uri
is what is required, by not enqueing it and putting it in the appropriate
location in the header.php.</div>
<div> </div>
<div>However, what is written as a requirement is the difference between the
get_stylesheet_directory_uri and get_stylesheet_uri</div>
<div> </div>
<div>Hope this makes sense.</div>
<div> </div>
<div>Theme’s Style.CSS should be called appropriately from the header.php and
incorporated with the proper get_stylesheet_uri();</div>
<div> </div>
<div> </div>
<div style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<div style="FONT: 10pt tahoma">
<div><font size="3" face="Calibri"></font> </div>
<div style="BACKGROUND: #f5f5f5">
<div style="font-color: black"><b>From:</b> <a title="konstantin@obenland.it" href="mailto:konstantin@obenland.it">Konstantin Obenland</a> </div>
<div><b>Sent:</b> Friday, June 08, 2012 7:07 AM</div>
<div><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a>
</div>
<div><b>Subject:</b> Re: [theme-reviewers] (no subject)</div></div></div>
<div> </div></div>
<div style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">I
wasn't aware.
<div> </div>
<div>This is what my finding was based on:</div>
<div> </div>
<div>If incorporated into the Theme, site information is <b>required</b> to be
called using the correct template tag:</div>
<div>[...]</div>
<div>Style Sheet URL: <tt><a title="Function Reference/get stylesheet uri" href="http://codex.wordpress.org/Function_Reference/get_stylesheet_uri">get_stylesheet_uri()</a></tt></div>
<div><font class="Apple-style-span" face="monospace"><br></font>
<div>I was under the impression, when it is required to use get_stylesheet_uri()
to get the stylesheet url, get_stylesheet_directory_uri() . '/style.css'
actually is no good.<br>
<div>Wasn't the reason behind requiring get_stylesheet_uri(), that the
'stylesheet_uri' filter gets called?</div>
<div> </div>
<div>Konstantin</div>
<div> </div>
<div>
<div>On 08.06.2012, at 16:01, Philip M. Hofer (Frumph) wrote:</div><br class="Apple-interchange-newline">
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">
<div style="FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: 12pt">
<div>^ thanks chip – also if you could:</div>
<div> </div>
<div>might want to edit the doc for *_uri() / *_url() .. although
I don’t know any functions off the top of my head that have _url()</div>
<div style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<div style="FONT: 10pt tahoma">
<div><font size="3" face="Calibri"></font> </div>
<div><font size="3" face="Calibri"></font> </div>
<div style="BACKGROUND: #f5f5f5">
<div style="font-color: black"><b>From:</b> <a title="chip@chipbennett.net" href="mailto:chip@chipbennett.net">Chip Bennett</a> </div>
<div><b>Sent:</b> Friday, June 08, 2012 6:56 AM</div>
<div><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a>
</div>
<div><b>Subject:</b> Re: [theme-reviewers] (no subject)</div></div></div>
<div> </div></div>
<div style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">I
agree with Phil.
<div> </div>
<div>This statement is not in the Guidelines:</div>
<div> </div>
<div>
<blockquote style="BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0px; MARGIN: 0px 0px 0px 40px; PADDING-LEFT: 0px; PADDING-RIGHT: 0px; BORDER-TOP: medium none; BORDER-RIGHT: medium none; PADDING-TOP: 0px">
<div><font style="FONT-SIZE: 16px" face="Times New Roman">Site information
is REQUIRED to be called using the correct template tag: </font><tt style="FONT-SIZE: 16px">get_stylesheet_uri()</tt><font style="FONT-SIZE: 16px" face="Times New Roman"> rather than </font><tt style="FONT-SIZE: 16px">get_stylesheet_directory_uri() .
'/style.css'</tt></div></blockquote></div>
<div> </div>
<div>What IS in the Guidelines is this:</div>
<div> </div>
<div>
<blockquote style="BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0px; MARGIN: 0px 0px 0px 40px; PADDING-LEFT: 0px; PADDING-RIGHT: 0px; BORDER-TOP: medium none; BORDER-RIGHT: medium none; PADDING-TOP: 0px">
<div><span style="TEXT-ALIGN: left; LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-FAMILY: sans-serif; FONT-SIZE: 13px">Themes
are </span><b style="TEXT-ALIGN: left; LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-FAMILY: sans-serif; FONT-SIZE: 13px">required</b><span style="TEXT-ALIGN: left; LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-FAMILY: sans-serif; FONT-SIZE: 13px">
to use </span><tt style="TEXT-ALIGN: left; LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-SIZE: 13px">*_url()</tt><span style="TEXT-ALIGN: left; LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-FAMILY: sans-serif; FONT-SIZE: 13px">
template tags, rather than </span><tt style="TEXT-ALIGN: left; LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-SIZE: 13px">bloginfo()</tt><span style="TEXT-ALIGN: left; LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-FAMILY: sans-serif; FONT-SIZE: 13px">
equivalents.</span></div>
<div style="TEXT-ALIGN: left"><font face="sans-serif"><span style="LINE-HEIGHT: 22px">AND</span></font></div>
<div style="TEXT-ALIGN: left"><span style="LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-FAMILY: sans-serif; FONT-SIZE: 13px">Themes
are </span><b style="LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-FAMILY: sans-serif; FONT-SIZE: 13px">required</b><span style="LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-FAMILY: sans-serif; FONT-SIZE: 13px">
to use </span><tt style="LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-SIZE: 13px"><a style="COLOR: rgb(76,166,207); TEXT-DECORATION: none" title="Function Reference/get stylesheet directory" href="http://codex.wordpress.org/Function_Reference/get_stylesheet_directory">get_stylesheet_directory()</a></tt><span style="LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-FAMILY: sans-serif; FONT-SIZE: 13px">
rather than </span><tt style="LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-SIZE: 13px">STYLESHEETPATH</tt><span style="LINE-HEIGHT: 22px; BACKGROUND-COLOR: rgb(255,255,255); FONT-FAMILY: sans-serif; FONT-SIZE: 13px">
to return the stylesheet path.</span></div></blockquote></div>
<div> </div>
<div>The important points:</div>
<div>
<ul>
<li>Use get_stylesheet_directory() instead of the STYLESHEETPATH constant
</li><li>Use get_stylesheet_directory*() instead of its get_bloginfo() equivalent
</li><li>Use get_stylesheet_directory*() instead of get_template_directory*()
when the included path is intended to be able to be overridden by a Child
Theme</li></ul></div>
<div> </div>
<div>Chip<br><br>
<div class="gmail_quote">On Fri, Jun 8, 2012 at 8:44 AM, Philip M. Hofer
(Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">
<div dir="ltr">
<div dir="ltr">
<div style="FONT-FAMILY: 'Calibri'; FONT-SIZE: 12pt">
<div>Okay this is a little bit out of hand.</div>
<div> </div>
<div>^ reference </div>
<div> </div>
<div><font face="Times New Roman">Site information is REQUIRED to be called
using the correct template tag: </font><tt>get_stylesheet_uri()</tt><font face="Times New Roman"> rather than
</font><tt>get_stylesheet_directory_uri() . '/style.css'</tt></div>
<div><tt></tt> </div>
<div><tt></tt> </div>
<div><tt>^ Both are internal functions that do the EXACT same
thing:</tt></div>
<div><tt></tt> </div>
<div><tt>Case:</tt></div>
<div><tt></tt> </div>
<div>function get_stylesheet_uri() {</div>
<div> $stylesheet_dir_uri =
get_stylesheet_directory_uri();</div>
<div> $stylesheet_uri = $stylesheet_dir_uri .
'/style.css';</div>
<div> return apply_filters('stylesheet_uri',
$stylesheet_uri, $stylesheet_dir_uri);</div>
<div>}</div>
<div> </div>
<div>This is not a reason to invalidate a theme. Neither is adding
remaining parameters on a completely valid function call.</div>
<div> </div>
<div> </div>
<div style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<div style="FONT: 10pt tahoma">
<div><font size="3" face="Calibri"></font> </div>
<div style="BACKGROUND: #f5f5f5">
<div><b>From:</b> <a title="georgemamadashvili@gmail.com" href="mailto:georgemamadashvili@gmail.com" target="_blank">George
Mamadashvili</a> </div>
<div><b>Sent:</b> Friday, June 08, 2012 5:43 AM</div>
<div><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a> </div>
<div><b>Subject:</b> Re: [theme-reviewers] (no subject)</div></div></div>
<div> </div></div>
<div style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<div>
<div class="h5">Use more simple solution - wp_enqueue_style(
'krakatau-style', get_stylesheet_uri() );
<div> </div>
<div>You need to use get_stylesheet_* functions when enqueueing style.css so
child themes can easily override it.<br><br>
<div class="gmail_quote">On Fri, Jun 8, 2012 at 2:39 PM, hal-android <span dir="ltr"><<a href="mailto:hasilent00@gmail.com" target="_blank">hasilent00@gmail.com</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">Hi.<br>Can anyone help me here?<br>I'm really confused
about this.<br>In the previous ticket :<br><a href="http://themes.trac.wordpress.org/ticket/8039" target="_blank">http://themes.trac.wordpress.org/ticket/8039</a><br>wp_register_style('default',
get_stylesheet_directory_uri() .<br>'/style.css', array(),
'0.0.3');<br>wp_enqueue_style('default');<br><br><br>And on this ticket I
replace<br><a href="http://themes.trac.wordpress.org/ticket/8069#comment:3" target="_blank">http://themes.trac.wordpress.org/ticket/8069#comment:3</a><br><br>wp_enqueue_style('krakatau_style',
get_template_directory_uri() .<br>'/style.css', array(),
'0.0.5');<br><br><br>Please help me..what should i do?<br><br>Many
thank's<br>amdhas<br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br></blockquote></div>
<div> </div></div></div></div>
<hr>
<div class="im">_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br></div></div></div></div></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br><br></blockquote></div>
<div> </div></div>
<div> </div>
<hr>
_______________________________________________<br>theme-reviewers mailing
list<br><a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br></div></div></div></div>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br></blockquote></div>
<div> </div></div></div><div>
<br class="webkit-block-placeholder"></div><hr>
_______________________________________________<br>theme-reviewers mailing
list<br><a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<br></div></div></div><div>
<br class="webkit-block-placeholder"></div><hr>
_______________________________________________<br>theme-reviewers mailing
list<br><a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<br></div></div></div></div>
_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<br></blockquote></div><br></body></html>