<font color="#333333"><font><font face="arial,helvetica,sans-serif">Would it be too much to ask to keep this in: <a href="http://themes.trac.wordpress.org/ticket/8055">http://themes.trac.wordpress.org/ticket/8055</a> and ask reviewer directly?</font></font></font><div>
<font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Thanks,</font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Emil<br>
</font></font></font><br><div class="gmail_quote">On Thu, Jun 7, 2012 at 2:03 AM, Daniel Fenn <span dir="ltr"><<a href="mailto:danielx386@gmail.com" target="_blank">danielx386@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Agreed<br>
<div class="im"><br>
On 6/7/12, jay Cauvain <<a href="mailto:wp@stormfire.me">wp@stormfire.me</a>> wrote:<br>
> Wouldn't it just be simpler to amend the issue rather than argue about it?<br>
> because I can see exactly where this is headed.<br>
> On Jun 7, 2012 7:12 AM, "Gazpo Themes" <<a href="mailto:themes@gazpo.com">themes@gazpo.com</a>> wrote:<br>
><br>
>> So how does theme reviews work? Don't they have same rule for everyone?<br>
>> Even the themes accepted on 4th june are using same code and being<br>
>> accepted<br>
>> and I am being rejected for the very same reason?<br>
>><br>
>> Sami.<br>
>><br>
>><br>
>> On Thu, Jun 7, 2012 at 9:02 AM, Konstantin Obenland <<br>
>> <a href="mailto:konstantin@obenland.it">konstantin@obenland.it</a>> wrote:<br>
>><br>
>>> The problem is that the output is not filterable in its entirety, and<br>
>>> Plugins can't modify it.<br>
>>><br>
>>> The<br>
</div>>>> requirement<<a href="http://codex.wordpress.org/Theme_Review#Function_Parameters.2C_Filters.2C_and_Action_Hooks" target="_blank">http://codex.wordpress.org/Theme_Review#Function_Parameters.2C_Filters.2C_and_Action_Hooks</a>><br>
>>> is<br>
>>> pretty clear on this: "wp_title(): Themes are *required* to modify<br>
<div class="im">>>> output via filter (wp_title)"<br>
>>><br>
>>> So no, the way Twenty Eleven and countless other Themes do it is not<br>
>>> correct, as frumph pointed out.<br>
>>> The example Cais gave earlier is great, as is Chip's on<br>
</div>>>> StackExchange<<a href="http://wordpress.stackexchange.com/questions/32622/when-calling-wp-title-do-you-have-to-create-some-kind-of-title-php-file" target="_blank">http://wordpress.stackexchange.com/questions/32622/when-calling-wp-title-do-you-have-to-create-some-kind-of-title-php-file</a>><br>
<div><div class="h5">>>> .<br>
>>><br>
>>> Konstantin<br>
>>><br>
>>><br>
>>> On 07.06.2012, at 07:26, Gazpo Themes wrote:<br>
>>><br>
>>> I am still confused, most of the recently accepted themes are using<br>
>>> following code. I have used exactly same but theme reviewer is not<br>
>>> accepting mine. What's the problem with it?<br>
>>><br>
>>> <title><?php<br>
>>> global $page, $paged;<br>
>>> wp_title( '|', true, 'right' );<br>
>>> bloginfo( 'name' );<br>
>>><br>
>>> $site_description = get_bloginfo( 'description', 'display' );<br>
>>> if ( $site_description && ( is_home() || is_front_page() ) )<br>
>>> echo " | $site_description";<br>
>>><br>
>>> if ( $paged >= 2 || $page >= 2 )<br>
>>> echo ' | ' . sprintf( __( 'Page %s', 'silverorchid' ), max(<br>
>>> $paged, $page ) );<br>
>>><br>
>>> ?></title><br>
>>><br>
>>> Thanks.<br>
>>> Sami.<br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> On Thu, Jun 7, 2012 at 3:11 AM, Edward Caissie<br>
>>> <<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>>wrote:<br>
>>><br>
>>>> Yes, there is some confusion here ...<br>
>>>><br>
>>>> 1. The use of the template tag `wp_title` is expected; but,<br>
>>>> 2. `wp_title` is expected to be use "correctly" as well.<br>
>>>><br>
>>>> Essentially, after varied discussions and input from several people, it<br>
>>>> was decided the correct / best practice method of using the template<br>
>>>> tag<br>
>>>> was to initially use the standard parameters then filter any<br>
>>>> "decorative"<br>
>>>> text, etc. into it afterward. The example in TwentyEleven works but<br>
>>>> could<br>
>>>> be improved upon to maintain the extensibility of the `wp_title`<br>
>>>> template<br>
>>>> tag.<br>
>>>><br>
>>>> As an example from Desk Mess Mirrored, which generates a very similar<br>
>>>> output to TwentyEleven (and TwentyTen) see the following code:<br>
>>>><br>
>>>> Use `<?php wp_title( '|', true, 'right' ); ?>` in the header.php<br>
>>>> template; and,<br>
>>>><br>
>>>> Use something similar to the following as the filtered function:<br>
>>>><br>
>>>> `<?php<br>
>>>> /**<br>
>>>> * Use as filter input<br>
>>>> *<br>
>>>> * @param string $old_title - default title text<br>
>>>> * @param string $sep - separator character<br>
>>>> * @param string $sep_location - left|right - separator<br>
>>>> placement in relationship to title<br>
>>>> *<br>
>>>> * @return string - new title text<br>
>>>> */<br>
>>>> function dmm_wp_title( $old_title, $sep, $sep_location ) {<br>
>>>> global $page, $paged;<br>
>>>> /** Set initial title text */<br>
>>>> $dmm_title_text = $old_title . get_bloginfo( 'name' );<br>
>>>> /** Add wrapping spaces to separator character */<br>
>>>> $sep = ' ' . $sep . ' ';<br>
>>>><br>
>>>> /** Add the blog description (tagline) for the home/front<br>
>>>> page */<br>
>>>> $site_tagline = get_bloginfo( 'description', 'display' );<br>
>>>> if ( $site_tagline && ( is_home() || is_front_page() ) )<br>
>>>> $dmm_title_text .= "$sep$site_tagline";<br>
>>>><br>
>>>> /** Add a page number if necessary */<br>
>>>><br>
>>>> if ( $paged >= 2 || $page >= 2 )<br>
>>>> $dmm_title_text .= $sep . sprintf( __( 'Page %s',<br>
>>>> 'desk-mess-mirrored' ), max( $paged, $page ) );<br>
>>>><br>
>>>> return $dmm_title_text;<br>
>>>> }<br>
>>>> add_filter( 'wp_title', 'dmm_wp_title', 10, 3 );<br>
>>>> ?>`<br>
>>>><br>
>>>> Again, this is only a (working) example, and it is not a definitive<br>
>>>> requirement that themes do this explicitly; but, it will make plugin<br>
>>>> authors much happier and your end-users as well, especially those that<br>
>>>> use<br>
>>>> SEO plugins which typically hook into the `wp_title` template tag.<br>
>>>><br>
>>>> Hope that makes some sense of the issue ...<br>
>>>><br>
>>>><br>
>>>> Cais.<br>
>>>><br>
>>>><br>
>>>><br>
>>>> On Wed, Jun 6, 2012 at 6:39 PM, Kirk Wight <<a href="mailto:kwight@kwight.ca">kwight@kwight.ca</a>> wrote:<br>
>>>><br>
>>>>> I think the confusion is in terminology. There are both a wp_title<br>
>>>>> filter and a wp_title template tag; the requirement refers to the<br>
>>>>> template<br>
>>>>> tag which, if taken as-is from Twenty Eleven, should be fine.<br>
>>>>><br>
>>>>><br>
>>>>> On 6 June 2012 16:08, Philip M. Hofer (Frumph)<br>
>>>>> <<a href="mailto:philip@frumph.net">philip@frumph.net</a>>wrote:<br>
>>>>><br>
>>>>>> This one is new to me, the reference is here:<br>
>>>>>><br>
>>>>>> <a href="http://codex.wordpress.org/Theme_Review#Required_Hooks_and_Navigation" target="_blank">http://codex.wordpress.org/Theme_Review#Required_Hooks_and_Navigation</a><br>
>>>>>><br>
>>>>>> apply_filters(‘wp_title is found in wp-includes/general-template.php<br>
>>>>>><br>
>>>>>> It determines what the title is supposed to output, however it<br>
>>>>>> doesn’t do everything that people want it to, in most cases it<br>
>>>>>> doesn’t<br>
>>>>>> output the bloginfo appropriately on the home page that is specific<br>
>>>>>> for the<br>
>>>>>> theme.<br>
>>>>>><br>
>>>>>> It’s not that the codex is wrong at being a requirement, it’s more<br>
>>>>>> so that the current standards do not have enough documentation and<br>
>>>>>> core<br>
>>>>>> automatic themes are not utilizing the filter appropriately.<br>
>>>>>><br>
>>>>>> Example twentyeleven theme:<br>
>>>>>><br>
>>>>>> <title><?php<br>
>>>>>> /*<br>
>>>>>> * Print the <title> tag based on what is being viewed.<br>
>>>>>> */<br>
>>>>>> global $page, $paged;<br>
>>>>>><br>
>>>>>> wp_title( '|', true, 'right' );<br>
>>>>>><br>
>>>>>> // Add the blog name.<br>
>>>>>> bloginfo( 'name' );<br>
>>>>>><br>
>>>>>> // Add the blog description for the home/front page.<br>
>>>>>> $site_description = get_bloginfo( 'description', 'display' );<br>
>>>>>> if ( $site_description && ( is_home() || is_front_page() ) )<br>
>>>>>> echo " | $site_description";<br>
>>>>>><br>
>>>>>> // Add a page number if necessary:<br>
>>>>>> if ( $paged >= 2 || $page >= 2 )<br>
>>>>>> echo ' | ' . sprintf( __( 'Page %s', 'twentyeleven' ), max(<br>
>>>>>> $paged, $page ) );<br>
>>>>>><br>
>>>>>> ?></title><br>
>>>>>><br>
>>>>>> This could actually be written as such:<br>
>>>>>><br>
>>>>>> add_filter(‘wp_title’, ‘twentyeleven_wp_title’);<br>
>>>>>><br>
>>>>>> function twentyeleven_wp_title($title) {<br>
>>>>>> global $wp_query, $paged, $page;<br>
>>>>>> // add the blog name.<br>
>>>>>> $title .= get_bloginfo(‘name’);<br>
>>>>>> // Add the blog description for the home/front page.<br>
>>>>>> $site_description = get_bloginfo( 'description', 'display' );<br>
>>>>>> if ( $site_description && ( is_home() || is_front_page() ) )<br>
>>>>>> $title .= " | $site_description";<br>
>>>>>> // add a page number if necessary<br>
>>>>>> // Add a page number if necessary:<br>
>>>>>> if ( $paged >= 2 || $page >= 2 )<br>
>>>>>> $title .= ' | ' . _x( 'Page %s', 'twentyeleven' ), max(<br>
>>>>>> $paged, $page ) ;<br>
>>>>>> return $title;<br>
>>>>>> }<br>
>>>>>><br>
>>>>>> ^ little unsure of the _x( part and I’m doing this from memory.<br>
>>>>>><br>
>>>>>> But the biggest issue probably is lack of documentation to make that<br>
>>>>>> a<br>
>>>>>> requirement and people in the know not using it.<br>
>>>>>><br>
>>>>>> However, as you can see. It *should* be done this way.<br>
>>>>>><br>
>>>>>> So the end result would be:<br>
>>>>>><br>
>>>>>> <title><?php wp_title( ‘|’, true, ‘right’); ?></title><br>
>>>>>><br>
>>>>>> ^^ Now, the problem will be the output. Someone else want to<br>
>>>>>> chime in on if this is correct?<br>
>>>>>><br>
>>>>>> - Phil<br>
>>>>>><br>
</div></div>>>>>>> *From:* Gazpo Themes <<a href="mailto:themes@gazpo.com">themes@gazpo.com</a>><br>
>>>>>> *Sent:* Wednesday, June 06, 2012 12:52 PM<br>
>>>>>> *To:* <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>>>> *Subject:* [theme-reviewers] Ticket #8055: Need help.<br>
<div class="im">>>>>>><br>
>>>>>> Hello,<br>
>>>>>> I need help about my theme ticket (<br>
>>>>>> <a href="http://themes.trac.wordpress.org/ticket/8055" target="_blank">http://themes.trac.wordpress.org/ticket/8055</a>)<br>
>>>>>><br>
>>>>>> The theme reviewer has suggested: 'Themes must use wp_title filter.'<br>
>>>>>> I have used the wp_title from the twenty eleven theme, and I can see<br>
>>>>>> that it works fine. Can someone tell me what's wrong with it?<br>
>>>>>><br>
>>>>>> Also about the header banner, it is by default linked to the local<br>
>>>>>> site where it will be installed. I really can't see where the problem<br>
>>>>>> is.<br>
>>>>>><br>
>>>>>> Can someone please tell me about above issues, I will highly<br>
>>>>>> appreciate.<br>
>>>>>><br>
>>>>>> Thanks.<br>
>>>>>> Sami.<br>
>>>>>><br>
</div>>>>>>> ------------------------------<br>
<div class="HOEnZb"><div class="h5">>>>>>> _______________________________________________<br>
>>>>>> theme-reviewers mailing list<br>
>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>>><br>
>>>>>><br>
>>>>>> _______________________________________________<br>
>>>>>> theme-reviewers mailing list<br>
>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>>><br>
>>>>>><br>
>>>>><br>
>>>>> _______________________________________________<br>
>>>>> theme-reviewers mailing list<br>
>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>><br>
>>>>><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> theme-reviewers mailing list<br>
>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>><br>
>>>><br>
>>> _______________________________________________<br>
>>> theme-reviewers mailing list<br>
>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>><br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> theme-reviewers mailing list<br>
>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>><br>
>>><br>
>><br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>><br>
>><br>
><br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Regards,<br>
Daniel Fenn<br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br></div>