<font color="#333333"><font><font face="arial,helvetica,sans-serif">Personal -vs Themes for distribution are two different beasts ;) </font></font></font><div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br>
</font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">I don't know if this will be allowed once the Child Themes are supported, however definitely something to think about for sure. I would personally say yes, if there are no other solutions.</font></font></font><div>
<font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Thanks,</font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Emil<br>
</font></font></font><br><div class="gmail_quote">On Thu, May 31, 2012 at 2:09 AM, Philip M. Hofer (Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div dir="ltr">
<div style="font-size:12pt;font-family:'Calibri'">
<div>Themes should not deregister core provided scripts. I
agree. *however* deregistering their own scripts is
okay. I do that in several child themes to make changes to the
menubar .js </div>
<div> </div>
<div> </div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal">
<div style="FONT:10pt tahoma">
<div> </div>
<div style="BACKGROUND:#f5f5f5">
<div><b>From:</b> <a title="georgemamadashvili@gmail.com" href="mailto:georgemamadashvili@gmail.com" target="_blank">George Mamadashvili</a> </div>
<div><b>Sent:</b> Thursday, May 31, 2012 12:02 AM</div>
<div><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
</div>
<div><b>Subject:</b> Re: [theme-reviewers] jQuery</div></div></div>
<div> </div></div>
<div style="font-size:small;font-style:normal;text-decoration:none;font-family:'Calibri';display:inline;font-weight:normal"><div><div class="h5">I
think themes shouldn't use wp_deregister_script(). In most cases it's used for
deregistering jQuery. Providing jQuery and other JS libraries from CDN, I think
is plugin territory. <br><br>
<div class="gmail_quote">On Thu, May 31, 2012 at 7:12 AM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote"><font color="#333333"><font face="arial,helvetica,sans-serif">Even with multiple libraries
wp_deregister_script is not needed. With e.g. wp_enqueue_script('my-script',
get_template_directory_uri() . '/js/my-script.js', array('jquery'), '1.0.0',
true); you can enqueue as many JS as you want, without conflicts, what you
already know. Now just like PHP JS can be overridden with another e.g.
my-custom-fancybox as well, so you don't need to deregister. This applies only
to WPORG, you can do whatever you please on your site, which doesn't really
apply to this topic anyways :) Quick example </font></font><font color="#333333" face="arial, helvetica, sans-serif"><a href="http://stackoverflow.com/questions/296667/overriding-a-javascript-function-while-referencing-the-original" target="_blank">http://stackoverflow.com/questions/296667/overriding-a-javascript-function-while-referencing-the-original</a></font><span><font color="#888888">
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div></font></span>
<div><span><font color="#888888"><font color="#333333" face="arial, helvetica, sans-serif">Emil<br></font></font></span>
<div>
<div>
<div><font color="#333333"><font face="arial,helvetica,sans-serif"><br></font></font></div>
<div><font color="#333333"><font face="arial,helvetica,sans-serif"><br></font></font><br>
<div class="gmail_quote">On Wed, May 30, 2012 at 5:00 PM, Sayontan Sinha <span dir="ltr"><<a href="mailto:sayontan@gmail.com" target="_blank">sayontan@gmail.com</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">
<div>
<blockquote style="BORDER-LEFT:rgb(204,204,204) 1px solid;MARGIN:0pt 0pt 0pt 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">My only question: is there *ever* a legitimate use of
wp_deregister_script()?<br></blockquote><br></div>I can think of one corner
case, though it is really really rare. Let's say you are using 2 external JS
libraries in your theme that don't work with each other out of the box (or
they don't give you appropriate results). So you tweak them to make them
work. Now, your tweaks are done in a manner that doesn't affect other
plugins using unmodified versions of the script. E.g. you might have added a
"data" attribute to something in the script. If you want the modified script
to be picked up, you would want to deregister the one from the plugin and
register yours. Of course, there are potential questions about namespacing
such scripts, but those questions exist for any script that is not bundled
with WP itself, regardless of wp_deregister_script.<br><br>I have had to
modify libraries for a plugin - I couldn't get Fancybox / Colorbox /
PrettyPhoto to play nicely with JQuery Tooltip, so I had to put in some
modifications. I am guessing there might be theme authors requiring to do
something similar.<br><br>Sayontan.
<div>
<div><br><br>
<div class="gmail_quote">On Wed, May 30, 2012 at 2:48 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">I agree, too. I think adding wp_dereigster_script() to
Theme Check would be a great idea. My only question: is there *ever* a
legitimate use of wp_deregister_script()? If so, we can add it as INFO; if
not, we can just go ahead and add it as REQUIRED. But, I want to be sure
we've considered any unintended consequences before doing so.
<div> </div>
<div>Chip</div>
<div>
<div> </div>
<div class="gmail_quote">On Wed, May 30, 2012 at 4:33 PM, esmi at quirm dot
net <span dir="ltr"><<a href="mailto:esmi@quirm.net" target="_blank">esmi@quirm.net</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">on 30/05/2012 22:01 Emil Uzelac said the
following:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">Also see:<br><a href="http://wpdevel.wordpress.com/2011/12/12/use-wp_enqueue_scripts-not-wp_print_styles-to-enqueue-scripts-and-styles-for-the-frontend/" target="_blank">http://wpdevel.wordpress.com/<u></u>2011/12/12/use-wp_enqueue_<u></u>scripts-not-wp_print_styles-<u></u>to-enqueue-scripts-and-styles-<u></u>for-the-frontend/</a><br>
</blockquote><br>I
am *so* not arguing against any of this but it does seem to me that the
relevant themes could be weeded out at the mandatory checks/upload
point. I assume the Theme Check plugin is based on the mandatory checks,
yes?
<div>
<div><br><br>Mel<span><font color="#888888"><br>-- <br><a href="http://quirm.net" target="_blank">http://quirm.net</a><br><a href="http://blackwidows.co.uk" target="_blank">http://blackwidows.co.uk</a><br>______________________________<u></u>_________________<br>
theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/<u></u>mailman/listinfo/theme-<u></u>reviewers</a><br>
</font></span></div></div></blockquote></div>
<div> </div></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br></div></div><span><font color="#888888">-- <br>Sayontan
Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>--<br>Beating Australia in
Cricket is like killing a celebrity. The death gets more coverage than the
crime.<br><br></font></span><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div>
<div> </div></div></div></div></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><p>
</p><hr><div class="im">
_______________________________________________<br>theme-reviewers mailing
list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div><p></p></div></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div>