<font color="#333333"><font><font face="arial,helvetica,sans-serif">I don't think that you guys understand few things here, so let me explain:</font></font></font><div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br>
</font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">We're not discussing if this is something we're going to put into Theme Review guidelines or not, inline styles are already not accepted and this is not yes/no discussion here.</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">You're also not understanding what it means if we really put this in Theme Review and let me explain how many will understand "recommended only"</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">"Hey, by the law you are recommended to be 21+ to drink, but no you're not required to be 21+ to drink alcohol" that's what would happen if we do "recommended only" Do you have any idea how many will actually be as one of you and truly follow the recommendations?</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">Matt Mullenweg said once "WordPress Repository is not the place for all Themes, it's the place for best Themes" (don't quote me literally).</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">There's also a difference between a minimum standard and required or recommended, please make a note of that.</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">Just to repeat, <b>inline styles are not accepted for a longer time</b>, my e-mail was for Theme Reviewers and <b>merely as reminde</b>r of some "<i>missed in reviews items</i>",<b> not a message that this was something new and I wanted everyone to know about it.</b> We don't need to discuss if they're going to be required or recommended, I don't think that we need to do either, unless this becomes something authors do often than we would most likely put this into guidelines and make it required. </font><span style="color:rgb(51,51,51);font-family:arial,helvetica,sans-serif">Sayontan translated this as an "attack" on Theme developers and no it wasn't, not at all.</span></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif"><i>Now that we got attention from some, let's join the WPTRT and help us with some reviews, wasted energy if much more helpful there than here :) WordPress contribution doesn't stop by releasing a Theme or two, it's not a product, it's a continuing process.</i></font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><i><br></i></font></div><div><font color="#333333" face="arial, helvetica, sans-serif"><i>P.S. And BTW for "regex" I am not "killing" anything but what I needed to do. Styles are removed from inline to external (added back in via style.css)</i></font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><i><br></i></font></div><div><font color="#333333" face="arial, helvetica, sans-serif"><i><div>/* =Gallery</div><div>-------------------------------------------------------------- */</div>
<div>.gallery {</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>margin:0 auto 18px;</div><div>}</div><div><br></div><div>.gallery .gallery-item {</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>float:left;</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>margin-top:0;</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>text-align:center;</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>width:155px;</div>
<div>}</div><div><br></div><div>.gallery img {</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>border:1px solid #ddd;</div><div>}</div><div><br></div><div>.gallery .gallery-caption {</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>font-size:12px;</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>margin:0 0 12px;</div><div>}</div><div><br></div><div>.gallery dl {</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>margin:0;</div>
<div>
}</div><div><br></div><div>.gallery br+br {</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>display:none;</div><div>}</div></i></font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">Thanks,</font></div><div><font color="#333333" face="arial, helvetica, sans-serif">Emil</font></div>
<div><br><div class="gmail_quote">
On Fri, May 4, 2012 at 3:46 AM, Syahir Hakim <span dir="ltr"><<a href="mailto:khairulsyahir@gmail.com" target="_blank">khairulsyahir@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<font size="-1"><font face="Arial">I do agree that inline styles are
definitely not best practice, but as Sayontan has pointed out
there are certain valid use cases with them. Of course, we don't
want theme developers to litter the bulk of their codes with
inline styles, but enforcing them as required would be
nitpicking on little things that would not bring significant
benefits. It will only add another barrier of entry to new theme
developers looking to contribute to the repository, and dump
additional work on existing developers who are already
stretching their time contributing to the repository. This is
especially when the majority of theme users will not even notice
a difference to their user experience as a result of this
change. Inline styles are easily overridden by using </font></font><font size="-1"><tt>!important</tt></font><font size="-1"><font face="Arial">, anyways.<br>
<br>
I would agree with it being recommended rather than required.
That way theme developers who are using inline styles can
gradually update their codes to get rid of most of the inline
styles. Guidelines should be that - guidelines. Every new item
being enforced as required will add additional work to existing
developers, and additional barrier of entry to new developers.
Everything comes at a cost, and for this case I do not think the
benefits outweigh the costs.<br>
</font></font>
<pre cols="72">--
Regards,
Syahir Hakim
</pre><div><div>
<br>
On 4/05/2012 8:15 p.m., Greg Priday wrote:
<blockquote type="cite">
<pre>I feel there's a certain spirit of WordPress that makes the community
great and has helped it thrive.
There's nothing inherently wrong with using the style attribute here
and there, but I do feel it goes against this spirit. I'm sure most
WordPress developers will agree that using the style attribute just
doesn't feel right. To me, it just looks plain ugly - I dont even like
using them during development.
On the other hand, as a once-OO developer, I used to hate WordPress'
use of global variables all willy nilly. It's part of the spirit of
WordPress though, so I've learned to embrace, and even appreciate,
globals. So I definitely understand your views Sayontan. The spirit of
WordPress can sometimes be confusing, dogmatic, etc - but it's usually
for the best.
Time to get back to work. I'm sure we all have awesome stuff to build.
On Fri, May 4, 2012 at 10:01 AM, Sayontan Sinha <a href="mailto:sayontan@gmail.com" target="_blank"><sayontan@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre>Do we need to continue our "discussion" ? ;)
</pre>
</blockquote>
<pre>By all means go ahead. As I said, your links give examples of repeated
styles, which I am not disputing. As I pointed out in my previous post, for
a style used only once, an inline style is less bloat, akin to the Hello
World patterns example. (I had a much longer text written about repeated vs.
non-repeated styles in one of my prior posts, but I deleted it because I
wanted to shorten the mail)
Anyway, I don't believe I am going to convince or be convinced, so this is
the end of my contribution to this thread. Feel free to thrust this as a
"REQUIRED" item for theme approval if you feel that is the best recourse. I
still believe that enforcing "No inline styles" is dogmatic and without
appropriate technical merit, but I am probably in a minority of 1.
On Fri, May 4, 2012 at 12:40 AM, Emil Uzelac <a href="mailto:emil@themeid.com" target="_blank"><emil@themeid.com></a> wrote:
</pre>
<blockquote type="cite">
<pre>And to add and possibly finish this
up: <a href="http://www.websiteoptimization.com/secrets/web-page/replace-inline-style.html" target="_blank">http://www.websiteoptimization.com/secrets/web-page/replace-inline-style.html</a>
was published in <a href="http://www.amazon.com/dp/0596515081/?tag=websiteoptimi-20" target="_blank">http://www.amazon.com/dp/0596515081/?tag=websiteoptimi-20</a>
as well ;) Do we need to continue our "discussion" ? ;)
Thanks,
Emil
</pre>
</blockquote>
<pre>_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
<pre></pre>
</blockquote>
</div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>