<font color="#333333"><font><font face="arial,helvetica,sans-serif">There's no shortcuts in CSS, saving time -vs doing it right the first time is completely different. It is very important <div style="margin-top:33px;"> will be hard to override in a stylesheet and yes it is wrong and bad practice, how can this be good. Tables too, I did not use tables in years! </font></font></font><span style="color:rgb(51,51,51);font-family:arial,helvetica,sans-serif"><div style="margin-top:33px;"> is for "lazy" developers I am sorry, not sure if you're using them or not.</span><div>
<font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">This is not something that I am pushing, it was much before me. My first message was also intended for reviewers and only as a reminder that's all.</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">See:</font></font></font></div><div><ul><li>
<span style="font-family:arial,helvetica,sans-serif;color:rgb(51,51,51)"><a href="http://codex.wordpress.org/CSS_Coding_Standards">http://codex.wordpress.org/CSS_Coding_Standards</a></span></li><li><font color="#333333" face="arial, helvetica, sans-serif"><a href="http://codex.wordpress.org/WordPress_Coding_Standards">http://codex.wordpress.org/WordPress_Coding_Standards</a></font></li>
</ul><div><font color="#333333" face="arial, helvetica, sans-serif">second link will give you better idea how strict the WP Standards are and how much of slack review team is giving to all of us.</font></div><div><font color="#333333" face="arial, helvetica, sans-serif"><br>
</font></div><div><font color="#333333" face="arial, helvetica, sans-serif">Thanks,</font></div><div><font color="#333333" face="arial, helvetica, sans-serif">Emil</font></div><br><div class="gmail_quote">On Thu, May 3, 2012 at 7:35 PM, Sayontan Sinha <span dir="ltr"><<a href="mailto:sayontan@gmail.com" target="_blank">sayontan@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Emil,<br>I do understand using a separate CSS file for the admin options and I have been using one myself since more than 2 years, with a separate JS file etc.: see <a href="http://themes.svn.wordpress.org/suffusion/2.0.1/admin" target="_blank">http://themes.svn.wordpress.org/suffusion/2.0.1/admin</a>, from September 2010. But I don't agree about user choice being important here at all. I am yet to come across any user who has wanted to use a different admin stylesheet file from the one I have provided. Think of it this way: the template files and stylesheets should be what a theme user would like to be editing, but the admin files and stylesheets are what a theme developer would like to be in charge of (it is the developer's brand, in a way).<br>
<br>Take another case (and this is for the front end), where a featured slider widget lets you set some colors. If you try defining CSS classes for these colors, you will soon run into issues with the handling of multiple featured sliders etc. Your simplest recourse here is to do an inline style, otherwise you will have to print out the styles in your HTML markup when the widget is rendering and force them into your <head> element using JQuery - much ado for little.<br>
<br>If you try pushing this requirement too hard, then the next requirement to
come through the pipeline is going to become: "Themes must not use
$j('.selector').css({ display: 'none' }), because this prints an inline
style. Instead you should use $j('.selector').addClass('hidden'), and add '.hidden' to your stylesheet". If you look at core WP, things like the widget screen make inline stylesheet assignments to hide widgets.<div class="im">
<br>
<br><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><span> for example doing this is IMO worse than creating Theme using tables only :)</span><br></blockquote>
<br></div>I don't believe a table-based theme markup is analogous to this case at all. For one, I am talking about specific aspects of the back-end, while you are referring to the front-end. However, since you bring tables up, the recommended method for using theme options, the Settings API uses tables for its layout. Again, this is something in the back-end which is why you haven't had users go up in arms. Of course you might argue that options are tabular data and options are tabular, hence a table is fine in the Settings API, but then not all theme developers like to have a tabular layout for their options.<br>
<br>Anyway, this is just my point of view. I would hate to see "No inline CSS anywhere" become a hard and fast requirement or even a recommendation for that matter. I am not at all suggesting that all styles be inline - that would be foolish and impractical. All I am saying is that there are some cases where inline styles might actually save you a lot of effort and will not affect your theme's user at all.<span class="HOEnZb"><font color="#888888"><br>
<br>Sayontan.</font></span><div class="HOEnZb"><div class="h5"><br><br><div class="gmail_quote">On Thu, May 3, 2012 at 4:53 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<font color="#333333"><font><font face="arial,helvetica,sans-serif">That would be nice Chip, can we do that?</font></font></font><div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif">@Sayontan yes sir that's not the best practice and you can use style.css for admin pages as well, take a look at Twenty Eleven for example. JS/Custom Styles etc is a choice, that's something we choose to do, having </font></font></font><span><div style="background:#000;"> directly is not. Styles in elements will be almost impossible to overwrite within a style.css for example doing this is IMO worse than creating Theme using tables only :)</span></div>
<div><span><br></span></div><div><span>Take a look at </span><font color="#333333" face="arial, helvetica, sans-serif"><a href="http://themes.svn.wordpress.org/oenology/2.5/" target="_blank">http://themes.svn.wordpress.org/oenology/2.5/</a> I think that all Themes should follow this model, also Twenty Eleven.</font></div>
<span><font color="#888888">
<div><font color="#333333"><font face="arial,helvetica,sans-serif"><br></font></font></div></font></span><div><span><font color="#888888"><font color="#333333"><font face="arial,helvetica,sans-serif">Emil<br>
</font></font></font></span><div><div><br><div class="gmail_quote">On Thu, May 3, 2012 at 6:36 PM, Sayontan Sinha <span dir="ltr"><<a href="mailto:sayontan@gmail.com" target="_blank">sayontan@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
<font color="#333333" face="arial, helvetica, sans-serif">- CSS Styles: <div style="background:#000;"> that's not accepted</font><br>
</blockquote><br></div>Even for admin pages? I understand for a front-end facing page you would want the styles not to be inline so as to facilitate ease of use for a theme user, but specifically for things like widget options (to be shown under Appearance -> Widgets, not how the widget renders to an end user) having explicit CSS classes is probably going to be overkill.<div>
<br>
<br><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><div><font color="#333333" face="arial, helvetica, sans-serif">- jQuery Functions: Must be within a e.g. js/example.js not embedded in Theme directly</font></div>
</blockquote><br></div>What about dynamic JS, where wp_localize_script is not an option (E.g. JS code repeated within a PHP loop)? Or do you explicitly mean functions only (and not calls to functions)?<br><br><div class="gmail_quote">
<div><div>
On Thu, May 3, 2012 at 4:20 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div>
<font color="#333333"><font><font face="arial,helvetica,sans-serif">Hey Reviewers,</font></font></font><div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">As I was going over some reviews I am seeing that some of us are not catching some of the obvious "issues" with the Themes.</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">- Theme/Author URL: please click on them please, not only that some will be SPAM but also to see if the site even exist. When I clicked on one today the domain name was not even registered</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif">- jQuery: Only WordPress bundled can be used, nothing else, this is clearly marked in Theme Review guides </font></font></font><font color="#333333" face="arial, helvetica, sans-serif"><a href="http://codex.wordpress.org/Theme_Review" target="_blank">http://codex.wordpress.org/Theme_Review</a></font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif">- jQuery Functions: Must be within a e.g. js/example.js not embedded in Theme directly</font></div><div><font color="#333333" face="arial, helvetica, sans-serif">- CSS Styles: <div style="background:#000;"> that's not accepted</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">Trac is pretty cleaned out, there's not too many Themes in it and thanks all for that, however we're not competing who will review more Themes. Something so obvious will need to be addressed first time around and in some cases I've seen that they were not reported in couple of reviews.</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">No big deal, it would be nice to pay more attention to what we are looking at that's all.</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">P.S. Create a plan and use that plan when reviewing Themes. I would take a Theme and start with some simple stuff such as header.php > index.php > footer.php than functions.php and sometimes there would be more than enough required items (preliminary review only) that I would not even install a Theme, SVN can tell you plenty. But that's just me.</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">Thanks,</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif">Emil</font></div>
<br></div></div><div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></div></blockquote></div><span><font color="#888888"><br><br clear="all"><br>-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
--<br>Beating Australia in Cricket is like killing a celebrity. The death gets more coverage than the crime.<br><br>
</font></span><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
--<br>Beating Australia in Cricket is like killing a celebrity. The death gets more coverage than the crime.<br><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>