<div class="gmail_extra">I just noticed that in Theme Guidelines there is no reference to WordPress Coding Standards <a href="http://codex.wordpress.org/WordPress_Coding_Standards">http://codex.wordpress.org/WordPress_Coding_Standards</a> May be a link in section "Code Quality" will be helpful for developers.<br>
<br>Fingli<br><br><div class="gmail_quote">На 26 април 2012, 17:27, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> написа:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_extra">Code obfuscation is treated as such a high-level, obvious no-no that it is "assumed without saying". As Jay indicated: Theme Check flags code obfuscation at a WARNING level, and the uploader script will simply fail to upload any Theme with obfuscated code. Anyone who even needs to ask if obfuscated code is acceptable probably isn't someone we even want to associate ourselves with in the first place, so the guidelines aren't tailored to such people. :)</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Note: "obfuscation" (more properly: minification) of script libraries is perfectly acceptable, provided that a human-readable version is included for reference.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Thanks,</div><div class="gmail_extra"><br></div><div class="gmail_extra">Chip<div><div class="h5"><br><br><div class="gmail_quote">On Thu, Apr 26, 2012 at 8:41 AM, Andrew McGill <span dir="ltr"><<a href="mailto:list2010@lunch.za.net" target="_blank">list2010@lunch.za.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br>
<br>
I notice that the theme standards do not say anything about code obfuscation and readability:<br>
<br>
<a href="http://codex.wordpress.org/Theme_Review#Security_and_Privacy" target="_blank">http://codex.wordpress.org/Theme_Review#Security_and_Privacy</a><br>
<br>
I suggest the following guidelines:<br>
<br>
* No obfuscation: all code must written in human readable format: measures that reduce readability are not allowed. (e.g. variable name mangling, stripping indentation)<br>
<br>
* No hiding: All code must appear in regular .php files. No measures to obscure the code being run are permitted.<br>
<br>
The reason this would be helpful is that there are a lot of commercial themes of dubious quality employing various kinds of obfuscation - 85 levels of base64_decode and gzip hiding the closing div tags, wp_footer and the 'if $posts>20 (advertise())'. It is also pretty hard to distinguish "legitimate" obfuscation from a hacked site.<br>
<br>
It would make the world a happier place if <a href="http://wordpress.org" target="_blank">wordpress.org</a> said that code obfuscation is not-so-cool.<br>
<br>
Something should also be said about code obfuscation in javascript files too ... (e.g. the compressed version of jquery). I reckon it should be discouraged (if not prohibited).<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><font style="font-family:trebuchet ms,sans-serif" size="2">Yulian Yordanov<br><a href="http://post-scriptum.info/" target="_blank">post-scriptum.info</a></font><br><br>
</div>