(Please try to avoid replying to digests...)<div><br></div><div>What's the ticket link, again?</div><div><br></div><div>One of the admins will review it, resolve/close it, and then give you reviewer privileges, so that you can assign/close tickets on your own.</div>
<div><br></div><div>Thanks,</div><div><br></div><div>Chip<br><br><div class="gmail_quote">On Mon, Apr 9, 2012 at 3:39 PM, <span dir="ltr"><<a href="mailto:lucia@fiveblackcats.com">lucia@fiveblackcats.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for the tips, Chip.<br>
I have just written my comments in the Ticket. What's next?<br>
Lucia<br>
<br>
><br>
><br>
> Today's Topics:<br>
><br>
> 1. Inserting posts on activation (Konstantin Obenland)<br>
> 2. Re: Inserting posts on activation (Chip Bennett)<br>
> 3. Re: Inserting posts on activation (Thomas Scholz)<br>
> 4. #7076 - My first review - some questions (Lucia Dossin)<br>
> 5. Re: #7076 - My first review - some questions (Chip Bennett)<br>
><br>
><br>
> ----------------------------------------------------------------------<br>
><br>
> Message: 1<br>
> Date: Sat, 7 Apr 2012 18:00:34 +0200<br>
> From: Konstantin Obenland <<a href="mailto:konstantin@obenland.it">konstantin@obenland.it</a>><br>
> Subject: [theme-reviewers] Inserting posts on activation<br>
> To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> Message-ID: <<a href="mailto:78C052A5-73DC-4E7B-8DBB-49B1C60DFF97@obenland.it">78C052A5-73DC-4E7B-8DBB-49B1C60DFF97@obenland.it</a>><br>
> Content-Type: text/plain; charset="us-ascii"<br>
><br>
> Are Themes allowed to publish a page on activation?<br>
><br>
> Thanks,<br>
> Konstantin<br>
> -------------- next part --------------<br>
> An HTML attachment was scrubbed...<br>
> URL:<br>
> <<a href="http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120407/e3d2edbf/attachment-0001.htm" target="_blank">http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120407/e3d2edbf/attachment-0001.htm</a>><br>
><br>
> ------------------------------<br>
><br>
> Message: 2<br>
> Date: Sat, 7 Apr 2012 11:22:44 -0500<br>
> From: Chip Bennett <<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>><br>
> Subject: Re: [theme-reviewers] Inserting posts on activation<br>
> To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> Message-ID:<br>
> <CAPdLKqc5iqi7=Eg-pRdEmqCy_kjYopMH=<a href="mailto:e4T_USKS4jwBEHO7A@mail.gmail.com">e4T_USKS4jwBEHO7A@mail.gmail.com</a>><br>
> Content-Type: text/plain; charset="iso-8859-1"<br>
><br>
> They will be able to create a page with the new 3.4 Front Page<br>
> functionality, whereby a Theme can declare a static Front Page.<br>
><br>
> That's something that we'll need to consider, with the upcoming guidelines<br>
> revisions.<br>
><br>
> Thanks,<br>
><br>
> Chip<br>
><br>
> On Sat, Apr 7, 2012 at 11:00 AM, Konstantin Obenland<br>
> <<a href="mailto:konstantin@obenland.it">konstantin@obenland.it</a><br>
>> wrote:<br>
><br>
>> Are Themes allowed to publish a page on<br>
>> activation<<a href="http://themes.trac.wordpress.org/browser/cross-fitness-workout/1.1/functions.php?rev=19898#L52" target="_blank">http://themes.trac.wordpress.org/browser/cross-fitness-workout/1.1/functions.php?rev=19898#L52</a>><br>
>> ?<br>
>><br>
>> Thanks,<br>
>> Konstantin<br>
<div class="im">>><br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>><br>
>><br>
</div>> -------------- next part --------------<br>
> An HTML attachment was scrubbed...<br>
> URL:<br>
> <<a href="http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120407/247387a8/attachment-0001.htm" target="_blank">http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120407/247387a8/attachment-0001.htm</a>><br>
><br>
> ------------------------------<br>
><br>
> Message: 3<br>
> Date: Sat, 07 Apr 2012 18:34:52 +0200<br>
> From: "Thomas Scholz" <<a href="mailto:thomas.scholz@gmail.com">thomas.scholz@gmail.com</a>><br>
> Subject: Re: [theme-reviewers] Inserting posts on activation<br>
> To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> Message-ID: <<a href="mailto:op.wceloeq1qsyxj4@fqdn.toscho.de">op.wceloeq1qsyxj4@fqdn.toscho.de</a>><br>
> Content-Type: text/plain; charset=windows-1252; format=flowed;<br>
> delsp=yes<br>
><br>
> Konstantin Obenland<br>
><br>
>> Are Themes allowed to publish a page on activation?<br>
><br>
> I don?t think this a good idea. Imagine some trying out a dozen themes ?<br>
><br>
> In this special case it should not be allowed. 'Profile' is not translated<br>
> (in German it is a plural, meaning 'profiles'), the page content is<br>
> missing translation too, and the 'post author' may not even exist (you can<br>
> delete user 1). Plus, the page is published immediately for no obvious<br>
> reason.<br>
><br>
> Thomas Scholz<br>
><br>
><br>
> ------------------------------<br>
><br>
> Message: 4<br>
> Date: Sat, 07 Apr 2012 19:32:22 +0200<br>
> From: Lucia Dossin <<a href="mailto:lucia@fiveblackcats.com">lucia@fiveblackcats.com</a>><br>
> Subject: [theme-reviewers] #7076 - My first review - some questions<br>
> To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> Message-ID: <<a href="mailto:4F807A26.7040102@fiveblackcats.com">4F807A26.7040102@fiveblackcats.com</a>><br>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed<br>
<div class="im">><br>
> Hi there,<br>
> I just finished my first review (ticket #7076, Zenon Lite) and I'd like<br>
> to check some points with you, the veterans, before I proceed ;) .<br>
><br>
> Policy Requirements<br>
> ------------------<br>
> - must all icons/graphics have an explicit license or is a general info<br>
> about License in the readme.txt enough?<br>
</div><div class="im">> - theme has a folder called ie6 where there's a js file with messages<br>
> asking the user to upgrade their browser. There's no option to disable<br>
> that in the Admin interface. Is that ok?<br>
</div><div class="im">> - theme has an about.php file, inside admin folder, where theme author<br>
> lists his facebook, twitter, flickr pages and his website as well. He also<br>
> displays there a comparison table + link to the Pro version of this Theme.<br>
> is that ok?<br>
</div><div class="im">> -Theme comes with 3 font options. They are licenced under SIL Open Font<br>
> License (OFL), I guess that's ok, right?<br>
><br>
><br>
</div><div class="im">> Theme Check Results<br>
> ------------------<br>
> Theme passed the tests and the following result messages were displayed.<br>
> (1)RECOMMENDED: No reference to add_editor_style() was found in the theme.<br>
> It is recommended that the theme implement editor styling, so as to make<br>
> the editor content match the resulting post output in the theme, for a<br>
> better user experience.<br>
> ->My question: should I mention that in the review?<br>
><br>
> (2)RECOMMENDED: No reference to add_custom_image_header was found in the<br>
> theme. It is recommended that the theme implement this functionality if<br>
> using an image for the header.<br>
> ->My comment on that: No image for the header, so I guess it's ok.<br>
><br>
> Three more INFO notices were displayed.<br>
><br>
><br>
</div><div class="im">> Theme Unit Tests<br>
> ----------------<br>
> - If one of the options provided by Theme is checked (Enable Sticky Menu),<br>
> Blog title rotates 90 degrees as I scroll (Firefox 11). Seems to be a bug.<br>
> This options is checked by default.<br>
><br>
</div><div class="im">> - Post with no title links to error 404 page.<br>
><br>
</div><div class="im">> - Long menu doesn't 'break' the site layout but some menu items are<br>
> displayed out of the menu bar. No mention to menu items limit was found in<br>
> the readme.txt.<br>
><br>
</div><div class="im">> - Validation: theme did not pass markup validation, got 36 errors. The<br>
> first error refers to nested ul tags (they seem right, though).<br>
><br>
><br>
><br>
</div><div class="im">> Hope to get some tips from you regarding these topics. A very happy<br>
> Easter for those of you who celebrate it!<br>
><br>
> Thanks,<br>
> Lucia Dossin<br>
><br>
> --<br>
> -------------------<br>
> <a href="http://www.fiveblackcats.com" target="_blank">www.fiveblackcats.com</a><br>
><br>
> KvK 34375444<br>
><br>
> BR <a href="tel:%2B55%2011%203042.2923" value="+551130422923">+55 11 3042.2923</a><br>
> NL <a href="tel:%2B31%20%280%29%206%202471.2500" value="+31624712500">+31 (0) 6 2471.2500</a><br>
> -------------------<br>
><br>
><br>
><br>
</div>> ------------------------------<br>
><br>
> Message: 5<br>
> Date: Sat, 7 Apr 2012 13:39:54 -0500<br>
> From: Chip Bennett <<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>><br>
> Subject: Re: [theme-reviewers] #7076 - My first review - some<br>
> questions<br>
> To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> Message-ID:<br>
> <CAPdLKqfq-KecOwbV50_tnS2+5=N_b3qu6AsmmVndW+2eB=<a href="mailto:URsw@mail.gmail.com">URsw@mail.gmail.com</a>><br>
> Content-Type: text/plain; charset="iso-8859-1"<br>
<div><div class="h5">><br>
> See comments inline:<br>
><br>
> On Sat, Apr 7, 2012 at 12:32 PM, Lucia Dossin<br>
> <<a href="mailto:lucia@fiveblackcats.com">lucia@fiveblackcats.com</a>>wrote:<br>
><br>
>> Hi there,<br>
>> I just finished my first review (ticket #7076, Zenon Lite) and I'd like<br>
>> to<br>
>> check some points with you, the veterans, before I proceed ;) .<br>
>><br>
>> Policy Requirements<br>
>> ------------------<br>
>> - must all icons/graphics have an explicit license or is a general info<br>
>> about License in the readme.txt enough?<br>
>><br>
><br>
> If the Theme developer owns copyright on all icons/graphics (and states<br>
> such), then the general license is fine. Otherwise, Theme should indicate<br>
> copyright/license for the bundled icons/graphics.<br>
><br>
><br>
>> - theme has a folder called ie6 where there's a js file with messages<br>
>> asking the user to upgrade their browser. There's no option to disable<br>
>> that<br>
>> in the Admin interface. Is that ok?<br>
>><br>
><br>
> This is Plugin territory.<br>
><br>
><br>
>> - theme has an about.php file, inside admin folder, where theme author<br>
>> lists his facebook, twitter, flickr pages and his website as well. He<br>
>> also<br>
>> displays there a comparison table + link to the Pro version of this<br>
>> Theme.<br>
>> is that ok?<br>
>><br>
><br>
> Yes, Upsell Themes are fine. Be sure to check the Guidelines regarding<br>
> Upsell Themes, but at a glance, I can't find anything that would cause a<br>
> problem. (e.g. both versions are GPL-licensed, and the commercial version<br>
> doesn't lock core WP functionality behind the paywall).<br>
><br>
><br>
>> -Theme comes with 3 font options. They are licenced under SIL Open Font<br>
>> License (OFL), I guess that's ok, right?<br>
>><br>
><br>
> Yes, SIL OpenFont is GPL-compatible. Refer to the Guidelines for the list<br>
> of known-GPL-compatible font licenses.<br>
><br>
>><br>
>><br>
>> Theme Check Results<br>
>> ------------------<br>
>> Theme passed the tests and the following result messages were displayed.<br>
>> (1)RECOMMENDED: No reference to add_editor_style() was found in the<br>
>> theme.<br>
>> It is recommended that the theme implement editor styling, so as to make<br>
>> the editor content match the resulting post output in the theme, for a<br>
>> better user experience.<br>
>> ->My question: should I mention that in the review?<br>
>><br>
>> (2)RECOMMENDED: No reference to add_custom_image_header was found in<br>
>> the<br>
>> theme. It is recommended that the theme implement this functionality if<br>
>> using an image for the header.<br>
>> ->My comment on that: No image for the header, so I guess it's ok.<br>
>><br>
>> Three more INFO notices were displayed.<br>
>><br>
><br>
> Do NOT list recommended or info results in the Theme Review, unless they<br>
> are relevant - i.e. unless they are involved in a REQUIRED comment.<br>
><br>
>><br>
>><br>
>> Theme Unit Tests<br>
>> ----------------<br>
>> - If one of the options provided by Theme is checked (Enable Sticky<br>
>> Menu),<br>
>> Blog title rotates 90 degrees as I scroll (Firefox 11). Seems to be a<br>
>> bug.<br>
>> This options is checked by default.<br>
>><br>
><br>
> That is definitely an issue, unless it is somehow by design.<br>
><br>
><br>
>><br>
>> - Post with no title links to error 404 page.<br>
>><br>
><br>
> That is a known bug in core, regarding numeric-only post titles/slugs.<br>
> Edit<br>
> the post and reset the post slug, and that *should* resolve the problem.<br>
><br>
><br>
>><br>
>> - Long menu doesn't 'break' the site layout but some menu items are<br>
>> displayed out of the menu bar. No mention to menu items limit was found<br>
>> in<br>
>> the readme.txt.<br>
>><br>
><br>
> This should also be noted.<br>
><br>
><br>
>><br>
>> - Validation: theme did not pass markup validation, got 36 errors. The<br>
>> first error refers to nested ul tags (they seem right, though).<br>
>><br>
><br>
><br>
> Only comment regarding validation errors if they cause layout/markup<br>
> breakage. (Note: be sure to test validation on a post such as "Readability<br>
> Test", in order to minimize content-related validation errors.)<br>
><br>
> Thanks for helping with Theme reviews!<br>
><br>
> Chip<br>
</div></div>> -------------- next part --------------<br>
> An HTML attachment was scrubbed...<br>
> URL:<br>
> <<a href="http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120407/ef56bd80/attachment.htm" target="_blank">http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120407/ef56bd80/attachment.htm</a>><br>
><br>
> ------------------------------<br>
<div class="im">><br>
> _______________________________________________<br>
> theme-reviewers mailing list<br>
> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
><br>
</div>> End of theme-reviewers Digest, Vol 23, Issue 23<br>
> ***********************************************<br>
<div class="HOEnZb"><div class="h5">><br>
<br>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br></div>