<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Child theme authors can simply overwrite this with their own
'add_theme_support()' call. I use "theme-supported features" from
both WordPress and my framework extensively. Users overwrite these
calls all the time. And, it's pretty easy to do so.<br>
<br>
On 4/6/2012 3:15 PM, Edward Caissie wrote:
<blockquote
cite="mid:CAE5CyMi7BTsySaxqQVA1CFSfiUU+zKNLAijDyUcOxpUjmDD4hw@mail.gmail.com"
type="cite">Create a Child-Theme intended to ship with a different
default background and then test ... let me know your thinking
then. If Child-Themes are going to be added at 3.4 as it appears
they are, then other features should play nice with that ideal.<br>
<br>
You appear to be choosing a use-case that for the most part is
ignoring the potential for Child-Themes to be, by default,
different than their parents rather than requiring the end-user
make additional setting changes to achieve what should be expected
at the initial installation by default.<br>
<br>
... and perhaps I am taking this from a personal perspective, too
... if I implement the new custom background method with the
default $args set to anything, then I will be required (in good
conscience) to go back to all my Child-Theme clients using
different backgrounds that shipped with the code and (re-)write
their `functions.php` file to provide that same functionality they
expected and received when they acquired their Child-Theme. IMO,
that is counter-productive to theme-authors if the WPTRT dictates
that the proper use is to include the theme background color and
image as part of the function implementation ... thus the
implementation *without* arguments should be the requirement as
the method currently stands.<br>
<br>
<br clear="all">
Cais.<br>
<br>
<br>
<div class="gmail_quote">On Fri, Apr 6, 2012 at 3:09 PM, Chip
Bennett <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
I don't understand the leaning toward not using arguments? If
the issue is Child Theme-related, I must disagree with the
conclusion. Child Theme impact must be considered, of course -
but that consideration should not dictate completely. Why deny
Theme developers the ability easily to declare default
background color, image, and style simply because Child Themes
may not play quite as nicely with the 3.4-style
implementation?<span class="HOEnZb"><font color="#888888">
<div>
<br>
</div>
</font></span>
<div><span class="HOEnZb"><font color="#888888">Chip</font></span>
<div>
<div class="h5"><br>
<br>
<div class="gmail_quote">On Fri, Apr 6, 2012 at 1:53 PM,
Edward Caissie <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:edward.caissie@gmail.com"
target="_blank">edward.caissie@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
ok ... until this is sorted out (glad we are still
in beta), an acceptable implementation of this
functionality should be considered as simply:<br>
<br>
<div style="margin-left:40px">add_theme_support(
'custom-background' );<br>
<br>
</div>
NOTE: No $args added.<br>
<br>
<br clear="all">
Cais.
<div>
<div><br>
<br>
<br>
<div class="gmail_quote">On Fri, Apr 6, 2012 at
2:39 PM, Edward Caissie <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:edward.caissie@gmail.com"
target="_blank">edward.caissie@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
PPS: Just running a few tests ... this does
break Child-Themes that do not implement
add_theme_support ( 'custom-background',
$child-theme-args ) specifically.<br>
... and the relevance of template versus
stylesheet does not play into fixing ... a
strong recommendation to Child-Theme authors
to maintain the exact naming conventions of
the images (in this case) should be made as
well.<br>
<br>
<br clear="all">
Cais.
<div>
<div><br>
<br>
<br>
<div class="gmail_quote">On Fri, Apr 6,
2012 at 2:19 PM, Konstantin Obenland <span
dir="ltr"><<a
moz-do-not-send="true"
href="mailto:obenland@gmx.de"
target="_blank">obenland@gmx.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div style="word-wrap:break-word">Without
testing it: What about using the
placeholder? Doesn't that still
work?
<div><br>
</div>
<div>Konstantin</div>
<div><br>
<div><br>
<div>
<div>Am 06.04.2012 um 20:14
schrieb Edward Caissie:</div>
<div>
<div><br>
<blockquote type="cite">I
would think the
stylesheet directory
URI would be more
correct than the
template directory URI
... otherwise it looks
like a great write-up<br>
<br>
<br clear="all">
Cais.<br>
<br>
<br>
<div
class="gmail_quote">On
Fri, Apr 6, 2012 at
11:02 AM, Amy
Hendrix <span
dir="ltr"><<a
moz-do-not-send="true"
href="mailto:sabreuse@gmail.com" target="_blank">sabreuse@gmail.com</a>></span>
wrote:<br>
<blockquote
class="gmail_quote"
style="margin:0 0
0
.8ex;border-left:1px
#ccc
solid;padding-left:1ex">
Nice writeup -
thanks for posting
it!<br>
<div>
<div><br>
On Fri, Apr 6,
2012 at 11:00
AM, Chip
Bennett <<a
moz-do-not-send="true" href="mailto:chip@chipbennett.net"
target="_blank">chip@chipbennett.net</a>>
wrote:<br>
> Just
posted to the
make.themes
site:<br>
> <a
moz-do-not-send="true"
href="http://make.wordpress.org/themes/2012/04/06/updating-custom-backgrounds-and-custom-headers-for-wordpress-3-4/"
target="_blank">http://make.wordpress.org/themes/2012/04/06/updating-custom-backgrounds-and-custom-headers-for-wordpress-3-4/</a><br>
><br>
> Feel free
to discuss
and/or ask
questions,
either on the
post or here
in the<br>
> mail
list.<br>
><br>
> Thanks,<br>
><br>
> Chip<br>
><br>
</div>
</div>
>
_______________________________________________<br>
>
theme-reviewers
mailing list<br>
> <a
moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
> <a
moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
_______________________________________________<br>
theme-reviewers
mailing list<br>
<a
moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a
moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</blockquote>
</div>
<br>
_______________________________________________<br>
theme-reviewers
mailing list<br>
<a
moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a
moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</blockquote>
</div>
</div>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org"
target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org"
target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
theme-reviewers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a>
<a class="moz-txt-link-freetext" href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
</body>
</html>