That's what I was thinking. Thanks, Chip!<br><br><div class="gmail_quote">On Tue, Feb 28, 2012 at 1:18 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Any content in a Theme that is *intended* to be modified by the end user belongs in Theme options. Requiring users to edit Theme template files is not acceptable, because such changes are not protected.<div>
<br></div><div>
Chip<br><br><div class="gmail_quote">On Tue, Feb 28, 2012 at 12:14 PM, Caroline Moore <span dir="ltr"><<a href="mailto:calobee@gmail.com" target="_blank">calobee@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The theme I'm reviewing (#6411) includes icons for Facebook and Twitter in the header, and by default they link to #facebook and #twitter, respectively. The readme suggests that users can add their own URLs by editing header.php.<div>
<br></div><div>This doesn't seem user-friendly--upon activation the theme displays buttons that are, effectively, broken, and then the user has to go out of their way to edit header.php (assuming they know how to do so in the first place) to make it work.</div>
<div><br></div><div>In my review, can I require the icons be "opt-in" by the user, or commented out by default? A Theme Options area of some kind would be ideal but I don't think that's something we can require theme devs implement, is it?</div>
<div><br></div><div>Thanks,</div><div>Caro<br>
<br>
</div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Caroline Moore<br><br>Calobee Doodles<br>Custom design and childrens illustration<br><a href="http://www.calobeedoodles.com">http://www.calobeedoodles.com</a><br>
<a href="http://calobee.etsy.com">http://calobee.etsy.com</a><br><br>Sixhours Photography<br>Conceptual art photography prints<br><a href="http://www.sixhours.net">http://www.sixhours.net</a><br><a href="http://sixhours.etsy.com">http://sixhours.etsy.com</a><br>
<br>