<font color="#333333"><font><font face="arial,helvetica,sans-serif">Chip you beat me one minute +1 :)</font></font></font><div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font><br>
<div class="gmail_quote">On Wed, Feb 22, 2012 at 3:10 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Note also: it is perfectly acceptable to ask the Theme developer to leave an in-ticket comment, justifying the core-functionality workarounds. Doing so also facilitates future reviews, and helps alleviate future questions/frustrations for reviewers AND developers.<span class="HOEnZb"><font color="#888888"><div>
<br></div></font></span><div><span class="HOEnZb"><font color="#888888">Chip</font></span><div><div class="h5"><br><br><div class="gmail_quote">On Wed, Feb 22, 2012 at 3:03 PM, Caroline Moore <span dir="ltr"><<a href="mailto:calobee@gmail.com" target="_blank">calobee@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I can tell from a quick Theme Check and playing with the theme (at your suggestion, thanks Cais) that it's more complex from a user standpoint--offering background positioning, for example. <div><br></div><div>Also, the custom header allows users to upload an image of any size/aspect ratio (rather than cropping to specific dimensions). Not necessarily "above and beyond," just different.</div>
<div><br></div><div>But again, I think keeping the theme options in one place makes more sense than scattering them across the admin UI in this case. Maybe it's still possible to implement the core functionality and have it appear under the theme options instead of the Appearance menus, but my knowledge of WP core doesn't extend that far yet. :)<br>
<div>
<br><div class="gmail_quote"><div>On Wed, Feb 22, 2012 at 3:40 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
</div><div><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I haven't looked deep into the code, but if you believe the functionality being offered by the theme goes above and beyond the standard implementation recommended to be used in the guidelines then it can be noted but I do not believe it would push the theme over to a "not-approved" resolution ...<br>
<br>... I'll see if I can find some time to look into the code myself as well.<br><br><br clear="all">Cais.<br>
<br><br><div class="gmail_quote"><div><div>On Wed, Feb 22, 2012 at 12:55 PM, Caroline Moore <span dir="ltr"><<a href="mailto:calobee@gmail.com" target="_blank">calobee@gmail.com</a>></span> wrote:<br></div>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
Hi all,<div><br></div><div>I'm working on the PageLines review. The theme uses custom functions to add headers and custom backgrounds (instead of add_custom_image_header or add_custom_background).</div><div><br></div>
<div>I'm assuming this is OK since this theme is kind of a special case. I can see where, in the interests of keeping all the theme's options in one place, it makes more sense to use custom functions. It also looks as though the functionality offered is more complex than the WordPress defaults.</div>
<div><br></div><div>Let me know if I'm not on the right track with that thinking.</div><div><br></div><div>Thanks!</div><div>Caro</div>
<br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div></div></div><span><font color="#888888"><br><br clear="all"><div><br></div>-- <br>Caroline Moore<br><br>Calobee Doodles<br>Custom design and childrens illustration<br><a href="http://www.calobeedoodles.com" target="_blank">http://www.calobeedoodles.com</a><br>
<a href="http://calobee.etsy.com" target="_blank">http://calobee.etsy.com</a><br><br>Sixhours Photography<br>Conceptual art photography prints<br><a href="http://www.sixhours.net" target="_blank">http://www.sixhours.net</a><br>
<a href="http://sixhours.etsy.com" target="_blank">http://sixhours.etsy.com</a><br>
<br>
</font></span></div>
</div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>