<font color="#333333"><font><font face="arial,helvetica,sans-serif">I am not 100% familiar with <a href="http://connect.facebook.net/en_US/all.js#xfbml=1&appId=233928906624944">http://connect.facebook.net/en_US/all.js#xfbml=1&appId=233928906624944</a> @Otto will be much better person for something like that. Not sure why he didn't go with this only <a href="http://connect.facebook.net/en_US/all.js#xfbml=1">http://connect.facebook.net/en_US/all.js#xfbml=1</a> you can ask this in trac.</font></font></font><div>
<font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Emil<br></font></font></font><br><div class="gmail_quote">
On Mon, Feb 20, 2012 at 1:40 AM, Paul Appleyard <span dir="ltr"><<a href="mailto:paul@spacecat.com">paul@spacecat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Ok, well the author has an option in settings for turning 'social
media' buttons on or off; here's the raw like button code:<br>
<br>
<pre><script>(function(d, s, id) {</pre>
<pre> var js, fjs = d.getElementsByTagName(s)[0];</pre>
<pre> if (d.getElementById(id)) {return;}</pre>
<pre> js = d.createElement(s); <a href="http://js.id" target="_blank">js.id</a> = id;</pre>
<pre> js.src = "//<a href="http://connect.facebook.net/en_US/all.js#xfbml=1&appId=233928906624944" target="_blank">connect.facebook.net/en_US/all.js#xfbml=1&appId=233928906624944</a>";</pre>
<pre> fjs.parentNode.insertBefore(js, fjs);</pre>
<pre>}(document, 'script', 'facebook-jssdk'));</script></pre>
<br>
.. as you can see he uses his own appId (233928906624944) It's
fairly innocuous although the author could use it to track theme
use. The button will work without the appId parameter in place.<div class="im"><br>
<br>
Paul<br>
<br>
On 20/02/2012 3:15 PM, Emil Uzelac wrote:
</div><div><div class="h5"><blockquote type="cite"><font color="#333333"><font><font face="arial,helvetica,sans-serif">Paul,</font></font></font>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br>
</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Not sure if this is
"out-and-out evil" and if something like this should be
pushed over to plugin.</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br>
</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif">What you got in
loop-front.php is very much standard JS code for FB Like
Button and it's also available on their dev page <a href="http://developers.facebook.com/docs/guides/web/" target="_blank">http://developers.facebook.com/docs/guides/web/</a>.
This was a straight-up paste and nothing has been changed
from what I could see.</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br>
</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Should that be in Theme
Options maybe, well it could.</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br>
</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Emil<br>
</font></font></font><br>
<div class="gmail_quote">
On Sun, Feb 19, 2012 at 10:58 PM, Paul Appleyard <span dir="ltr"><<a href="mailto:paul@spacecat.com" target="_blank">paul@spacecat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Just after a point of order; an author has inserted Facebook
LIKE button JS code into loop-front.php, but has his OWN
appId in the code; obviously this is unacceptable, but is it
out-and-out evil, calling for a complete blackballing of the
author, public humiliation etc.<br>
<br>
This is my second review, and my impression is that this
sort of functionality kind of belongs to plugins, and that
there should at least be an option for the theme user to add
their own app id.<br>
<br>
Paul<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
</div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>