Unfortunately most of the themes have JS enqueue issues, maybe we should update Theme Development codex about JS and add more info how to do it right.<div><br></div><div><a href="http://codex.wordpress.org/Theme_Development#JavaScript">http://codex.wordpress.org/Theme_Development#JavaScript</a> <br>
<br><div class="gmail_quote">On Mon, Feb 20, 2012 at 11:37 AM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com">emil@themeid.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<font color="#333333"><font><font face="arial,helvetica,sans-serif">You're correct, as it says:</font></font></font><div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif">/* Always have wp_footer() just before the closing </body></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">* tag of your theme, or you will break many plugins, which</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif">* generally use this hook to reference JavaScript files.*/</font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br>
</font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Hook means from i.e. functions.php, no inline JS, author needs to use wp_enqueue_scripts instead: <a href="http://wpdevel.wordpress.com/2011/12/12/use-wp_enqueue_scripts-not-wp_print_styles-to-enqueue-scripts-and-styles-for-the-frontend/" target="_blank">http://wpdevel.wordpress.com/2011/12/12/use-wp_enqueue_scripts-not-wp_print_styles-to-enqueue-scripts-and-styles-for-the-frontend/</a></font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">While going over footer.php in Theme in question I've noticed this:</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">style="display:inline;</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">styles must be moved to style.css and never added to DIVs directly. Another "bad" practice is </font></font></font><font color="#333333" face="arial, helvetica, sans-serif"><div class='clearfix'></div> too, however some will let this pass because it's not trivial issue, I personally would not recommend that. </font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">Also see: <a href="http://nicolasgallagher.com/micro-clearfix-hack/" target="_blank">http://nicolasgallagher.com/micro-clearfix-hack/</a></font></div>
<span class="HOEnZb"><font color="#888888">
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div></font></span><div><span class="HOEnZb"><font color="#888888"><font color="#333333"><font><font face="arial,helvetica,sans-serif">Emil<br>
</font></font></font></font></span><div><div class="h5"><br><div class="gmail_quote">
On Mon, Feb 20, 2012 at 12:57 AM, Paul Appleyard <span dir="ltr"><<a href="mailto:paul@spacecat.com" target="_blank">paul@spacecat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all<br>
<br>
The author is including some custom javascript at the end of the footer - the script is located within the theme directory. Does this need to be enqueued also? I'm also thinking he might need to enclose or namespace the functions here a little as well .. one of the (javascript) functions, light_box(), seems in danger of clashing with other plugins and such at some stage.<br>
<br>
Paul<br>
______________________________<u></u>_________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/<u></u>mailman/listinfo/theme-<u></u>reviewers</a><br>
</blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>