Yes, it was reviewing with Debug Bar that allowed the errors.<br><br><div class="gmail_quote">On 13 February 2012 10:55, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Never mind, I see it now.<br>
<br>
Error suppression using @ just stops the PHP error handler from being<br>
called on an error. If you have custom error handlers, like the debug<br>
bar does, then those still get called.<br>
<br>
Info here: <a href="http://php.net/manual/en/function.set-error-handler.php" target="_blank">http://php.net/manual/en/function.set-error-handler.php</a><br>
And here: <a href="http://php.net/manual/en/language.operators.errorcontrol.php" target="_blank">http://php.net/manual/en/language.operators.errorcontrol.php</a><br>
<span class="HOEnZb"><font color="#888888"><br>
-Otto<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
<br>
On Mon, Feb 13, 2012 at 9:50 AM, Otto <<a href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</a>> wrote:<br>
> I think he has a point in this case. The error is explicitly<br>
> suppressed, so I can't see what the reviewer is doing to make it<br>
> appear.<br>
><br>
> Appending an @ in front a line deliberately turns off errors, so how<br>
> is he seeing it in this case?<br>
><br>
> -Otto<br>
><br>
><br>
><br>
> On Mon, Feb 13, 2012 at 8:24 AM, Chip Bennett <<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>> wrote:<br>
>> Suppressing printing of errors/notices is not a sufficient substitution for<br>
>> eliminating those errors/notices. The guidelines require that Themes be free<br>
>> of PHP notices/errors/warnings, whether those notices/errors/warnings are<br>
>> printed or not.<br>
>><br>
>> Chip<br>
>><br>
>> On Mon, Feb 13, 2012 at 8:13 AM, Kirk Wight <<a href="mailto:kwight@kwight.ca">kwight@kwight.ca</a>> wrote:<br>
>>><br>
>>> Do we make any allowances for Debug Bar errors if error suppression has<br>
>>> been implemented for the errors in question?<br>
>>><br>
>>> In this theme (<a href="https://themes.trac.wordpress.org/ticket/6095" target="_blank">https://themes.trac.wordpress.org/ticket/6095</a>), Debug Bar<br>
>>> will throw an error, even though error suppression has been used to account<br>
>>> for E_NOTICE and E_WARNING notices. Without knowing anything about coding<br>
>>> with error suppression, it feels odd to me (I guess I see submitted themes<br>
>>> using it to get around errors, rather than dealing with them, but I don't<br>
>>> think that's the situation in this case).<br>
>>><br>
>>> What do people think?<br>
>>><br>
>>> _______________________________________________<br>
>>> theme-reviewers mailing list<br>
>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>><br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br>