Cais,<br>Submitting a patch sounds like the right approach. I will work on it.<br><br>Thanks!<br>Sayontan.<br><br><div class="gmail_quote">On Sun, Feb 12, 2012 at 8:23 AM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">@Sayontan -<br><br>Have you considered submitting a ticket and patch for the function you are concerned with? I would imagine that would be the most correct solution to this issue as others may be experiencing the same one you are seeing.<br>
The guideline itself is rather straightforward and meant to deal with the possibility that the "default" translations may not exist. I imagine the potential for cross-over translation strings is immense but only if they exist, otherwise you will be seeing even more poorly translated sites if you expect the default to provide these strings.<br>
<br>Also to note, internationalization is on the 3.4 development list, perhaps you could get involved there as well. Here's a recent update: <a href="http://wpdevel.wordpress.com/2012/02/08/team-update-i18n-our-first-two-week-cycle/" target="_blank">http://wpdevel.wordpress.com/2012/02/08/team-update-i18n-our-first-two-week-cycle/</a><br>
<br><br clear="all">Cais.<div class="HOEnZb"><div class="h5"><br>
<br><br><div class="gmail_quote">On Sat, Feb 11, 2012 at 1:12 PM, Sayontan Sinha <span dir="ltr"><<a href="mailto:sayontan@gmail.com" target="_blank">sayontan@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The theme discussed here is mine. I had actually raised this point earlier prior to coding it: <a href="http://lists.wordpress.org/pipermail/theme-reviewers/2011-December/007526.html" target="_blank">http://lists.wordpress.org/pipermail/theme-reviewers/2011-December/007526.html</a> (you can see the other posts on the thread too). My rationale is this: if I include the theme-slug in the domain, and then my translators don't update the PO and MO files, the strings will not be translated though WP's native translations exist. Additionally, the theme is only translated to 30 odd languages. For all other languages for which WP's translations exist these strings are shown untranslated. This is going to lead to a worse situation than the default.<br>
<br>Also it might be worthwhile to note the context. I am trying to extend a WP class function that doesn't define any hooks. That makes me include the function verbatim, then add my code to it. If there were hooks I wouldn't be required to include the original code, however without the hook I am put in a double-bind with respect to translation.<br>
<br>Sayontan.<div><div><br><br><div class="gmail_quote">On Sat, Feb 11, 2012 at 8:18 AM, George Mamadashvili <span dir="ltr"><<a href="mailto:georgemamadashvili@gmail.com" target="_blank">georgemamadashvili@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
As far as I know themes are not required to be translation ready, but if they are, authors should do i18n properly.<div><br><div class="gmail_quote"><div><div>On Sat, Feb 11, 2012 at 8:04 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div>On Sat, Feb 11, 2012 at 9:41 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>If it's in the Theme, then the Theme needs to provide the translation for the string. It doesn't matter if that same string is in core. We've covered this one quite a bit on the list.<div></div>
</div></blockquote></div><br></div>I agree with the point being made, but we should not expect all theme authors to stay current on all discussions made on the mailing list. If something has been "covered ... quite a bit" then perhaps it also requires an entry in the guidelines as well?<br>
<br><br clear="all">Cais.<br>
<br><br><br>
<br></div></div><div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></div></blockquote></div><br>
</div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br></div></div><span><font color="#888888">-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
--<br>Beating Australia in Cricket is like killing a celebrity. The death gets more coverage than the crime.<br><br>
</font></span><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
--<br>Beating Australia in Cricket is like killing a celebrity. The death gets more coverage than the crime.<br><br>