I'm unaware why it wouldn't be acceptable?<div><br></div><div>The Guideline is to *define* $content_width; the intent is that the defined $content_width is appropriate for the design of the Theme. In other words, the default assumption is that the Theme is defined for a specific width, and then defines a (static) value for $content_width, accordingly.</div>
<div><br></div><div>In other words: making $content_width dynamic is the *exception*, rather than the rule.</div><div><br></div><div>Chip<br><br><div class="gmail_quote">On Wed, Jan 25, 2012 at 6:30 PM, Kirk Wight <span dir="ltr"><<a href="mailto:kwight@kwight.ca">kwight@kwight.ca</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hm, seems like a lot.<div><br></div><div>Maybe my questions is, can we pass a variable-width theme that just uses a reasonable width, say $content_width=640? I'm doing a theme, for a talk, that demonstrates the bare minimum in requirements for approval, so it came up.</div>
<div><br></div><div>I'm leaning towards accepting it - anyone else, for or against?<div><div class="h5"><br><br><div class="gmail_quote">On 25 January 2012 17:54, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I'm not aware of any consensus *best* practice for dynamic content-width; however, I use a method in Oenology that works, and has thus far been robust, for setting $content_width dynamically according to the selected layout (full, one-column, two-column, three-column, etc.). Here's the function:<div>
<a href="https://github.com/chipbennett/oenology/blob/master/functions/theme-setup.php#L33" target="_blank">https://github.com/chipbennett/oenology/blob/master/functions/theme-setup.php#L33</a></div><div><br></div><div>Note that I hook the function both into wp_head with a priority of 0, and also into admin_head (so that it applies to the post editor).</div>
<div><br></div><div>(If anyone has any ideas for improving the implementation, or has any ideas for a better practice altogether, I'll be happy to modify.)</div><span><font color="#888888"><div><br></div>
</font></span><div><span><font color="#888888">Chip<br><br></font></span><div class="gmail_quote"><div>
On Wed, Jan 25, 2012 at 4:41 PM, Kirk Wight <span dir="ltr"><<a href="mailto:kwight@kwight.ca" target="_blank">kwight@kwight.ca</a>></span> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>It seems $content_width has to be in pixels, so unless it's set very small, it's conceivable that the embed test in the Theme Unit Test will overflow the content area at some point.</div><div><br></div><div>
What is the best method for setting $content_width in a variable-width theme?<div>
<br></div></div>
<br></div><div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></div></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>