Okay, good; then this shouldn't be an onerous request.<div><br></div><div>Chip<br><br><div class="gmail_quote">On Tue, Jan 10, 2012 at 8:42 AM, George Mamadashvili <span dir="ltr"><<a href="mailto:georgemamadashvili@gmail.com">georgemamadashvili@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I think all other action hooks are prefixed.<div class="HOEnZb"><div class="h5"><br><br><div class="gmail_quote">On Tue, Jan 10, 2012 at 6:30 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I would hold the ticket open, and ask them to fix and re-upload.<div><br></div><div>Out of curiosity: what is the naming convention for the rest of the template action hooks in Toolbox?</div>
<span><font color="#888888"><div><br></div></font></span><div><span><font color="#888888">Chip</font></span><div><div><br><br>
<div class="gmail_quote">On Tue, Jan 10, 2012 at 8:28 AM, George Mamadashvili <span dir="ltr"><<a href="mailto:georgemamadashvili@gmail.com" target="_blank">georgemamadashvili@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I was checking changes in Toolbox theme and noticed that they added two new hooks that aren't prefix, here's diff
<a href="http://themes.trac.wordpress.org/changeset?old_path=/toolbox/1.3&new_path=/toolbox/1.4" target="_blank">http://themes.trac.wordpress.org/changeset?old_path=/toolbox/1.3&new_path=/toolbox/1.4</a><div><br>
</div><div>Maybe we should add suggestion to theme ticket for future release<div><div><br>
<br><div class="gmail_quote">On Tue, Jan 10, 2012 at 6:19 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Yes. Basically, anything that is/can be in a public namespace should be uniquely prefixed.<div><br></div><div>Thus, a custom action, e.g. 'post_after', should be prefixed, i.e. as 'theme_slug_post_after'. Likewise (and more importantly) with filters.</div>
<div><br></div><div>Chip<br><br><div class="gmail_quote"><div><div>On Tue, Jan 10, 2012 at 8:08 AM, George Mamadashvili <span dir="ltr"><<a href="mailto:georgemamadashvili@gmail.com" target="_blank">georgemamadashvili@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>Shouldn't theme specific actions and filters be prefixed?<div><br></div><div>Thanks</div>
<span><font color="#888888"><div>
<br></div><div>George</div>
</font></span><br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>