Why is a Google Chart shortcode included in a *Theme*, rather than in a Plugin?<div><br></div><div>Chip<br><br><div class="gmail_quote">On Fri, Dec 30, 2011 at 12:27 AM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com">emil@themeid.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Reviewers,</font></font></font></div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><div>
<font color="#333333"><font><font face="arial,helvetica,sans-serif"><br>
</font></font></font></div>In regards to: <a href="http://make.wordpress.org/themes/2011/12/15/getting-the-review-queue-back-on-track/" target="_blank">http://make.wordpress.org/themes/2011/12/15/getting-the-review-queue-back-on-track/</a> and <a href="http://codex.wordpress.org/Theme_Review#Code_Quality" target="_blank">http://codex.wordpress.org/Theme_Review#Code_Quality</a> as well, can we also make sure that <a href="http://codex.wordpress.org/Shortcode_API" target="_blank">Shortcodes</a> are checked as well? Shortcodes can produce <a href="http://php.net/manual/en/function.isset.php" target="_blank">undefined errors</a> and i.e. <a href="http://wordpress.org/extend/plugins/theme-check/" target="_blank">Theme Check</a> will find them, however only if you actually use the shortcodes on any given page/post. Good example is </font></font></font><font color="#333333" face="arial, helvetica, sans-serif"><a href="http://pastebin.com/FEGz56vu" target="_blank">http://pastebin.com/FEGz56vu</a> (Google Chart) all* Themes in repository using this or similar code will have undefined error(s). This is only an example. Some will say that this is harmless, however we still need error free Themes :)</font><div>
<font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Thank you all for your help and Happy Holidays!</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Emil</font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br clear="all">
</font></font></font><div><strong><font face="arial, helvetica, sans-serif">----</font></strong></div><span class="HOEnZb"><font color="#888888"><div><font face="arial, helvetica, sans-serif"><strong>Emil Uzelac</strong> | ThemeID | T: <a href="tel:224-444-0006" value="+12244440006" target="_blank">224-444-0006</a> | Twitter: @EmilUzelac | E: <a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a> | <a href="http://themeid.com/" target="_blank">http://themeid.com</a></font></div>
<div><font color="#999999" face="arial, helvetica, sans-serif">Make everything as simple as possible, but not simpler. - Albert Einstein</font></div><br>
</font></span></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>