I'm wondering why it would be a *bad* thing to say that all Themes must be self-contained, and should not hotlink any resources?<div><br></div><div>(I think API references are okay; e.g. Google Fonts - if they're not there, the CSS will fall back to another font, so the experience might be degraded, but it will degrade mostly gracefully.)</div>
<div><br></div><div>Chip<br><br><div class="gmail_quote">On Sat, Dec 24, 2011 at 9:56 AM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
@Kirk - Leave a comment to the effect of what Otto has suggested why this method should not be used.<br><br>@Otto et al. - This should go into the Guidelines as *not* "best practice", again for the same reason. "Banning" seems like such a harsh word to use, I'm thinking simply not-approve-able due to the potential for "common" end-user conditions to cause the theme to simply not work, i.e.: intranet installation.<br>
<br>I'm thinking something along these lines for the Guidelines: Themes must be self-contained within themselves and/or the WordPress core functionality. For example, externally referenced files may not always be available to the end-user and therefore should not be used.<br>
<br>The question is now where to put that into the guidelines as I recommend it become effective with the "new" 3.3 guidelines. Any one have any suggestions?<br><br><br clear="all">Cais.<div class="HOEnZb"><div class="h5">
<br>
<br><br><div class="gmail_quote">On Fri, Dec 23, 2011 at 7:42 PM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>On Fri, Dec 23, 2011 at 4:32 PM, Kirk Wight <<a href="mailto:kwight@kwight.ca" target="_blank">kwight@kwight.ca</a>> wrote:<br>
> In particular, the theme uses a bunch of external APIs for the post formats;<br>
> I've searched the mailing list archives, and didn't find anything explicitly<br>
> banning it, but, well, it weirds me out. A look at how the options are<br>
> implemented would be appreciated too.<br>
<br>
</div>While there's nothing wrong with the files he's including and the<br>
sources are trustworthy enough, these files should be included in the<br>
theme and not added directly from external sites.<br>
<br>
In particular:<br>
<br>
wp_register_style('html5reset',<br>
'<a href="http://html5resetcss.googlecode.com/files/html5-reset-1.4.css" target="_blank">http://html5resetcss.googlecode.com/files/html5-reset-1.4.css</a>',false,$theme_data['Version']);<br>
wp_enqueue_style( 'html5reset');<br>
wp_register_script('yui-css','<a href="http://yui.yahooapis.com/2.8.0r4/build/yuiloader/yuiloader-min.js" target="_blank">http://yui.yahooapis.com/2.8.0r4/build/yuiloader/yuiloader-min.js</a>',false,'2.8.0r4');<br>
wp_enqueue_script('yui-css');<br>
wp_register_script('jquery-template',<br>
'<a href="http://nje.github.com/jquery-tmpl/jquery.tmpl.js" target="_blank">http://nje.github.com/jquery-tmpl/jquery.tmpl.js</a>', array('jquery'),<br>
'0.1');<br>
wp_enqueue_script('jquery-template');<br>
<br>
This is bad because it adds a dependency on those sites. This means<br>
the theme won't work for some cases, such as on an internal intranet<br>
where the user viewing the site has no access to the public internet<br>
(this is a *far* more common use case than you might think).<br>
<br>
While there's no explicit guidelines prohibiting it that I found in<br>
the theme review list, I kinda sorta think that it should be banned.<br>
There's no good reason a theme can't simply package up these libraries<br>
in the theme, presuming the licenses on the libraries is compatible.<br>
YUI is BSD licensed, JQuery Template is MIT or GPLv2, and the reset<br>
CSS is public domain. All compatible.<br>
<span><font color="#888888"><br>
-Otto<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</font></span></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>