I don't think the criticality needs to change; rather, it's more a matter of how the reviewer handles the observations. Required things are still required, and I don't think that should change.<div><br></div><div>
One way to think about it might be in terms of obvious end-user impact. The textdomain thing is a perfect example: correct implementation is required, but the likelihood of the end user being adversely impacted if the current version of the Theme gets approved is pretty minimal. So, does it provide a better experience for all involved if we approve the Theme, educate the developer about the proper implementation, and then require it to be addressed in the next revision?</div>
<div><br></div><div>I think so.</div><div><br></div><div>Chip<br><br><div class="gmail_quote">On Fri, Dec 16, 2011 at 5:11 PM, James Laws <span dir="ltr"><<a href="mailto:jamielaws@gmail.com">jamielaws@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Perhaps we need to redefine some elements. <br><br>1. Deal breaker<br>2. Required <br>3. Recommended<br><br>;)<span class="HOEnZb"><font color="#888888"><br>
<br>James</font></span><div class="HOEnZb"><div class="h5"><br><br>On Friday, December 16, 2011, Chip Bennett <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>> wrote:<br>
> Oh, I agree completely. Just because it's *required* doesn't mean that the reviewer can't approve it upon the stipulation that the issue is resolved in the next revision.<br>> Provided that the reviewers don't start taking heat for making subjective decisions, I think it would expedite the process to emphasize that such things are at the discretion of the reviewer. If something like the textdomain issue is the only observation in a review, I'm certainly not going to criticize the reviewer exercising such discretion.<br>
> Chip<br>><br>> On Fri, Dec 16, 2011 at 2:35 PM, Edward Caissie <<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>> wrote:<br>>><br>>> Although not technically correct to use a variable for the textdomain as described by Mark; and as Justin noted this is a 3.3 requirement ... we may also want to revisit this as a non-show-stopper issue.<br>
>><br>>> If this is the only issue with the theme then I would expect the theme to, for all intent and purpose, work correctly except for letter-perfect i18n implementation.<br>>> It seems if we truly want to start expediting the process to get themes reviewed we need to revisit some of the guidelines and how they are being interpreted ... for instance I would, given the condition there are no significant issues otherwise, resolve this theme as approved and note the correction should be made in the next (hopefully soon) release.<br>
>><br>>> In this particular case, it would be a logical conclusion to use a variable as the textdomain, I had come to the same idea myself prior to reading Mark Jaquith's post on the subject.<br>>><br>
>><br>>> Cais.<br>>><br>>><br>>> On Sat, Dec 17, 2011 at 12:25 PM, Justin Tadlock <<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>> wrote:<br>>>><br>
>>> Technically, themes will be translated when using a constant or variable. Where it's problematic is with automated translation tools as mentioned by Mark's post.<br>
>>><br>>>> For the 3.3 proposed guidelines, we're requiring it (is it themes submitted 30 days after 3.3 is released?):<br>>>> <a href="http://make.wordpress.org/themes/2011/11/10/wordpress-3-3-proposed-guidelines-revisions/" target="_blank">http://make.wordpress.org/themes/2011/11/10/wordpress-3-3-proposed-guidelines-revisions/</a><br>
>>><br>>>> On 12/16/2011 10:58 AM, Paul de Wouters wrote:<br>>>><br>>>> Referring to this post by Mark Jaquith:<br>>>> <a href="http://markjaquith.wordpress.com/2011/10/06/translating-wordpress-plugins-and-themes-dont-get-clever/" target="_blank">http://markjaquith.wordpress.com/2011/10/06/translating-wordpress-plugins-and-themes-dont-get-clever/</a><br>
>>> is this cause for rejection?<br>>>> thanks<br>>>><br>>>> _______________________________________________<br>>>> theme-reviewers mailing list<br>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>><br>>>> _______________________________________________<br>
>>> theme-reviewers mailing list<br>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>><br>>><br>>><br>>> _______________________________________________<br>>> theme-reviewers mailing list<br>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>><br>><br>>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>