Although not technically correct to use a variable for the textdomain as described by Mark; and as Justin noted this is a 3.3 requirement ... we may also want to revisit this as a non-show-stopper issue.<br><br>If this is the only issue with the theme then I would expect the theme to, for all intent and purpose, work correctly except for letter-perfect i18n implementation.<br>
It seems if we truly want to start expediting the process to get themes reviewed we need to revisit some of the guidelines and how they are being interpreted ... for instance I would, given the condition there are no significant issues otherwise, resolve this theme as approved and note the correction should be made in the next (hopefully soon) release.<br>
<br>In this particular case, it would be a logical conclusion to use a variable as the textdomain, I had come to the same idea myself prior to reading Mark Jaquith's post on the subject.<br><br><br clear="all">Cais.<br>
<br><br><div class="gmail_quote">On Sat, Dec 17, 2011 at 12:25 PM, Justin Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com">justin@justintadlock.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<u></u>
<div bgcolor="#ffffff" text="#000000">
Technically, themes will be translated when using a constant or
variable. Where it's problematic is with automated translation
tools as mentioned by Mark's post.<br>
<br>
For the 3.3 proposed guidelines, we're requiring it (is it themes
submitted 30 days after 3.3 is released?):<br>
<a href="http://make.wordpress.org/themes/2011/11/10/wordpress-3-3-proposed-guidelines-revisions/" target="_blank">http://make.wordpress.org/themes/2011/11/10/wordpress-3-3-proposed-guidelines-revisions/</a><div><div class="h5">
<br>
<br>
On 12/16/2011 10:58 AM, Paul de Wouters wrote:
</div></div><blockquote type="cite"><div><div class="h5">Referring to this post by Mark Jaquith:
<div><a href="http://markjaquith.wordpress.com/2011/10/06/translating-wordpress-plugins-and-themes-dont-get-clever/" target="_blank">http://markjaquith.wordpress.com/2011/10/06/translating-wordpress-plugins-and-themes-dont-get-clever/</a>
</div>
<div><br>
</div>
<div>is this cause for rejection?</div>
<div><br>
</div>
<div>thanks</div>
</div></div><pre><fieldset></fieldset>
_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
</div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>