Thanks for the info Dion, I'll check it.<br><br><div class="gmail_quote">On Thu, Nov 17, 2011 at 11:14 AM, Dion Hulse (dd32) <span dir="ltr"><<a href="mailto:wordpress@dd32.id.au">wordpress@dd32.id.au</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div>Correct.. It's not really designed for Ajax comment submission at present, however, what you can do is:</div>
<div><br></div><div>Submit via Ajax to wp-comments-post.php<br></div><div>Add a hook early in the process to define a new wp_die() handler so as to output the wp_die messages in a Ajax-friendly way (only when your custom "This is a ajax request var is set of course)</div>
<div>Hook in later on 'comment_post_redirect' to return the Ajax "Everythings submitted ok!" status (You'll want to die so it doesn't redirect there)</div><div><br></div><div>That'll cause all comment submission to be handled "normally" so you shouldn't have plugin conflicts as well.</div>
<div><br></div><div>See also:</div><div><a href="http://core.trac.wordpress.org/ticket/18630" target="_blank">http://core.trac.wordpress.org/ticket/18630</a></div><div><a href="http://core.trac.wordpress.org/ticket/16979" target="_blank">http://core.trac.wordpress.org/ticket/16979</a></div>
<div class="HOEnZb"><div class="h5">
<div><br></div><div class="gmail_quote">On 17 November 2011 14:02, Justice <span dir="ltr"><<a href="mailto:justice360@gmail.com" target="_blank">justice360@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
My original intention is for those return values from AJAX requests. For example, when I submit an empty comment, I'll get the error message "Error: please type a comment". It's from the core pot file. When I submit the same empty comment via AJAX, I may expect that same error message. If I always use the theme translation, once the core translation change, they'll be inconsistent. But if the original string changes, the inconsistency will be inevitable. I think there's no perfect sollution because WordPress is just not designed to work with AJAX.<div>
<div><br>
<br><div class="gmail_quote">On Thu, Nov 17, 2011 at 9:54 AM, Dion Hulse (dd32) <span dir="ltr"><<a href="mailto:wordpress@dd32.id.au" target="_blank">wordpress@dd32.id.au</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>That's a lot of extra work for little benefit. <br></div><div><br></div><div>Just include the string as a translatable item in your pot file, that way your users will always get a translated string if it exists for them.</div>
<div><br></div><div>What you suggested was basically "Use cores translated text, otherwise use my translated text, otherwise, use the english text" seems if anything, you'd want to do theme > core > english. </div>
<span><font color="#888888">
<div><br></div><div>D</div></font></span><div><div><br><div class="gmail_quote">2011/11/17 Justice <span dir="ltr"><<a href="mailto:justice360@gmail.com" target="_blank">justice360@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF"><div>That makes sense. Thanks.</div><div>I have another idea to deal with this situation: I can check if the core language pack provides a non-empty translation that is different to the original string and if not, the translation will fallback to that from the theme text domain. Is that feasible?<br>
<br></div><div>Justice</div><div><br>在 2011-11-16，下午11:08，Chip Bennett <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>> 写道：<br><br></div><div><div><blockquote type="cite">
<div>
I don't think using "twentyten" or "twentyeleven" text strings will *ever* work, because if a different Theme is active, then *that Theme's* textdomain will be loaded, and the twentyten/twentyeleven textdomains will NOT be loaded.<div>
<br></div><div>On the question of core: there is no guarantee that the core text strings will never change. If the strings are provided by your Theme, then *your Theme* needs to provide the translation for those strings.</div>
<div><br></div><div>Chip</div><div><br><div class="gmail_quote">On Wed, Nov 16, 2011 at 8:59 AM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Although I may not be well versed in i18n implementation, the correct method for a theme in the repository to support it is to have all text strings visible to the end-user be translatable via the theme's language files thus requiring the textdomain to be included with each instance where an i18n function is used ... even if the code is directly copied and pasted from core.<br>
<br>One cannot assume the text strings being translated will always be available as expected if they are not included with the Theme itself. As with the examples of using the `twentyten` or `twentyeleven` domains, the theme author cannot expect they will always be available as it is possible some end-users may choose to remove all themes except for their active one.<br>
<br><br clear="all">Cais.<div><div><br>
<br><br><div class="gmail_quote">On Wed, Nov 16, 2011 at 9:46 AM, Rick Anderson <span dir="ltr"><<a href="mailto:rick@byobwebsite.com" target="_blank">rick@byobwebsite.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I'm interested in this as well. I recently reviewed a theme that had some missing text domains, some were using twentyten and others were using twentyeleven. I read the section where themes are "required" to provide their theme slug as the text domain.<br>
<br><div class="gmail_quote"><div><div>On Tue, Nov 15, 2011 at 11:09 PM, Justice <span dir="ltr"><<a href="mailto:justice360@gmail.com" target="_blank">justice360@gmail.com</a>></span> wrote:<br></div></div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
Hi all,<br><br>I reused some WordPress core code for AJAX support in my theme so there are some missing text domains when outputing traslatable strings. One reviewer told me that it is required to provide translation in my own language pack for all translatable strings appear in my theme. Actually I left that blank by intention because I'd like to use the same wording as the core language packs of WordPress, eg. Name, Email, Error: please type a comment, etc.<br>
Can anybody tell me why themes can't share the core language pack?<br><br>Thanks for hard working!<br><br>---------------<br>Best regards<br><font color="#888888">Justice<br>
</font><br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><span><font color="#888888"><br><br clear="all"><div><br></div>-- <br><b><font size="4">Rick Anderson</font></b><div><b><i>WordPress Trainer/Web Developer</i></b></div><div><a href="http://www.byobwebsite.com" target="_blank">www.byobwebsite.com</a></div>
<div>935 Daley Street</div><div>Edmonds, WA 98020</div><div><a href="tel:%28206%29%20801-5209" value="+12068015209" target="_blank">(206) 801-5209</a></div><div>Skype - tailoringtheweb</div><br>
</font></span><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>theme-reviewers mailing list</span><br><span><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a></span><br>
<span><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></span><br></div></blockquote></div></div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>