Whoops; yeah, good call. I had forgotten that the "custom-header" tag predated the custom image header functionality.<div><br></div><div>So, forget that part of what I said. :)</div><div><br></div><div>Chip<br><br>
<div class="gmail_quote">On Wed, Sep 7, 2011 at 7:36 PM, Sayontan Sinha <span dir="ltr"><<a href="mailto:sayontan@gmail.com">sayontan@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex" class="gmail_quote">But since you're not actually implementing a *custom image header*, you
should NOT use the "custom-header" tag. That tag is reserved for *custom
image headers*.<br></blockquote><br></div>The "custom-header" tag is NOT reserved for "custom image headers" - at least not as per any documentation. It is quite old and as I mentioned, Kubrick has carried the tag since long before something like the add_custom_image_header came into existence (not that Kubrick is the benchmark, but it still used to be the default theme prior to TwentyTen). If the definition or the intent of the tag changed somewhere down the line, it was not communicated clearly enough. Just like the other older "custom" tags, "custom-background" or "custom-colors", any theme that allowed for differently styling the header/background/font colors could use these tags (and should still be allowed, IMHO).<br>
<br>Anyway, I don't mind removing the tag or amending my code to support it - let's see.<br><br>With regards to the guidelines, the only reason I brought this up is because a reviewer told me I have to implement it. Now whether the reviewer's remark was based on the "custom-header" tag or because my theme does indeed allow true customization of the header in various forms (essentially letting you do everything the native "custom image header" lets you do including changing the text color, hiding the text, and a lot more), I don't know. Regardless, since this issue was never brought up with my theme until the last review, I believe ambiguity exists. Whether or not you decide to reword the guidelines is up to you - I was merely providing feedback, because apparently my interpretation of it differed from the reviewer's.<br>
<br><div class="gmail_quote"><div class="im">On Wed, Sep 7, 2011 at 5:01 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br></div><div>
<div></div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
As Otto said: you're not actually incorporating a *custom image header*. You're actually implementing something more akin to a "custom header background".<div><br></div><div>As Otto said: a *custom image header* is a *fixed-dimension* image, used AS the site header (think along the lines of a *banner*). You're simply allowing a header style customization.</div>
<div><br></div><div>But since you're not actually implementing a *custom image header*, you should NOT use the "custom-header" tag. That tag is reserved for *custom image headers*.</div><div><br></div><div>
As far as I can tell, the Guidelines in this regard are fine, and account for this use case without problem.</div>
<div><br></div><div><font color="#888888">Chip</font><div><div></div><div><br><br><div class="gmail_quote">On Wed, Sep 7, 2011 at 6:35 PM, Sayontan Sinha <span dir="ltr"><<a href="mailto:sayontan@gmail.com" target="_blank">sayontan@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex" class="gmail_quote">The word "recommended" is bolded for a reason. If it said "required"<br>
then we'd be having a different kind of discussion.<br></blockquote>
<br></div>Yes, but it also says that "if incorporated" I have to support the core WP implementation and that is what was pointed out to me in my last review. Technically though, as you have said, this functionality is not a "Custom Image Header". <br>
<br>I have the capability to define a header background like Kubrick did (and I call it a header background). In one way or the other this is still a customizable header, and the theme is tagged with "custom-header" because of it. AFAIK the tags don't distinguish between custom image header and custom header background, and the review team doesn't distinguish either. A reviewer probably sees "custom-header", then looks for a call to add_custom_image_header(). So maybe this is something to note in the review guidelines, then? Or maybe the text for this particular guideline has to be amended?<div>
<div></div><div><br>
<br><div class="gmail_quote">On Wed, Sep 7, 2011 at 4:14 PM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>On Wed, Sep 7, 2011 at 6:10 PM, Sayontan Sinha <<a href="mailto:sayontan@gmail.com" target="_blank">sayontan@gmail.com</a>> wrote:<br>
> So a question for the reviewers - the review guidelines state:<br>
><br>
>> Theme is recommended to incorporate the following WordPress core<br>
>> functionality, but is not required to do so. However, if incorporated,<br>
>> functionality must support the core WordPress implementation:<br>
>><br>
>> add_custom_image_header().<br>
><br>
><br>
> Is it okay to not use the above function with a custom header then?<br>
<br>
</div>The word "recommended" is bolded for a reason. If it said "required"<br>
then we'd be having a different kind of discussion.<br>
<br>
If you're doing something like allowing the user to select tiled<br>
images and implementing them through CSS backgrounds, then that's not<br>
really a "custom image header", as I see it. That's more like a<br>
"custom header background" or something. Maybe the wording could be<br>
better in your theme, to distinguish it? Wording is tricky that way.<br>
<div><div></div><div><br>
-Otto<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br><br clear="all"><br></div></div><div><div></div><div>-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
--<br>Beating Australia in Cricket is like killing a celebrity. The death gets more coverage than the crime.<br><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div></div></div><div><div></div><div class="h5"><br><br clear="all"><br>-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
--<br>Beating Australia in Cricket is like killing a celebrity. The death gets more coverage than the crime.<br><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>