@Chipp, Clear enough, most parts. Thanks.<div><div><br></div><div>1) I've noticed 2 or 3 themes submitted that had no view block for author or tags/categories in the single.php. Associating this related to the parent-child relation, I thought it might be possible to skip.</div>
<div><br></div><div>3) Can't think of a specific case, let's say doing own comment_form() or pagination implementation, or using plain PHP sanitation functions instead of WP stripping with something like wp_filter_nohtml_kses. But more of a custom coding.</div>
<div><br></div><div>4) I have thought about more low level debugging as a continuation of the Theme Check plugin. Last week I had to debug with the WordPress Hook Sniffer and I thought there is a room for more automated pretesting and someone could have already done it. </div>
<div><br></div><div>P.S. 5) Some of the guidelines are still draft ( <a href="http://codex.wordpress.org/Theme_Review#Site_Information">http://codex.wordpress.org/Theme_Review#Site_Information</a> ), I don't know whether to point them or ignore them now.</div>
<div><br></div><div>@Justin - it's always nice to have everything cover but when it isn't and I need to give my personal opinion based on the guidelines I'm not always confident to approve or reject based on some doubts. Most themes I've run into have 'muted' some of the requirements or passed through some sort of workaround when they consider implementing them inappropriate and unnecessary.</div>
<div><br></div><div>All the best,</div><div><br></div><div>Mario Peshev<br>freelance software developer/trainer<br><a href="http://www.linkedin.com/in/mpeshev">http://www.linkedin.com/in/mpeshev</a><br><a href="http://peshev.net/blog">http://peshev.net/blog</a><br>
<br>
<br><br><div class="gmail_quote">On Thu, Aug 4, 2011 at 2:32 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I apologize for any brevity...<div><br></div><div>1) Themes must *incorporate* all of that content, but are given as much latitude as possible for design intent. If the content types are incorporated *somehow*, and implemented properly, then that's usually sufficient.</div>
<div><br></div><div>2) Themes are required to include .wp-caption, .wp-caption-text, and .gallery-caption in style.css. If those classes are left empty, we consider that a design decision. As long as captions are displayed, and are minimally aesthetic, that is acceptable.</div>
<div><br></div><div>Themes must support threaded comments.</div><div><br></div><div>3) That's a case-by-case determination. Generally speaking, *replacing* core code should not be done; if a core method exists, it should be used. Can you provide an example?</div>
<div><br></div><div>4) What sort of verification assistance are you looking for? Automated tests can only go so far, and we're just about as far as we can get with Theme Check, Log Deprecated Notices, Debogger, and Debug Bar.</div>
<div><br></div><div>5) Differentiating between "unacceptable" and "nice to have" is the reason that the Guidelines are rigidly defined using *required* versus *recommended*. (I admit that the Theme Unit Tests could be more clear. For the most part, though: if it's listed in the Theme Unit Tests, it's *required*.)</div>
<div><br></div><div>Chip<br><br><div class="gmail_quote"><div><div></div><div class="h5">On Wed, Aug 3, 2011 at 5:22 PM, Mario Peshev <span dir="ltr"><<a href="mailto:mario@peshev.net" target="_blank">mario@peshev.net</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div></div><div class="h5">
Hello reviewers,<div><br>I'm rereading the unit test and theme review pages on a regular basis in order to remember all the requirements for easier lookup on the new themes. I have some questions that I would be happy to share and get a feedback if possible. They are somehow mentioned in both documents but I find no hundred percent case that covers or states straight.</div>
<div><br></div><div>1) What are the mandatory fields visible for a post in single.php and page.php? According to the test cases and demo content I presume title, author, date, content, tags and categories lists, as well as parent-child relations and paging are required. However Chipp made a remark that parent-child relations visible in the post are not required, I don't find any requirements for categories and tags to be a necessary addition to the single.php, as well as the author and the date. What is the rule of thumb here?</div>
<div><br></div><div>2) Themes usually support image captions and threaded comments. Is a theme not approved if image captions are with standard formatting or threaded comments are not indented?</div><div><br></div><div>3) When theme author has replaced some code such as pagination or commenting with a custom code, is it necessary a bad practice or it depends on the final application?</div>
<div><br></div><div>4) Are there any good plugins for verification beyond the three listed in the guidelines?</div><div><br></div><div>It's hard for me for some clauses to differ the "unacceptable" and "good to have" when I can't strictly read some theme review points as rules. <br>
<br>Best regards,<br clear="all"><br>Mario Peshev<br>freelance software developer/trainer<br><a href="http://www.linkedin.com/in/mpeshev" target="_blank">http://www.linkedin.com/in/mpeshev</a><br><a href="http://peshev.net/blog" target="_blank">http://peshev.net/blog</a><br>
<br>
</div>
<br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div>