I can't see anything wrong with the method being employed here. P2 is doing nothing other than building a dependency array, causing WP to enqueue all scripts in the array, u<i>sing core-defined functionality</i>.<div><br>
</div><div>This isn't concatenation in the same connotation as previously discussed. No files are being modified. Only core files are being used. No versions are being changed from core-bundled versions.</div><div><br>
</div><div>I can't see any other issues with this implementation, other than that Theme Check wasn't sophisticated enough to look for it.</div><div><br></div><div>Chip<br><br><div class="gmail_quote">On Wed, Jul 13, 2011 at 11:36 AM, Sayontan Sinha <span dir="ltr"><<a href="mailto:sayontan@gmail.com">sayontan@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Is this allowed? I thought themes weren't supposed to do things like JS concatenation and that this was strictly plugin territory.<div>
<div></div><div class="h5"><br><br><div class="gmail_quote">On Tue, Jul 12, 2011 at 8:54 PM, Lance Willett <span dir="ltr"><<a href="mailto:nanobar@gmail.com" target="_blank">nanobar@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>> Lance, why is there a bash file? in bin/?<br>
<br>
</div>It's for concatenating JS files into one JS file, for WP.org users<br>
that want to save HTTP requests.<br>
<font color="#888888"><br>
– Lance<br>
</font><div><div></div><div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br><br clear="all"><br></div></div>-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
<font color="#888888">
--<br>Beating Australia in Cricket is like killing a celebrity. The death gets more coverage than the crime.<br><br>
</font><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>